Input: ili210x - Fix reset timing
Subsystems (2)
PATCH v2 1/1 Input: ili210x - Fix reset timing
According to Ilitek "231x & ILI251x Programming Guide" Version: 2.30 "2.1. Power Sequence", "T4 Chip Reset and discharge time" is minimum 10ms and "T2 Chip initial time" is maximum 150ms. Adjust the reset timings such that T4 is 12ms and T2 is 160ms to fit those figures.
This prevents sporadic touch controller start up failures when some systems with at least ILI251x controller boot, without this patch the systems sometimes fail to communicate with the touch controller.
---
V2: Use usleep_range() for shorter 12..15ms delay
--- drivers/input/touchscreen/ili210x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/input/touchscreen/ili210x.c +2 -2
@@ -951,9 +951,9 @@ static int ili210x_i2c_probe(struct i2c_client *client,if (error)return error; -usleep_range (50 ,100 ); +usleep_range (12000 ,15000 );gpiod_set_value_cansleep (reset_gpio,0 ); -msleep (100 ); +msleep (160 ); } priv =devm_kzalloc (dev,sizeof (*priv),GFP_KERNEL );
Signature · 1 line
2.35.1
Quoted 5 lines · Marek Vasut
According to Ilitek "231x & ILI251x Programming Guide" Version: 2.30 "2.1. Power Sequence", "T4 Chip Reset and discharge time" is minimum 10ms and "T2 Chip initial time" is maximum 150ms. Adjust the reset timings such that T4 is 12ms and T2 is 160ms to fit those figures.
Quoted 7 lines
This prevents sporadic touch controller start up failures when some systems with at least ILI251x controller boot, without this patch the systems sometimes fail to communicate with the touch controller.
Fixes 201f3c803544c ("Input: ili210x - add reset GPIO support")Signed-off-by Marek Vasut <[email protected]>Cc Dmitry Torokhov <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry