staging: rts5208: spi.c: clean up dynamic debug code
PATCH v2 1/1 staging: rts5208: spi.c: clean up dynamic debug code
I've condensed the three dev_dbg() lines into one as you requested in the previous patch thread; and sent them all as a singular patch.
fix the following checkpatch.pl warning:
WARNING: Unnecessary ftrace-like logging - prefer using ftrace
Changes in v2:
- Condense three dev_dbg() code lines into one
--- drivers/staging/rts5208/spi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/rts5208/spi.c +1 -4
@@ -460,10 +460,7 @@ int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip) spi->clk_div = ((u16)(srb->cmnd[4 ]) <<8 ) | srb->cmnd[5 ]; spi->write_en = srb->cmnd[6 ]; -dev_dbg (rtsx_dev (chip),"%s: " , __func__); -dev_dbg (rtsx_dev (chip),"spi_clock = %d, " , spi->spi_clock); -dev_dbg (rtsx_dev (chip),"clk_div = %d, " , spi->clk_div); -dev_dbg (rtsx_dev (chip),"write_en = %d\n" , spi->write_en); +dev_dbg (rtsx_dev (chip),"spi_clock = %d, clk_div = %d, write_en = %d\n " , spi->spi_clock, spi->clk_div, spi->write_en);return STATUS_SUCCESS ; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerQuoted 2 lines · Srivathsan Sivakumar
I've condensed the three
dev_dbg()lines into one as you requested in the previous patch thread; and sent them all as a singular patch.
This does not need to be in a changelog text.
Quoted 8 lines
fix the following checkpatch.pl warning:
WARNING: Unnecessary ftrace-like logging - prefer using ftraceSigned-off-by Srivathsan Sivakumar <[email protected]>Changes in v2:
- Condense threedev_dbg()code lines into one
---
The --- line needs to be right below the signed-off-by line as that is where git will cut the changelog at. You don't want the changelog in the commit.
Quoted 8 lines
drivers/staging/rts5208/spi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/staging/rts5208/spi.c +0
-0
drivers/staging/rts5208/spi.c int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip) · line 463
Quoted 8 lines
drivers/staging/rts5208/spi.c +1
-4@@ -460,10 +460,7 @@ int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip) spi->clk_div = ((u16)(srb->cmnd[4 ]) <<8 ) | srb->cmnd[5 ]; spi->write_en = srb->cmnd[6 ]; -dev_dbg (rtsx_dev (chip),"%s: " , __func__); -dev_dbg (rtsx_dev (chip),"spi_clock = %d, " , spi->spi_clock); -dev_dbg (rtsx_dev (chip),"clk_div = %d, " , spi->clk_div); -dev_dbg (rtsx_dev (chip),"write_en = %d\n" , spi->write_en); +dev_dbg (rtsx_dev (chip),"spi_clock = %d, clk_div = %d, write_en = %d\n " , spi->spi_clock, spi->clk_div, spi->write_en);
You might want to verify that you really meant to put that many spaces in this line :(
thanks,
greg k-h
PATCH v2 1/1 staging: rts5208: spi.c: clean up dynamic debug code
Quoted 39 lines · Greg Kroah-Hartman
Quoted 2 lines · Srivathsan Sivakumar
I've condensed the three
dev_dbg()lines into one as you requested in the previous patch thread; and sent them all as a singular patch.This does not need to be in a changelog text.
Quoted 8 lines
fix the following checkpatch.pl warning:
WARNING: Unnecessary ftrace-like logging - prefer using ftraceSigned-off-by Srivathsan Sivakumar <[email protected]>Changes in v2:
- Condense threedev_dbg()code lines into one
---The --- line needs to be right below the signed-off-by line as that is where git will cut the changelog at. You don't want the changelog in the commit.
Quoted 8 lines
drivers/staging/rts5208/spi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/staging/rts5208/spi.c +0
-0drivers/staging/rts5208/spi.c int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip) · line 463
Quoted 8 lines
drivers/staging/rts5208/spi.c +1
-4@@ -460,10 +460,7 @@ int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip) spi->clk_div = ((u16)(srb->cmnd[4 ]) <<8 ) | srb->cmnd[5 ]; spi->write_en = srb->cmnd[6 ]; -dev_dbg (rtsx_dev (chip),"%s: " , __func__); -dev_dbg (rtsx_dev (chip),"spi_clock = %d, " , spi->spi_clock); -dev_dbg (rtsx_dev (chip),"clk_div = %d, " , spi->clk_div); -dev_dbg (rtsx_dev (chip),"write_en = %d\n" , spi->write_en); +dev_dbg (rtsx_dev (chip),"spi_clock = %d, clk_div = %d, write_en = %d\n " , spi->spi_clock, spi->clk_div, spi->write_en);You might want to verify that you really meant to put that many spaces in this line :(
Quoted 3 lines
thanks,
greg k-h
Apologies for the errors, I'll make sure to follow the guidelines more strictly.
I'll implement your remarks and resend the patch soon.
Thanks,
Sri