vdpasim: Off by one in vdpasim_set_group_asid()
Subsystems (2)
PATCH 1/1 vdpasim: Off by one in vdpasim_set_group_asid()
The > comparison needs to be >= to prevent an out of bounds access of the vdpasim->iommu[] array. The vdpasim->iommu[] is allocated in vdpasim_create() and it has vdpasim->dev_attr.nas elements.
Fixes 87e5afeac247 ("vdpasim: control virtqueue support")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vdpa/vdpa_sim/vdpa_sim.c +1 -1
@@ -567,7 +567,7 @@ static int vdpasim_set_group_asid(struct vdpa_device *vdpa, unsigned int group,if (group > vdpasim->dev_attr.ngroups)return -EINVAL ; -if (asid > vdpasim->dev_attr.nas) +if (asid >= vdpasim->dev_attr.nas)return -EINVAL ; iommu = &vdpasim->iommu[asid];
Signature · 6 lines
2.35.1 _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 7 lines · Dan Carpenter
The > comparison needs to be >= to prevent an out of bounds access of the vdpasim->iommu[] array. The vdpasim->iommu[] is allocated in
vdpasim_create()and it hasvdpasim->dev_attr.naselements.Fixes 87e5afeac247 ("vdpasim: control virtqueue support")Signed-off-by Dan Carpenter <[email protected]>
Acked-by Jason Wang <[email protected]>
Quoted 18 lines
--- drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/vdpa/vdpa_sim/vdpa_sim.c +1
-2@@ -567,7 +567,7 @@ static int vdpasim_set_group_asid(struct vdpa_device *vdpa, unsigned int group,if (group > vdpasim->dev_attr.ngroups)return -EINVAL ; -if (asid > vdpasim->dev_attr.nas) +if (asid >= vdpasim->dev_attr.nas)return -EINVAL ; iommu = &vdpasim->iommu[asid]; --
Quoted 2 lines
2.35.1
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization