Skip to contentSkip to conversation

pcmcia: add MIPS_DB1XXX dependence

PATCH In review Stephen Zhang 2 participants 3 messages May 10, 2022 – Jun 2, 2022 Pcmcia

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 pcmcia: add MIPS_DB1XXX dependence

From: Shida Zhang <[email protected]>

drivers/pcmcia/db1xxx_ss.c uses the bcsr_xxxx() from arch/mips/alchemy/devboards/bcsr.c, which causes a link error:

drivers/pcmcia/db1xxx_ss.c:(.text+0x2b4): undefined reference to `bcsr_read'
mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x2fc): undefined reference to bcsr_read' drivers/pcmcia/db1xxx_ss.c:(.text+0x374): undefined reference to bcsr_read'
mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x380): undefined reference to bcsr_read' drivers/pcmcia/db1xxx_ss.c:(.text+0x534): undefined reference to bcsr_read' drivers/pcmcia/db1xxx_ss.c:(.text+0xcc8): undefined reference to `bcsr_mod'

So add MIPS_DB1XXX dependence.

---
Changes from v1:
- Rewrite the commit message.
Changes from v2:
- Give credit to k2ci for reporting the issue.

---
 drivers/pcmcia/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pcmcia/Kconfig +1 -1
index 2ce261cfff8e..04b51cb67fbf 100644
@@ -151,7 +151,7 @@ config TCIC
 
 config PCMCIA_ALCHEMY_DEVBOARD
 	tristate "Alchemy Db/Pb1xxx PCMCIA socket services"
-	depends on MIPS_ALCHEMY && PCMCIA
+	depends on MIPS_ALCHEMY && MIPS_DB1XXX && PCMCIA
 	help
 	  Enable this driver of you want PCMCIA support on your Alchemy
 	  Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300
Signature · 1 line
2.30.2
#1 lore raw

ping

Quoted 45 lines · Stephen Zhang <[email protected]> 于2022年5月10日周二 10:33写道:

From: Shida Zhang <[email protected]>

drivers/pcmcia/db1xxx_ss.c uses the bcsr_xxxx() from arch/mips/alchemy/devboards/bcsr.c, which causes a link error:

drivers/pcmcia/db1xxx_ss.c:(.text+0x2b4): undefined reference to `bcsr_read'
mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x2fc): undefined reference to bcsr_read' drivers/pcmcia/db1xxx_ss.c:(.text+0x374): undefined reference to bcsr_read'
mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x380): undefined reference to bcsr_read' drivers/pcmcia/db1xxx_ss.c:(.text+0x534): undefined reference to bcsr_read' drivers/pcmcia/db1xxx_ss.c:(.text+0xcc8): undefined reference to `bcsr_mod'

So add MIPS_DB1XXX dependence.

---
Changes from v1:
- Rewrite the commit message.
Changes from v2:
- Give credit to k2ci for reporting the issue.

---
 drivers/pcmcia/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pcmcia/Kconfig +1 -2
index 2ce261cfff8e..04b51cb67fbf 100644
@@ -151,7 +151,7 @@ config TCIC
 
 config PCMCIA_ALCHEMY_DEVBOARD
        tristate "Alchemy Db/Pb1xxx PCMCIA socket services"
-       depends on MIPS_ALCHEMY && PCMCIA
+       depends on MIPS_ALCHEMY && MIPS_DB1XXX && PCMCIA
        help
          Enable this driver of you want PCMCIA support on your Alchemy
          Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300
--

2.30.2

#2 lore raw

A different variant is upstream now, see

	https://git.kernel.org/torvalds/c/2380dd691e1fe1ebe3f346d0ce54f8fc7eacc167

Thanks,
Dominik

Am Thu, Jun 02, 2022 at 02:23:43PM +0800 schrieb Stephen Zhang:

Quoted 48 lines

ping

Quoted 45 lines · Stephen Zhang <[email protected]> 于2022年5月10日周二 10:33写道:

From: Shida Zhang <[email protected]>

drivers/pcmcia/db1xxx_ss.c uses the bcsr_xxxx() from arch/mips/alchemy/devboards/bcsr.c, which causes a link error:

drivers/pcmcia/db1xxx_ss.c:(.text+0x2b4): undefined reference to `bcsr_read'
mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x2fc): undefined reference to bcsr_read' drivers/pcmcia/db1xxx_ss.c:(.text+0x374): undefined reference to bcsr_read'
mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x380): undefined reference to bcsr_read' drivers/pcmcia/db1xxx_ss.c:(.text+0x534): undefined reference to bcsr_read' drivers/pcmcia/db1xxx_ss.c:(.text+0xcc8): undefined reference to `bcsr_mod'

So add MIPS_DB1XXX dependence.

---
Changes from v1:
- Rewrite the commit message.
Changes from v2:
- Give credit to k2ci for reporting the issue.

---
 drivers/pcmcia/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pcmcia/Kconfig +1 -2
index 2ce261cfff8e..04b51cb67fbf 100644
@@ -151,7 +151,7 @@ config TCIC
 
 config PCMCIA_ALCHEMY_DEVBOARD
        tristate "Alchemy Db/Pb1xxx PCMCIA socket services"
-       depends on MIPS_ALCHEMY && PCMCIA
+       depends on MIPS_ALCHEMY && MIPS_DB1XXX && PCMCIA
        help
          Enable this driver of you want PCMCIA support on your Alchemy
          Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300
--

2.30.2