Skip to contentSkip to conversation

mainline build failure due to fa84f89395e0 ("irqchip/loongson-liointc: Fix build error for LoongArch")

DISCUSSION Sudip Mukherjee 3 participants 3 messages Jun 4, 2022 MIPS

lore
Share & tools
lore

Sudip Mukherjee

author
#0 lore raw

Hi All,

The latest mainline kernel branch fails to build for "mips loongson2k_defconfig" with the error:

drivers/irqchip/irq-loongson-liointc.c: In function 'liointc_chained_handle_irq':
drivers/irqchip/irq-loongson-liointc.c:60:20: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration]
60 | int core = cpu_logical_map(smp_processor_id()) % LIOINTC_NUM_CORES;

git bisect pointed to fa84f89395e0 ("irqchip/loongson-liointc: Fix build error for LoongArch")

And, reverting it on top of mainline branch has fixed the build failure.

--
Regards
Sudip

#1 lore raw
Quoted 5 lines · Sudip Mukherjee

Hi All,

The latest mainline kernel branch fails to build for "mips loongson2k_defconfig" with the error:

Quoted 8 lines

drivers/irqchip/irq-loongson-liointc.c: In function 'liointc_chained_handle_irq':
drivers/irqchip/irq-loongson-liointc.c:60:20: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration]

    60 |         int core = cpu_logical_map(smp_processor_id()) % LIOINTC_NUM_CORES;

git bisect pointed to fa84f89395e0 ("irqchip/loongson-liointc: Fix build error for LoongArch")

And, reverting it on top of mainline branch has fixed the build failure.

Thanks for the reminder.
I'll prepare a patch for it.

Thanks
- Jiaxun

Quoted 4 lines

--
Regards
Sudip

#2 lore raw
In reply to Sudip Mukherjee

Hi, Sudip,

Quoted 6 lines · Sudip Mukherjee

Hi All,

The latest mainline kernel branch fails to build for "mips loongson2k_defconfig" with the error:

Quoted 8 lines

drivers/irqchip/irq-loongson-liointc.c: In function 'liointc_chained_handle_irq':
drivers/irqchip/irq-loongson-liointc.c:60:20: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration]
60 | int core = cpu_logical_map(smp_processor_id()) % LIOINTC_NUM_CORES;

git bisect pointed to fa84f89395e0 ("irqchip/loongson-liointc: Fix build error for LoongArch")

And, reverting it on top of mainline branch has fixed the build failure.

Jiaxun has already sent a patch to fix it.

Huacai

Quoted 4 lines

--
Regards
Sudip