Skip to contentSkip to conversation

RDMA/erdma: remove unneeded semicolon

PATCH In review Yang Li 4 participants 5 messages Jun 8, 2022

Subsystems (2)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 RDMA/erdma: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon

---
 drivers/infiniband/hw/erdma/erdma_qp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/erdma/erdma_qp.c +1 -1
index 6d49095662c8..a33b29ef11a5 100644
@@ -251,7 +251,7 @@ static int fill_inline_data(struct erdma_qp *qp,
 					       qp->attrs.sq_size, SQEBB_SHIFT);
 			if (!remain_size)
 				break;
-		};
+		}
 
 		i++;
 	}
Signature · 1 line
2.20.1.7.g153144c
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Yang Li

Eliminate the following coccicheck warning:
./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon

Thanks.

Jason,

BTW, are this and other two patches for erdma posted today parts of the static checker reports which you mentioned in [1] ? If so, I think I should re-post the v10 patches including the fixes ?

Thanks,
Cheng Xu

[1] https://lore.kernel.org/linux-rdma/[email protected]/

#2 lore raw
Quoted 11 lines · Cheng Xu
Quoted 5 lines · Yang Li

Eliminate the following coccicheck warning:
./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon

Quoted 8 lines

Thanks.

Jason,

BTW, are this and other two patches for erdma posted today parts of the static checker reports which you mentioned in [1] ? If so, I think I should re-post the v10 patches including the fixes ?

Yes, the fixes need to be squashed into the relevant patches.

Thanks

Quoted 5 lines

Thanks,
Cheng Xu

[1] https://lore.kernel.org/linux-rdma/[email protected]/

maintainer
#3 lore raw
Quoted 17 lines · Leon Romanovsky
Quoted 16 lines · Cheng Xu
Quoted 5 lines · Yang Li

Eliminate the following coccicheck warning:
./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon

Thanks.

Jason,

Quoted 8 lines
Quoted 3 lines

BTW, are this and other two patches for erdma posted today parts of the static checker reports which you mentioned in [1] ? If so, I think I should re-post the v10 patches including the fixes ?

Yes, the fixes need to be squashed into the relevant patches.

Thanks

Get it, thanks.
Cheng Xu

Quoted 5 lines
Quoted 5 lines

Thanks,
Cheng Xu

[1] https://lore.kernel.org/linux-rdma/[email protected]/

#4 lore raw
In reply to Cheng Xu
Quoted 11 lines · Cheng Xu
Quoted 5 lines · Yang Li

Eliminate the following coccicheck warning:
./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon

Quoted 8 lines

Thanks.

Jason,

BTW, are this and other two patches for erdma posted today parts of the static checker reports which you mentioned in [1] ? If so, I think I should re-post the v10 patches including the fixes ?

Yes, and I would wait for a week or so because this is just the first day.

Jason