KVM: selftests: Overhaul APIs, purge VCPU_ID
Subsystems (5)
Anup Patel
maintainerQuoted 2 lines · Paolo Bonzini
Marc, Christian, Anup, can you please give this a go?
Sure, I will try this series.
Regards,
Anup
Quoted 324 lines
Paolo
Quoted 319 lines · Sean Christopherson
Overhaul KVM's selftest APIs to get selftests to a state where adding new features and writing tests is less painful/disgusting.
Patches 1 fixes a goof in kvm/queue and should be squashed.
I would really, really, really like to get this queued up sooner than later, or maybe just thrown into a separate selftests-specific branch that folks can develop against. Rebasing is tedious, frustrating, and time consuming. And spoiler alert, there's another 42 x86-centric patches inbound that builds on this series to clean up CPUID related crud...
The primary theme is to stop treating tests like second class citizens. Stop hiding vcpu,
kvm_vm, etc... There's no sensitive data/constructs, and the encapsulation has led to really, really bad and difficult to maintain code. E.g. having to pass around the VM just to call a vCPUioctl(), arbitrary non-zero vCPU IDs, tests having to care about the vCPU ID in the first place, etc...The other theme in the rework is to deduplicate code and try to set us up for success in the future. E.g. provide macros/helpers instead of spamming CTRL-C => CTRL-V (see the -1k LoC), structure the VM creation APIs to build on one another, etc...
The absurd patch count (as opposed to just ridiculous) is due to converting each test away from using hardcoded vCPU IDs in a separate patch. The vast majority of those patches probably aren't worth reviewing in depth, the changes are mostly mechanical in nature.
However, _running_ non-x86 tests (or tests that have unique non-x86 behavior) would be extremely valuable. All patches have been compile tested on x86, arm, risc-v, and s390, but I've only run the tests on x86. Based on my track record for the x86+common tests, I will be very, very surprised if I didn't break any of the non-x86 tests, e.g. pthread_create()'s 'void *' param tripped me up multiple times.
I have not run x86's
amx_testdue to lack of hardware. I also haven't runsev_migration; something is wonky in either the upstream support forINIT_EXor in our test machines and I can't get SEV to initialize.v2:
- Drop the forced -Werror patch. [Vitaly]
- AddTEST_REQUIREto reduceKSFT_SKIPboilerplate.
- Rebase to kvm/queue, commit55371f1d0c01.
- Clean up even more bad copy+paste code (x86 was hiding a lot of crud).
- Assert that the input to anioctl()is (likely) the correct struct.v1: https://lore.kernel.org/all/[email protected]
Sean Christopherson (144):
KVM: Fix references to non-existentKVM_CAP_TRIPLE_FAULT_EVENT
KVM: selftests: Fix buggy-but-benign check in
test_v3_new_redist_regions()
KVM: selftests: Fix typo invgic_inittest
KVM: selftests: Drop stale declarations fromkvm_util_base.h
KVM: selftests: Always open VM file descriptors withO_RDWR
KVM: selftests: Add another underscore to innerioctl()helpers
KVM: selftests: Makevcpu_ioctl()a wrapper to pretty print ioctl name
KVM: selftests: Drop @mode from commonvm_create()helper
KVM: selftests: Splitvcpu_set_nested_state()into two helpers
KVM: sefltests: Usevcpu_ioctl()and__vcpu_ioctl()helpers
KVM: selftests: Add__vcpu_run()helper
KVM: selftests: Usevcpu_access_device_attr()in arm64 code
KVM: selftests: Removevcpu_get_fd()
KVM: selftests: Addvcpu_get()to retrieve and assert on vCPU
existence
KVM: selftests: Makevm_ioctl()a wrapper to pretty print ioctl name
KVM: sefltests: Usevm_ioctl()and__vm_ioctl()helpers
KVM: selftests: Makekvm_ioctl()a wrapper to pretty print ioctl name
KVM: selftests: Usekvm_ioctl()helpers
KVM: selftests: Use__KVM_SYSCALL_ERROR()to handle non-KVM syscall
errors
KVM: selftests: Make x86-64's register dump helpers static
KVM: selftests: Get rid ofkvm_util_internal.h
KVM: selftests: UseKVM_IOCTL_ERROR()for one-off arm64 ioctls
KVM: selftests: Drop @test param fromkvm_create_device()
KVM: selftests: MoveKVM_CREATE_DEVICE_TESTcode to separate helper
KVM: selftests: Multiplex return code and fd in__kvm_create_device()
KVM: selftests: RenameKVM_HAS_DEVICE_ATTRhelpers for consistency
KVM: selftests: Drop 'int' return from asserting*_has_device_attr()
KVM: selftests: Split get/setdevice_attrhelpers
KVM: selftests: Add a VM backpointer to 'struct vcpu'
KVM: selftests: ConsolidateKVM_ENABLE_CAPusage
KVM: selftests: SimplifyKVM_ENABLE_CAPhelper APIs
KVM: selftests: Cache list of MSRs to save/restore
KVM: selftests: Harden and comment XSS /KVM_SET_MSRSinteraction
KVM: selftests: Dedup MSR index list helpers, simplify dedicated test
KVM: selftests: RenameMP_STATEandGUEST_DEBUGhelpers for
consistency
KVM: selftest: Add proper helpers for x86-specific save/restore ioctls
KVM: selftests: Add vm_create_*() variants to expose/return 'struct
vcpu'
KVM: selftests: Pushvm_adjust_num_guest_pages()into "w/o vCPUs"
helper
KVM: selftests: Usevm_create_without_vcpus()inset_boot_cpu_id
KVM: selftests: Usevm_create_without_vcpus()indirty_log_test
KVM: selftests: Usevm_create_without_vcpus()inhardware_disable_test
KVM: selftests: Usevm_create_without_vcpus()inpsci_test
KVM: selftests: Renamevm_create()=>vm_create_barebones(), drop
param
KVM: selftests: Renamevm_create_without_vcpus()=>vm_create()
KVM: selftests: Makevm_create()a wrapper that specifies
VM_MODE_DEFAULT
KVM: selftests: Rename xAPIC state test's vcpu struct
KVM: selftests: Rename vcpu.state => vcpu.run
KVM: selftests: Rename 'struct vcpu' to 'structkvm_vcpu'
KVM: selftests: Return the created vCPU fromvm_vcpu_add()
KVM: selftests: Convertmemslot_perf_testaway fromVCPU_ID
KVM: selftests: Convertrseq_testaway fromVCPU_ID
KVM: selftests: Convertxss_msr_testaway fromVCPU_ID
KVM: selftests: Convertvmx_preemption_timer_testaway fromVCPU_ID
KVM: selftests: Convertvmx_pmu_msrs_testaway fromVCPU_ID
KVM: selftests: Convertvmx_set_nested_state_testaway fromVCPU_ID
KVM: selftests: Convertvmx_tsc_adjust_testaway fromVCPU_ID
KVM: selftests: Convertmmu_role_testaway fromVCPU_ID
KVM: selftests: Convertpmu_event_filter_testaway fromVCPU_ID
KVM: selftests: Convertsmm_testaway fromVCPU_ID
KVM: selftests: Convertstate_testaway fromVCPU_ID
KVM: selftests: Convertsvm_int_ctl_testaway fromVCPU_ID
KVM: selftests: Convertsvm_vmcall_testaway fromVCPU_ID
KVM: selftests: Convertsync_regs_testaway fromVCPU_ID
KVM: selftests: Converthyperv_cpuidaway fromVCPU_ID
KVM: selftests: Convertkvm_pv_testaway fromVCPU_ID
KVM: selftests: Convertplatform_info_testaway fromVCPU_ID
KVM: selftests: Convertvmx_nested_tsc_scaling_testaway fromVCPU_ID
KVM: selftests: Convertset_sregs_testaway fromVCPU_ID
KVM: selftests: Convertvmx_dirty_log_testaway fromVCPU_ID
KVM: selftests: Convertvmx_close_while_nested_testaway fromVCPU_ID
KVM: selftests: Convertvmx_apic_access_testaway fromVCPU_ID
KVM: selftests: Convertuserspace_msr_exit_testaway fromVCPU_ID
KVM: selftests: Convertvmx_exception_with_invalid_guest_stateaway
fromVCPU_ID
KVM: selftests: Converttsc_msrs_testaway fromVCPU_ID
KVM: selftests: Convertkvm_clock_testaway fromVCPU_ID
KVM: selftests: Converthyperv_svm_testaway fromVCPU_ID
KVM: selftests: Converthyperv_featuresaway fromVCPU_ID
KVM: selftests: Converthyperv_clockaway fromVCPU_ID
KVM: selftests: Convertevmcs_testaway fromVCPU_ID
KVM: selftests: Convertemulator_error_testaway fromVCPU_ID
KVM: selftests: Convertdebug_regsaway fromVCPU_ID
KVM: selftests: Add proper helper for advancing RIP indebug_regs
KVM: selftests: Convertamx_testaway fromVCPU_ID
KVM: selftests: Convertcr4_cpuid_sync_testaway fromVCPU_ID
KVM: selftests: Convertcpuid_testaway fromVCPU_ID
KVM: selftests: Convertuserspace_io_testaway fromVCPU_ID
KVM: selftests: Convertvmx_invalid_nested_guest_stateaway from
VCPU_ID
KVM: selftests: Convertxen_vmcall_testaway fromVCPU_ID
KVM: selftests: Convertxen_shinfo_testaway fromVCPU_ID
KVM: selftests: Convertdirty_log_testaway fromVCPU_ID
KVM: selftests: Convertset_memory_region_testaway fromVCPU_ID
KVM: selftests: Convertsystem_counter_offset_testaway fromVCPU_ID
KVM: selftests: Trackkvm_vcpuobject intsc_scaling_sync
KVM: selftests: Convertxapic_state_testaway from hardcoded vCPU ID
KVM: selftests: Convert debug-exceptions away fromVCPU_ID
KVM: selftests: Convertfix_hypercall_testaway fromVCPU_ID
KVM: selftests: Convertvgic_irqaway fromVCPU_ID
KVM: selftests: Make arm64'sguest_get_vcpuid()declaration arm64-only
KVM: selftests: Movevm_is_unrestricted_guest()to x86-64
KVM: selftests: Add "arch" to common utils that have arch
implementations
KVM: selftests: Return created vcpu fromvm_vcpu_add_default()
KVM: selftests: Rename vm_vcpu_add* helpers to better show
relationships
KVM: selftests: Convertset_boot_cpu_idaway from globalVCPU_IDs
KVM: selftests: Convertpsci_testaway fromVCPU_ID
KVM: selftests: Converthardware_disable_testto pass around vCPU
objects
KVM: selftests: Add VM creation helper that "returns" vCPUs
KVM: selftests: Convertsteal_timeaway fromVCPU_ID
KVM: selftests: Convertarch_timeraway fromVCPU_ID
KVM: selftests: Convertsvm_nested_soft_inject_testaway fromVCPU_ID
KVM: selftests: Converttriple_fault_event_testaway fromVCPU_ID
KVM: selftests: Convertvgic_initaway from
vm_create_default_with_vcpus()
KVM: selftests: Consolidate KVM_{G,S}ET_ONE_REG helpers
KVM: selftests: Sync stage before VM is freed in hypercalls test
KVM: selftests: Convert hypercalls test away fromvm_create_default()
KVM: selftests: Convertxapic_ipi_testaway from*_VCPU_ID
KVM: selftests: Convertsync_regs_testaway fromVCPU_ID
KVM: selftests: Convert s390's "resets" test away fromVCPU_ID
KVM: selftests: Convert memop away fromVCPU_ID
KVM: selftests: Convert s390x/diag318_test_handler away fromVCPU_ID
KVM: selftests: Convert tprot away fromVCPU_ID
KVM: selftests: Usevm_create()intsc_scaling_sync
KVM: selftests: Usevm_create_with_vcpus()inmax_guest_memory_test
KVM: selftests: Drop vm_create_default* helpers
KVM: selftests: Drop @vcpuids param from VM creators
KVM: selftests: Convertkvm_page_table_testaway from reliance on
vcpu_id
KVM: selftests: Convertkvm_binary_stats_testaway from vCPU IDs
KVM: selftests: Convert get-reg-list away from its "VCPU_ID"
KVM: selftests: Stop hardcoding vCPU IDs invcpu_width_config
KVM: selftests: Stop conflating vCPU index and ID in perf tests
KVM: selftests: Removevcpu_get()usage fromdirty_log_test
KVM: selftests: Require vCPU output array when creating VM with vCPUs
KVM: selftests: Purge vm+vcpu_id == vcpu silliness
KVM: selftests: Dropvcpu_get(), renamevcpu_find()=>vcpu_exists()
KVM: selftests: Removevcpu_state()helper
KVM: selftests: Open code and drop 'structkvm_vm' accessors
KVM: selftests: Drop @slot0_mem_pages from__vm_create_with_vcpus()
KVM: selftests: Drop @num_percpu_pages from__vm_create_with_vcpus()
KVM: selftests: Move per-VM/per-vCPU nr pages calculation to__vm_create()KVM: selftests: Trust that MAXPHYADDR > memslot0 in
vmx_apic_access_test
KVM: selftests: DropDEFAULT_GUEST_PHY_PAGES, open code the magic
number
KVM: selftests: Return an 'unsigned int' fromkvm_check_cap()
KVM: selftests: Addkvm_has_cap()to provide syntactic sugar
KVM: selftests: AddTEST_REQUIREmacros to reduce skipping copy+paste
KVM: selftests: Sanity check input toioctls()at build timeDocumentation/virt/kvm/api.rst | 4 +- .../selftests/kvm/aarch64/arch_timer.c | 79 +- .../selftests/kvm/aarch64/debug-exceptions.c | 22 +- .../selftests/kvm/aarch64/get-reg-list.c | 29 +- .../selftests/kvm/aarch64/hypercalls.c | 90 +- .../testing/selftests/kvm/aarch64/psci_test.c | 69 +- .../selftests/kvm/aarch64/vcpu_width_config.c | 71 +- .../testing/selftests/kvm/aarch64/vgic_init.c | 379 +++--- .../testing/selftests/kvm/aarch64/vgic_irq.c | 40 +- .../selftests/kvm/access_tracking_perf_test.c | 92 +- .../selftests/kvm/demand_paging_test.c | 49 +- .../selftests/kvm/dirty_log_perf_test.c | 51 +- tools/testing/selftests/kvm/dirty_log_test.c | 95 +- .../selftests/kvm/hardware_disable_test.c | 29 +- .../selftests/kvm/include/aarch64/processor.h | 28 +- .../selftests/kvm/include/aarch64/vgic.h | 6 +- .../selftests/kvm/include/kvm_util_base.h | 743 ++++++++--- .../selftests/kvm/include/perf_test_util.h | 5 +- .../selftests/kvm/include/riscv/processor.h | 20 - .../testing/selftests/kvm/include/test_util.h | 9 + .../selftests/kvm/include/ucall_common.h | 2 +- .../selftests/kvm/include/x86_64/evmcs.h | 2 +- .../selftests/kvm/include/x86_64/processor.h | 109 +- .../selftests/kvm/kvm_binary_stats_test.c | 31 +- .../selftests/kvm/kvm_create_max_vcpus.c | 10 +- .../selftests/kvm/kvm_page_table_test.c | 66 +- .../selftests/kvm/lib/aarch64/processor.c | 81 +- .../testing/selftests/kvm/lib/aarch64/ucall.c | 9 +- .../testing/selftests/kvm/lib/aarch64/vgic.c | 54 +- tools/testing/selftests/kvm/lib/elf.c | 1 - tools/testing/selftests/kvm/lib/guest_modes.c | 6 +- tools/testing/selftests/kvm/lib/kvm_util.c | 1104 +++-------------- .../selftests/kvm/lib/kvm_util_internal.h | 128 -- .../selftests/kvm/lib/perf_test_util.c | 84 +- .../selftests/kvm/lib/riscv/processor.c | 111 +- tools/testing/selftests/kvm/lib/riscv/ucall.c | 14 +- .../kvm/lib/s390x/diag318_test_handler.c | 11 +- .../selftests/kvm/lib/s390x/processor.c | 44 +- tools/testing/selftests/kvm/lib/s390x/ucall.c | 8 +- .../selftests/kvm/lib/x86_64/processor.c | 533 +++----- tools/testing/selftests/kvm/lib/x86_64/svm.c | 6 +- .../testing/selftests/kvm/lib/x86_64/ucall.c | 10 +- tools/testing/selftests/kvm/lib/x86_64/vmx.c | 16 +- .../selftests/kvm/max_guest_memory_test.c | 53 +- .../kvm/memslot_modification_stress_test.c | 13 +- .../testing/selftests/kvm/memslot_perf_test.c | 28 +- tools/testing/selftests/kvm/rseq_test.c | 22 +- tools/testing/selftests/kvm/s390x/memop.c | 93 +- tools/testing/selftests/kvm/s390x/resets.c | 140 ++- .../selftests/kvm/s390x/sync_regs_test.c | 45 +- tools/testing/selftests/kvm/s390x/tprot.c | 25 +- .../selftests/kvm/set_memory_region_test.c | 43 +- tools/testing/selftests/kvm/steal_time.c | 120 +- .../kvm/system_counter_offset_test.c | 35 +- tools/testing/selftests/kvm/x86_64/amx_test.c | 56 +- .../testing/selftests/kvm/x86_64/cpuid_test.c | 29 +- .../kvm/x86_64/cr4_cpuid_sync_test.c | 22 +- .../testing/selftests/kvm/x86_64/debug_regs.c | 77 +- .../kvm/x86_64/emulator_error_test.c | 74 +- .../testing/selftests/kvm/x86_64/evmcs_test.c | 61 +- .../selftests/kvm/x86_64/fix_hypercall_test.c | 45 +- .../kvm/x86_64/get_msr_index_features.c | 117 +- .../selftests/kvm/x86_64/hyperv_clock.c | 25 +- .../selftests/kvm/x86_64/hyperv_cpuid.c | 34 +- .../selftests/kvm/x86_64/hyperv_features.c | 61 +- .../selftests/kvm/x86_64/hyperv_svm_test.c | 20 +- .../selftests/kvm/x86_64/kvm_clock_test.c | 29 +- .../selftests/kvm/x86_64/kvm_pv_test.c | 33 +- .../kvm/x86_64/max_vcpuid_cap_test.c | 28 +- .../selftests/kvm/x86_64/mmio_warning_test.c | 16 +- .../selftests/kvm/x86_64/mmu_role_test.c | 30 +- .../selftests/kvm/x86_64/platform_info_test.c | 51 +- .../kvm/x86_64/pmu_event_filter_test.c | 97 +- .../selftests/kvm/x86_64/set_boot_cpu_id.c | 91 +- .../selftests/kvm/x86_64/set_sregs_test.c | 47 +- .../selftests/kvm/x86_64/sev_migrate_tests.c | 120 +- tools/testing/selftests/kvm/x86_64/smm_test.c | 37 +- .../testing/selftests/kvm/x86_64/state_test.c | 29 +- .../selftests/kvm/x86_64/svm_int_ctl_test.c | 21 +- .../kvm/x86_64/svm_nested_soft_inject_test.c | 17 +- .../selftests/kvm/x86_64/svm_vmcall_test.c | 16 +- .../selftests/kvm/x86_64/sync_regs_test.c | 62 +- .../kvm/x86_64/triple_fault_event_test.c | 39 +- .../selftests/kvm/x86_64/tsc_msrs_test.c | 35 +- .../selftests/kvm/x86_64/tsc_scaling_sync.c | 25 +- .../selftests/kvm/x86_64/userspace_io_test.c | 18 +- .../kvm/x86_64/userspace_msr_exit_test.c | 187 ++- .../kvm/x86_64/vmx_apic_access_test.c | 27 +- .../kvm/x86_64/vmx_close_while_nested_test.c | 17 +- .../selftests/kvm/x86_64/vmx_dirty_log_test.c | 13 +- .../vmx_exception_with_invalid_guest_state.c | 68 +- .../x86_64/vmx_invalid_nested_guest_state.c | 18 +- .../kvm/x86_64/vmx_nested_tsc_scaling_test.c | 29 +- .../selftests/kvm/x86_64/vmx_pmu_caps_test.c | 48 +- .../kvm/x86_64/vmx_preemption_timer_test.c | 35 +- .../kvm/x86_64/vmx_set_nested_state_test.c | 91 +- .../kvm/x86_64/vmx_tsc_adjust_test.c | 13 +- .../selftests/kvm/x86_64/xapic_ipi_test.c | 48 +- .../selftests/kvm/x86_64/xapic_state_test.c | 60 +- .../selftests/kvm/x86_64/xen_shinfo_test.c | 73 +- .../selftests/kvm/x86_64/xen_vmcall_test.c | 25 +- .../selftests/kvm/x86_64/xss_msr_test.c | 56 +- 102 files changed, 3059 insertions(+), 4178 deletions(-)delete mode 100644
tools/testing/selftests/kvm/lib/kvm_util_internal.hbase-commit:
55371f1d0c01357f29da613f7525c3f252320bbf
Anup Patel
maintainerQuoted 6 lines · Anup Patel
Quoted 2 lines · Paolo Bonzini
Marc, Christian, Anup, can you please give this a go?
Sure, I will try this series.
I tried to apply this series on top of kvm/next and kvm/queue but I always get conflicts. It seems this series is dependent on other in-flight patches.
Is there a branch somewhere in a public repo ?
Regards,
Anup
Quoted 328 lines
Regards,
AnupQuoted 324 lines
Paolo
Quoted 319 lines · Sean Christopherson
Overhaul KVM's selftest APIs to get selftests to a state where adding new features and writing tests is less painful/disgusting.
Patches 1 fixes a goof in kvm/queue and should be squashed.
I would really, really, really like to get this queued up sooner than later, or maybe just thrown into a separate selftests-specific branch that folks can develop against. Rebasing is tedious, frustrating, and time consuming. And spoiler alert, there's another 42 x86-centric patches inbound that builds on this series to clean up CPUID related crud...
The primary theme is to stop treating tests like second class citizens. Stop hiding vcpu,
kvm_vm, etc... There's no sensitive data/constructs, and the encapsulation has led to really, really bad and difficult to maintain code. E.g. having to pass around the VM just to call a vCPUioctl(), arbitrary non-zero vCPU IDs, tests having to care about the vCPU ID in the first place, etc...The other theme in the rework is to deduplicate code and try to set us up for success in the future. E.g. provide macros/helpers instead of spamming CTRL-C => CTRL-V (see the -1k LoC), structure the VM creation APIs to build on one another, etc...
The absurd patch count (as opposed to just ridiculous) is due to converting each test away from using hardcoded vCPU IDs in a separate patch. The vast majority of those patches probably aren't worth reviewing in depth, the changes are mostly mechanical in nature.
However, _running_ non-x86 tests (or tests that have unique non-x86 behavior) would be extremely valuable. All patches have been compile tested on x86, arm, risc-v, and s390, but I've only run the tests on x86. Based on my track record for the x86+common tests, I will be very, very surprised if I didn't break any of the non-x86 tests, e.g. pthread_create()'s 'void *' param tripped me up multiple times.
I have not run x86's
amx_testdue to lack of hardware. I also haven't runsev_migration; something is wonky in either the upstream support forINIT_EXor in our test machines and I can't get SEV to initialize.v2:
- Drop the forced -Werror patch. [Vitaly]
- AddTEST_REQUIREto reduceKSFT_SKIPboilerplate.
- Rebase to kvm/queue, commit55371f1d0c01.
- Clean up even more bad copy+paste code (x86 was hiding a lot of crud).
- Assert that the input to anioctl()is (likely) the correct struct.v1: https://lore.kernel.org/all/[email protected]
Sean Christopherson (144):
KVM: Fix references to non-existentKVM_CAP_TRIPLE_FAULT_EVENT
KVM: selftests: Fix buggy-but-benign check in
test_v3_new_redist_regions()
KVM: selftests: Fix typo invgic_inittest
KVM: selftests: Drop stale declarations fromkvm_util_base.h
KVM: selftests: Always open VM file descriptors withO_RDWR
KVM: selftests: Add another underscore to innerioctl()helpers
KVM: selftests: Makevcpu_ioctl()a wrapper to pretty print ioctl name
KVM: selftests: Drop @mode from commonvm_create()helper
KVM: selftests: Splitvcpu_set_nested_state()into two helpers
KVM: sefltests: Usevcpu_ioctl()and__vcpu_ioctl()helpers
KVM: selftests: Add__vcpu_run()helper
KVM: selftests: Usevcpu_access_device_attr()in arm64 code
KVM: selftests: Removevcpu_get_fd()
KVM: selftests: Addvcpu_get()to retrieve and assert on vCPU
existence
KVM: selftests: Makevm_ioctl()a wrapper to pretty print ioctl name
KVM: sefltests: Usevm_ioctl()and__vm_ioctl()helpers
KVM: selftests: Makekvm_ioctl()a wrapper to pretty print ioctl name
KVM: selftests: Usekvm_ioctl()helpers
KVM: selftests: Use__KVM_SYSCALL_ERROR()to handle non-KVM syscall
errors
KVM: selftests: Make x86-64's register dump helpers static
KVM: selftests: Get rid ofkvm_util_internal.h
KVM: selftests: UseKVM_IOCTL_ERROR()for one-off arm64 ioctls
KVM: selftests: Drop @test param fromkvm_create_device()
KVM: selftests: MoveKVM_CREATE_DEVICE_TESTcode to separate helper
KVM: selftests: Multiplex return code and fd in__kvm_create_device()
KVM: selftests: RenameKVM_HAS_DEVICE_ATTRhelpers for consistency
KVM: selftests: Drop 'int' return from asserting*_has_device_attr()
KVM: selftests: Split get/setdevice_attrhelpers
KVM: selftests: Add a VM backpointer to 'struct vcpu'
KVM: selftests: ConsolidateKVM_ENABLE_CAPusage
KVM: selftests: SimplifyKVM_ENABLE_CAPhelper APIs
KVM: selftests: Cache list of MSRs to save/restore
KVM: selftests: Harden and comment XSS /KVM_SET_MSRSinteraction
KVM: selftests: Dedup MSR index list helpers, simplify dedicated test
KVM: selftests: RenameMP_STATEandGUEST_DEBUGhelpers for
consistency
KVM: selftest: Add proper helpers for x86-specific save/restore ioctls
KVM: selftests: Add vm_create_*() variants to expose/return 'struct
vcpu'
KVM: selftests: Pushvm_adjust_num_guest_pages()into "w/o vCPUs"
helper
KVM: selftests: Usevm_create_without_vcpus()inset_boot_cpu_id
KVM: selftests: Usevm_create_without_vcpus()indirty_log_test
KVM: selftests: Usevm_create_without_vcpus()inhardware_disable_test
KVM: selftests: Usevm_create_without_vcpus()inpsci_test
KVM: selftests: Renamevm_create()=>vm_create_barebones(), drop
param
KVM: selftests: Renamevm_create_without_vcpus()=>vm_create()
KVM: selftests: Makevm_create()a wrapper that specifies
VM_MODE_DEFAULT
KVM: selftests: Rename xAPIC state test's vcpu struct
KVM: selftests: Rename vcpu.state => vcpu.run
KVM: selftests: Rename 'struct vcpu' to 'structkvm_vcpu'
KVM: selftests: Return the created vCPU fromvm_vcpu_add()
KVM: selftests: Convertmemslot_perf_testaway fromVCPU_ID
KVM: selftests: Convertrseq_testaway fromVCPU_ID
KVM: selftests: Convertxss_msr_testaway fromVCPU_ID
KVM: selftests: Convertvmx_preemption_timer_testaway fromVCPU_ID
KVM: selftests: Convertvmx_pmu_msrs_testaway fromVCPU_ID
KVM: selftests: Convertvmx_set_nested_state_testaway fromVCPU_ID
KVM: selftests: Convertvmx_tsc_adjust_testaway fromVCPU_ID
KVM: selftests: Convertmmu_role_testaway fromVCPU_ID
KVM: selftests: Convertpmu_event_filter_testaway fromVCPU_ID
KVM: selftests: Convertsmm_testaway fromVCPU_ID
KVM: selftests: Convertstate_testaway fromVCPU_ID
KVM: selftests: Convertsvm_int_ctl_testaway fromVCPU_ID
KVM: selftests: Convertsvm_vmcall_testaway fromVCPU_ID
KVM: selftests: Convertsync_regs_testaway fromVCPU_ID
KVM: selftests: Converthyperv_cpuidaway fromVCPU_ID
KVM: selftests: Convertkvm_pv_testaway fromVCPU_ID
KVM: selftests: Convertplatform_info_testaway fromVCPU_ID
KVM: selftests: Convertvmx_nested_tsc_scaling_testaway fromVCPU_ID
KVM: selftests: Convertset_sregs_testaway fromVCPU_ID
KVM: selftests: Convertvmx_dirty_log_testaway fromVCPU_ID
KVM: selftests: Convertvmx_close_while_nested_testaway fromVCPU_ID
KVM: selftests: Convertvmx_apic_access_testaway fromVCPU_ID
KVM: selftests: Convertuserspace_msr_exit_testaway fromVCPU_ID
KVM: selftests: Convertvmx_exception_with_invalid_guest_stateaway
fromVCPU_ID
KVM: selftests: Converttsc_msrs_testaway fromVCPU_ID
KVM: selftests: Convertkvm_clock_testaway fromVCPU_ID
KVM: selftests: Converthyperv_svm_testaway fromVCPU_ID
KVM: selftests: Converthyperv_featuresaway fromVCPU_ID
KVM: selftests: Converthyperv_clockaway fromVCPU_ID
KVM: selftests: Convertevmcs_testaway fromVCPU_ID
KVM: selftests: Convertemulator_error_testaway fromVCPU_ID
KVM: selftests: Convertdebug_regsaway fromVCPU_ID
KVM: selftests: Add proper helper for advancing RIP indebug_regs
KVM: selftests: Convertamx_testaway fromVCPU_ID
KVM: selftests: Convertcr4_cpuid_sync_testaway fromVCPU_ID
KVM: selftests: Convertcpuid_testaway fromVCPU_ID
KVM: selftests: Convertuserspace_io_testaway fromVCPU_ID
KVM: selftests: Convertvmx_invalid_nested_guest_stateaway from
VCPU_ID
KVM: selftests: Convertxen_vmcall_testaway fromVCPU_ID
KVM: selftests: Convertxen_shinfo_testaway fromVCPU_ID
KVM: selftests: Convertdirty_log_testaway fromVCPU_ID
KVM: selftests: Convertset_memory_region_testaway fromVCPU_ID
KVM: selftests: Convertsystem_counter_offset_testaway fromVCPU_ID
KVM: selftests: Trackkvm_vcpuobject intsc_scaling_sync
KVM: selftests: Convertxapic_state_testaway from hardcoded vCPU ID
KVM: selftests: Convert debug-exceptions away fromVCPU_ID
KVM: selftests: Convertfix_hypercall_testaway fromVCPU_ID
KVM: selftests: Convertvgic_irqaway fromVCPU_ID
KVM: selftests: Make arm64'sguest_get_vcpuid()declaration arm64-only
KVM: selftests: Movevm_is_unrestricted_guest()to x86-64
KVM: selftests: Add "arch" to common utils that have arch
implementations
KVM: selftests: Return created vcpu fromvm_vcpu_add_default()
KVM: selftests: Rename vm_vcpu_add* helpers to better show
relationships
KVM: selftests: Convertset_boot_cpu_idaway from globalVCPU_IDs
KVM: selftests: Convertpsci_testaway fromVCPU_ID
KVM: selftests: Converthardware_disable_testto pass around vCPU
objects
KVM: selftests: Add VM creation helper that "returns" vCPUs
KVM: selftests: Convertsteal_timeaway fromVCPU_ID
KVM: selftests: Convertarch_timeraway fromVCPU_ID
KVM: selftests: Convertsvm_nested_soft_inject_testaway fromVCPU_ID
KVM: selftests: Converttriple_fault_event_testaway fromVCPU_ID
KVM: selftests: Convertvgic_initaway from
vm_create_default_with_vcpus()
KVM: selftests: Consolidate KVM_{G,S}ET_ONE_REG helpers
KVM: selftests: Sync stage before VM is freed in hypercalls test
KVM: selftests: Convert hypercalls test away fromvm_create_default()
KVM: selftests: Convertxapic_ipi_testaway from*_VCPU_ID
KVM: selftests: Convertsync_regs_testaway fromVCPU_ID
KVM: selftests: Convert s390's "resets" test away fromVCPU_ID
KVM: selftests: Convert memop away fromVCPU_ID
KVM: selftests: Convert s390x/diag318_test_handler away fromVCPU_ID
KVM: selftests: Convert tprot away fromVCPU_ID
KVM: selftests: Usevm_create()intsc_scaling_sync
KVM: selftests: Usevm_create_with_vcpus()inmax_guest_memory_test
KVM: selftests: Drop vm_create_default* helpers
KVM: selftests: Drop @vcpuids param from VM creators
KVM: selftests: Convertkvm_page_table_testaway from reliance on
vcpu_id
KVM: selftests: Convertkvm_binary_stats_testaway from vCPU IDs
KVM: selftests: Convert get-reg-list away from its "VCPU_ID"
KVM: selftests: Stop hardcoding vCPU IDs invcpu_width_config
KVM: selftests: Stop conflating vCPU index and ID in perf tests
KVM: selftests: Removevcpu_get()usage fromdirty_log_test
KVM: selftests: Require vCPU output array when creating VM with vCPUs
KVM: selftests: Purge vm+vcpu_id == vcpu silliness
KVM: selftests: Dropvcpu_get(), renamevcpu_find()=>vcpu_exists()
KVM: selftests: Removevcpu_state()helper
KVM: selftests: Open code and drop 'structkvm_vm' accessors
KVM: selftests: Drop @slot0_mem_pages from__vm_create_with_vcpus()
KVM: selftests: Drop @num_percpu_pages from__vm_create_with_vcpus()
KVM: selftests: Move per-VM/per-vCPU nr pages calculation to__vm_create()KVM: selftests: Trust that MAXPHYADDR > memslot0 in
vmx_apic_access_test
KVM: selftests: DropDEFAULT_GUEST_PHY_PAGES, open code the magic
number
KVM: selftests: Return an 'unsigned int' fromkvm_check_cap()
KVM: selftests: Addkvm_has_cap()to provide syntactic sugar
KVM: selftests: AddTEST_REQUIREmacros to reduce skipping copy+paste
KVM: selftests: Sanity check input toioctls()at build timeDocumentation/virt/kvm/api.rst | 4 +- .../selftests/kvm/aarch64/arch_timer.c | 79 +- .../selftests/kvm/aarch64/debug-exceptions.c | 22 +- .../selftests/kvm/aarch64/get-reg-list.c | 29 +- .../selftests/kvm/aarch64/hypercalls.c | 90 +- .../testing/selftests/kvm/aarch64/psci_test.c | 69 +- .../selftests/kvm/aarch64/vcpu_width_config.c | 71 +- .../testing/selftests/kvm/aarch64/vgic_init.c | 379 +++--- .../testing/selftests/kvm/aarch64/vgic_irq.c | 40 +- .../selftests/kvm/access_tracking_perf_test.c | 92 +- .../selftests/kvm/demand_paging_test.c | 49 +- .../selftests/kvm/dirty_log_perf_test.c | 51 +- tools/testing/selftests/kvm/dirty_log_test.c | 95 +- .../selftests/kvm/hardware_disable_test.c | 29 +- .../selftests/kvm/include/aarch64/processor.h | 28 +- .../selftests/kvm/include/aarch64/vgic.h | 6 +- .../selftests/kvm/include/kvm_util_base.h | 743 ++++++++--- .../selftests/kvm/include/perf_test_util.h | 5 +- .../selftests/kvm/include/riscv/processor.h | 20 - .../testing/selftests/kvm/include/test_util.h | 9 + .../selftests/kvm/include/ucall_common.h | 2 +- .../selftests/kvm/include/x86_64/evmcs.h | 2 +- .../selftests/kvm/include/x86_64/processor.h | 109 +- .../selftests/kvm/kvm_binary_stats_test.c | 31 +- .../selftests/kvm/kvm_create_max_vcpus.c | 10 +- .../selftests/kvm/kvm_page_table_test.c | 66 +- .../selftests/kvm/lib/aarch64/processor.c | 81 +- .../testing/selftests/kvm/lib/aarch64/ucall.c | 9 +- .../testing/selftests/kvm/lib/aarch64/vgic.c | 54 +- tools/testing/selftests/kvm/lib/elf.c | 1 - tools/testing/selftests/kvm/lib/guest_modes.c | 6 +- tools/testing/selftests/kvm/lib/kvm_util.c | 1104 +++-------------- .../selftests/kvm/lib/kvm_util_internal.h | 128 -- .../selftests/kvm/lib/perf_test_util.c | 84 +- .../selftests/kvm/lib/riscv/processor.c | 111 +- tools/testing/selftests/kvm/lib/riscv/ucall.c | 14 +- .../kvm/lib/s390x/diag318_test_handler.c | 11 +- .../selftests/kvm/lib/s390x/processor.c | 44 +- tools/testing/selftests/kvm/lib/s390x/ucall.c | 8 +- .../selftests/kvm/lib/x86_64/processor.c | 533 +++----- tools/testing/selftests/kvm/lib/x86_64/svm.c | 6 +- .../testing/selftests/kvm/lib/x86_64/ucall.c | 10 +- tools/testing/selftests/kvm/lib/x86_64/vmx.c | 16 +- .../selftests/kvm/max_guest_memory_test.c | 53 +- .../kvm/memslot_modification_stress_test.c | 13 +- .../testing/selftests/kvm/memslot_perf_test.c | 28 +- tools/testing/selftests/kvm/rseq_test.c | 22 +- tools/testing/selftests/kvm/s390x/memop.c | 93 +- tools/testing/selftests/kvm/s390x/resets.c | 140 ++- .../selftests/kvm/s390x/sync_regs_test.c | 45 +- tools/testing/selftests/kvm/s390x/tprot.c | 25 +- .../selftests/kvm/set_memory_region_test.c | 43 +- tools/testing/selftests/kvm/steal_time.c | 120 +- .../kvm/system_counter_offset_test.c | 35 +- tools/testing/selftests/kvm/x86_64/amx_test.c | 56 +- .../testing/selftests/kvm/x86_64/cpuid_test.c | 29 +- .../kvm/x86_64/cr4_cpuid_sync_test.c | 22 +- .../testing/selftests/kvm/x86_64/debug_regs.c | 77 +- .../kvm/x86_64/emulator_error_test.c | 74 +- .../testing/selftests/kvm/x86_64/evmcs_test.c | 61 +- .../selftests/kvm/x86_64/fix_hypercall_test.c | 45 +- .../kvm/x86_64/get_msr_index_features.c | 117 +- .../selftests/kvm/x86_64/hyperv_clock.c | 25 +- .../selftests/kvm/x86_64/hyperv_cpuid.c | 34 +- .../selftests/kvm/x86_64/hyperv_features.c | 61 +- .../selftests/kvm/x86_64/hyperv_svm_test.c | 20 +- .../selftests/kvm/x86_64/kvm_clock_test.c | 29 +- .../selftests/kvm/x86_64/kvm_pv_test.c | 33 +- .../kvm/x86_64/max_vcpuid_cap_test.c | 28 +- .../selftests/kvm/x86_64/mmio_warning_test.c | 16 +- .../selftests/kvm/x86_64/mmu_role_test.c | 30 +- .../selftests/kvm/x86_64/platform_info_test.c | 51 +- .../kvm/x86_64/pmu_event_filter_test.c | 97 +- .../selftests/kvm/x86_64/set_boot_cpu_id.c | 91 +- .../selftests/kvm/x86_64/set_sregs_test.c | 47 +- .../selftests/kvm/x86_64/sev_migrate_tests.c | 120 +- tools/testing/selftests/kvm/x86_64/smm_test.c | 37 +- .../testing/selftests/kvm/x86_64/state_test.c | 29 +- .../selftests/kvm/x86_64/svm_int_ctl_test.c | 21 +- .../kvm/x86_64/svm_nested_soft_inject_test.c | 17 +- .../selftests/kvm/x86_64/svm_vmcall_test.c | 16 +- .../selftests/kvm/x86_64/sync_regs_test.c | 62 +- .../kvm/x86_64/triple_fault_event_test.c | 39 +- .../selftests/kvm/x86_64/tsc_msrs_test.c | 35 +- .../selftests/kvm/x86_64/tsc_scaling_sync.c | 25 +- .../selftests/kvm/x86_64/userspace_io_test.c | 18 +- .../kvm/x86_64/userspace_msr_exit_test.c | 187 ++- .../kvm/x86_64/vmx_apic_access_test.c | 27 +- .../kvm/x86_64/vmx_close_while_nested_test.c | 17 +- .../selftests/kvm/x86_64/vmx_dirty_log_test.c | 13 +- .../vmx_exception_with_invalid_guest_state.c | 68 +- .../x86_64/vmx_invalid_nested_guest_state.c | 18 +- .../kvm/x86_64/vmx_nested_tsc_scaling_test.c | 29 +- .../selftests/kvm/x86_64/vmx_pmu_caps_test.c | 48 +- .../kvm/x86_64/vmx_preemption_timer_test.c | 35 +- .../kvm/x86_64/vmx_set_nested_state_test.c | 91 +- .../kvm/x86_64/vmx_tsc_adjust_test.c | 13 +- .../selftests/kvm/x86_64/xapic_ipi_test.c | 48 +- .../selftests/kvm/x86_64/xapic_state_test.c | 60 +- .../selftests/kvm/x86_64/xen_shinfo_test.c | 73 +- .../selftests/kvm/x86_64/xen_vmcall_test.c | 25 +- .../selftests/kvm/x86_64/xss_msr_test.c | 56 +- 102 files changed, 3059 insertions(+), 4178 deletions(-)delete mode 100644
tools/testing/selftests/kvm/lib/kvm_util_internal.hbase-commit:
55371f1d0c01357f29da613f7525c3f252320bbf
Sean Christopherson
reviewerQuoted 11 lines · Anup Patel
Quoted 6 lines · Anup Patel
Quoted 2 lines · Paolo Bonzini
Marc, Christian, Anup, can you please give this a go?
Sure, I will try this series.
I tried to apply this series on top of kvm/next and kvm/queue but I always get conflicts. It seems this series is dependent on other in-flight patches.
Hrm, that's odd, it's based directly on kvm/queue, commit 55371f1d0c01 ("KVM: ...).
Quoted 1 line
Is there a branch somewhere in a public repo ?
https://github.com/sean-jc/linux/tree/x86/selftests_overhaul
Sean Christopherson
reviewerQuoted 7 lines · Sean Christopherson
Quoted 6 lines · Anup Patel
Quoted 5 lines · Anup Patel
Quoted 2 lines · Paolo Bonzini
Marc, Christian, Anup, can you please give this a go?
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Sure, I will try this series.
I tried to apply this series on top of kvm/next and kvm/queue but I always get conflicts. It seems this series is dependent on other in-flight patches.
Hrm, that's odd, it's based directly on kvm/queue, commit
55371f1d0c01("KVM: ...).
Duh, Paolo updated kvm/queue. Where's Captain Obvious when you need him...
Quoted 3 lines
Quoted 1 line
Is there a branch somewhere in a public repo ?
https://github.com/sean-jc/linux/tree/x86/selftests_overhaul
I pushed a new version that's based on the current kvm/queue, commit 5e9402ac128b. arm and x86 look good (though I've yet to test on AMD).
Thomas,
If you get a chance, could you rerun the s390 tests? The recent refactorings to use TAP generated some fun conflicts.
Speaking of TAP, I added a patch to convert __TEST_REQUIRE to use ksft_exit_skip() instead of KVM's custom print_skip(). The s390 tests are being converted to use TAP output, I couldn't see any advantage of KVM's arbitrary "skipping test" over TAP-friendly output, and converting everything is far easier than special casing s390.
Sean Christopherson
reviewer+s390 folks...
Quoted 33 lines · Sean Christopherson
Quoted 7 lines · Sean Christopherson
Quoted 6 lines · Anup Patel
Quoted 5 lines · Anup Patel
Quoted 2 lines · Paolo Bonzini
Marc, Christian, Anup, can you please give this a go?
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Sure, I will try this series.
I tried to apply this series on top of kvm/next and kvm/queue but I always get conflicts. It seems this series is dependent on other in-flight patches.
Hrm, that's odd, it's based directly on kvm/queue, commit
55371f1d0c01("KVM: ...).Duh, Paolo updated kvm/queue. Where's Captain Obvious when you need him...
Quoted 3 lines
Quoted 1 line
Is there a branch somewhere in a public repo ?
https://github.com/sean-jc/linux/tree/x86/selftests_overhaul
I pushed a new version that's based on the current kvm/queue, commit
5e9402ac128b. arm and x86 look good (though I've yet to test on AMD).Thomas,
If you get a chance, could you rerun the s390 tests? The recent refactorings to use TAP generated some fun conflicts.Speaking of TAP, I added a patch to convert
__TEST_REQUIREto useksft_exit_skip()instead of KVM's customprint_skip(). The s390 tests are being converted to use TAP output, I couldn't see any advantage of KVM's arbitrary "skipping test" over TAP-friendly output, and converting everything is far easier than special casing s390.
Thomas Huth
Tested-byQuoted 31 lines · Sean Christopherson
+s390 folks...
Quoted 28 lines · Sean Christopherson
Quoted 7 lines · Sean Christopherson
Quoted 6 lines · Anup Patel
Quoted 5 lines · Anup Patel
Quoted 2 lines · Paolo Bonzini
Marc, Christian, Anup, can you please give this a go?
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Sure, I will try this series.
I tried to apply this series on top of kvm/next and kvm/queue but I always get conflicts. It seems this series is dependent on other in-flight patches.
Hrm, that's odd, it's based directly on kvm/queue, commit
55371f1d0c01("KVM: ...).Duh, Paolo updated kvm/queue. Where's Captain Obvious when you need him...
Quoted 3 lines
Quoted 1 line
Is there a branch somewhere in a public repo ?
https://github.com/sean-jc/linux/tree/x86/selftests_overhaul
I pushed a new version that's based on the current kvm/queue, commit
5e9402ac128b. arm and x86 look good (though I've yet to test on AMD).Thomas,
If you get a chance, could you rerun the s390 tests? The recent refactorings to use TAP generated some fun conflicts.
Still works fine!
Quoted 4 lines
Quoted 4 lines
Speaking of TAP, I added a patch to convert
__TEST_REQUIREto useksft_exit_skip()instead of KVM's customprint_skip(). The s390 tests are being converted to use TAP output, I couldn't see any advantage of KVM's arbitrary "skipping test" over TAP-friendly output, and converting everything is far easier than special casing s390.
Sounds like a good idea to me. I already considered starting to convert some x86 tests, too (https://lore.kernel.org/linux-kselftest/[email protected] ), but didn't get much feedback there yet, but anyway, we'll be better prepared with your change for that now.
Thomas
Quoted 17 lines · Sean Christopherson
Quoted 7 lines · Sean Christopherson
Quoted 6 lines · Anup Patel
Quoted 5 lines · Anup Patel
Quoted 2 lines · Paolo Bonzini
Marc, Christian, Anup, can you please give this a go?
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Sure, I will try this series.
I tried to apply this series on top of kvm/next and kvm/queue but I always get conflicts. It seems this series is dependent on other in-flight patches.
Hrm, that's odd, it's based directly on kvm/queue, commit
55371f1d0c01("KVM: ...).
Quoted 9 lines
Duh, Paolo updated kvm/queue. Where's Captain Obvious when you need him...
Quoted 3 lines
Quoted 1 line
Is there a branch somewhere in a public repo ?
https://github.com/sean-jc/linux/tree/x86/selftests_overhaul
I pushed a new version that's based on the current kvm/queue, commit
5e9402ac128b. arm and x86 look good (though I've yet to test on AMD).
I have tested this for KVM RISC-V and it works fine.
Regards,
Anup
Paolo Bonzini
maintainerQuoted 6 lines · Sean Christopherson
I pushed a new version that's based on the current kvm/queue, commit
5e9402ac128b. arm and x86 look good (though I've yet to test on AMD).Thomas,
If you get a chance, could you rerun the s390 tests? The recent refactorings to use TAP generated some fun conflicts.
I did so, rebased over David's nested dirty_log_perf_test patches and pushed to kvm/queue.
Paolo
Sean Christopherson
reviewerQuoted 10 lines · Paolo Bonzini
Quoted 6 lines · Sean Christopherson
I pushed a new version that's based on the current kvm/queue, commit
5e9402ac128b. arm and x86 look good (though I've yet to test on AMD).Thomas,
If you get a chance, could you rerun the s390 tests? The recent refactorings to use TAP generated some fun conflicts.I did so, rebased over David's nested
dirty_log_perf_testpatches and pushed to kvm/queue.
Wahoo! Thanks!
And a huge thanks to Drew for the reviews!
A message that is not in the archive (sent off-list or not yet received): [email protected]
Thomas Huth
Tested-byQuoted 29 lines · Sean Christopherson
Overhaul KVM's selftest APIs to get selftests to a state where adding new features and writing tests is less painful/disgusting.
Patches 1 fixes a goof in kvm/queue and should be squashed.
I would really, really, really like to get this queued up sooner than later, or maybe just thrown into a separate selftests-specific branch that folks can develop against. Rebasing is tedious, frustrating, and time consuming. And spoiler alert, there's another 42 x86-centric patches inbound that builds on this series to clean up CPUID related crud...
The primary theme is to stop treating tests like second class citizens. Stop hiding vcpu,
kvm_vm, etc... There's no sensitive data/constructs, and the encapsulation has led to really, really bad and difficult to maintain code. E.g. having to pass around the VM just to call a vCPUioctl(), arbitrary non-zero vCPU IDs, tests having to care about the vCPU ID in the first place, etc...The other theme in the rework is to deduplicate code and try to set us up for success in the future. E.g. provide macros/helpers instead of spamming CTRL-C => CTRL-V (see the -1k LoC), structure the VM creation APIs to build on one another, etc...
The absurd patch count (as opposed to just ridiculous) is due to converting each test away from using hardcoded vCPU IDs in a separate patch. The vast majority of those patches probably aren't worth reviewing in depth, the changes are mostly mechanical in nature.
Quoted 6 lines
However, _running_ non-x86 tests (or tests that have unique non-x86 behavior) would be extremely valuable. All patches have been compile tested on x86, arm, risc-v, and s390, but I've only run the tests on x86. Based on my track record for the x86+common tests, I will be very, very surprised if I didn't break any of the non-x86 tests, e.g. pthread_create()'s 'void *' param tripped me up multiple times.
Hi,
I just checked your series on s390x, and as far as I can see, the tests still work fine with the patches applied. Thus:
Quoted 39 lines · Sean Christopherson
Overhaul KVM's selftest APIs to get selftests to a state where adding new features and writing tests is less painful/disgusting.
Patches 1 fixes a goof in kvm/queue and should be squashed.
I would really, really, really like to get this queued up sooner than later, or maybe just thrown into a separate selftests-specific branch that folks can develop against. Rebasing is tedious, frustrating, and time consuming. And spoiler alert, there's another 42 x86-centric patches inbound that builds on this series to clean up CPUID related crud...
The primary theme is to stop treating tests like second class citizens. Stop hiding vcpu,
kvm_vm, etc... There's no sensitive data/constructs, and the encapsulation has led to really, really bad and difficult to maintain code. E.g. having to pass around the VM just to call a vCPUioctl(), arbitrary non-zero vCPU IDs, tests having to care about the vCPU ID in the first place, etc...The other theme in the rework is to deduplicate code and try to set us up for success in the future. E.g. provide macros/helpers instead of spamming CTRL-C => CTRL-V (see the -1k LoC), structure the VM creation APIs to build on one another, etc...
The absurd patch count (as opposed to just ridiculous) is due to converting each test away from using hardcoded vCPU IDs in a separate patch. The vast majority of those patches probably aren't worth reviewing in depth, the changes are mostly mechanical in nature.
However, _running_ non-x86 tests (or tests that have unique non-x86 behavior) would be extremely valuable. All patches have been compile tested on x86, arm, risc-v, and s390, but I've only run the tests on x86. Based on my track record for the x86+common tests, I will be very, very surprised if I didn't break any of the non-x86 tests, e.g. pthread_create()'s 'void *' param tripped me up multiple times.
I have not run x86's
amx_testdue to lack of hardware. I also haven't runsev_migration; something is wonky in either the upstream support forINIT_EXor in our test machines and I can't get SEV to initialize.
Quoted 9 lines
v2:
- Drop the forced -Werror patch. [Vitaly]
- AddTEST_REQUIREto reduceKSFT_SKIPboilerplate.
- Rebase to kvm/queue, commit55371f1d0c01.
- Clean up even more bad copy+paste code (x86 was hiding a lot of crud).
- Assert that the input to anioctl()is (likely) the correct struct.
Hi Sean,
I've completed a thorough skim / review and it looks great to me. Besides the final patch where I'm wondering about the loss of the type checking on our ioctl wrappers, I don't think there are any patches where I wouldn't be happy to add an r-b. So, for the series, except the last patch
Thanks,
drew