dmaengine: apple-admac: Fix print format
Subsystems (2)
Vinod Koul
maintainerPATCH 1/1 dmaengine: apple-admac: Fix print format
We get a warning (treated as error now)drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc':drivers/dma/apple-admac.c:209:26: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
209 | dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
Use %lx for priniting the flag
--- drivers/dma/apple-admac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/apple-admac.c +1 -1
@@ -206,7 +206,7 @@ static void admac_cyclic_write_one_desc(struct admac_data *ad, int channo,/* If happens means we have buggy code */ WARN_ON_ONCE (addr + tx->period_len > tx->buf_end); -dev_dbg (ad->dev,"ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n" , +dev_dbg (ad->dev,"ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%lx\n" , channo, &addr, tx->period_len,FLAG_DESC_NOTIFY );writel_relaxed (addr, ad->base +REG_DESC_WRITE (channo));
Signature · 1 line
2.34.3
Vinod Koul
maintainerQuoted 6 lines · Vinod Koul
We get a warning (treated as error now)
drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc':drivers/dma/apple-admac.c:209:26: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
209 | dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",Use %lx for priniting the flag
I have picked this one
Quoted 3 lines
Fixes b127315d9a78 ("dmaengine: apple-admac: Add Apple ADMAC driver")Reported-by Stephen Rothwell <[email protected]>
added bot as report too
Quoted 20 lines
Signed-off-by Vinod Koul <[email protected]>--- drivers/dma/apple-admac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/dma/apple-admac.c +1
-1@@ -206,7 +206,7 @@ static void admac_cyclic_write_one_desc(struct admac_data *ad, int channo,/* If happens means we have buggy code */ WARN_ON_ONCE (addr + tx->period_len > tx->buf_end); -dev_dbg (ad->dev,"ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n" , +dev_dbg (ad->dev,"ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%lx\n" , channo, &addr, tx->period_len,FLAG_DESC_NOTIFY );writel_relaxed (addr, ad->base +REG_DESC_WRITE (channo));Signature · 1 line
2.34.3
Signature · 1 line
~Vinod