Skip to contentSkip to conversation

char: lp: ensure that index has not exceeded LP_NO

PATCH In review Shreenidhi Shedi 2 participants 7 messages Jun 3, 2022 – Jun 27, 2022 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 char: lp: ensure that index has not exceeded LP_NO

From: Shreenidhi Shedi <[email protected]>

After finishing the loop, index value can be equal to LP_NO and lp_table array is of size LP_NO, so this can end up in accessing an out of bound address in lp_register function.

---
 drivers/char/lp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/lp.c +1 -1
index 0e22e3b0a..d474d02b6 100644
@@ -972,7 +972,7 @@ static void lp_attach(struct parport *port)
 			if (port_num[i] == -1)
 				break;
 
-		if (!lp_register(i, port))
+		if (i < LP_NO && !lp_register(i, port))
 			lp_count++;
 		break;
 

--
2.36.1

#1 lore raw

PATCH 2/2 char: lp: remove redundant initialization of err

From: Shreenidhi Shedi <[email protected]>

err is getting assigned with an appropriate value before returning, hence this initialization is unnecessary.

---
 drivers/char/lp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/lp.c +1 -1
index d474d02b6..536ceb111 100644
@@ -1019,7 +1019,7 @@ static struct parport_driver lp_driver = {
 
 static int __init lp_init(void)
 {
-	int i, err = 0;
+	int i, err;
 
 	if (parport_nr[0] == LP_PARPORT_OFF)
 		return 0;

--
2.36.1

maintainer
#2 lore raw
In reply to Shreenidhi Shedi
Quoted 16 lines · Shreenidhi Shedi

From: Shreenidhi Shedi <[email protected]>

After finishing the loop, index value can be equal to LP_NO and lp_table array is of size LP_NO, so this can end up in accessing an out of bound address in lp_register function.

---
 drivers/char/lp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/lp.c +0 -0
index 0e22e3b0a..d474d02b6 100644

drivers/char/lp.c static void lp_attach(struct parport *port) · line 976

Quoted 6 lines
drivers/char/lp.c +1 -1
@@ -972,7 +972,7 @@ static void lp_attach(struct parport *port)
 			if (port_num[i] == -1)
 				break;
 
-		if (!lp_register(i, port))
+		if (i < LP_NO && !lp_register(i, port))
 			lp_count++;

How can this ever be needed? Look at the check further up for the check of lp_count which prevents this from every going too large.

So how can an address be accessed out of bound here?

thanks,

greg k-h

#3 lore raw
Quoted 27 lines · Greg KH
Quoted 16 lines · Shreenidhi Shedi

From: Shreenidhi Shedi <[email protected]>

After finishing the loop, index value can be equal to LP_NO and lp_table array is of size LP_NO, so this can end up in accessing an out of bound address in lp_register function.

---
 drivers/char/lp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/lp.c +0 -0
index 0e22e3b0a..d474d02b6 100644

drivers/char/lp.c static void lp_attach(struct parport *port) · line 976

Quoted 6 lines
drivers/char/lp.c +1 -1
@@ -972,7 +972,7 @@ static void lp_attach(struct parport *port)
 			if (port_num[i] == -1)
 				break;
 
-		if (!lp_register(i, port))
+		if (i < LP_NO && !lp_register(i, port))
 			lp_count++;

How can this ever be needed? Look at the check further up for the check of lp_count which prevents this from every going too large.

Quoted 5 lines

So how can an address be accessed out of bound here?

thanks,

greg k-h

Thanks for the review. Assume lp_count is less than LP_NO now and we enter the for loop and for some reason for loop exits after i reaching the value LP_NO and right after that we call lp_register() with i and I can be equal to LP_NO.

Signature · 1 line
Shedi
maintainer
#4 lore raw
Quoted 28 lines · Shreenidhi Shedi
Quoted 27 lines · Greg KH
Quoted 16 lines · Shreenidhi Shedi

From: Shreenidhi Shedi <[email protected]>

After finishing the loop, index value can be equal to LP_NO and lp_table array is of size LP_NO, so this can end up in accessing an out of bound address in lp_register function.

---
 drivers/char/lp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/lp.c +0 -0
index 0e22e3b0a..d474d02b6 100644

drivers/char/lp.c static void lp_attach(struct parport *port) · line 976

Quoted 6 lines
drivers/char/lp.c +1 -1
@@ -972,7 +972,7 @@ static void lp_attach(struct parport *port)
 			if (port_num[i] == -1)
 				break;
 
-		if (!lp_register(i, port))
+		if (i < LP_NO && !lp_register(i, port))
 			lp_count++;

How can this ever be needed? Look at the check further up for the check of lp_count which prevents this from every going too large.

Quoted 8 lines
Quoted 5 lines

So how can an address be accessed out of bound here?

thanks,

greg k-h

Thanks for the review. Assume lp_count is less than LP_NO now and we enter the for loop and for some reason for loop exits after i reaching the value LP_NO

Wait, how can that happen? That's what I am saying, the loop will never reach that value from what I can tell.

Yes, this whole thing should be moved to something more sane like an idr structure, but as-is, it seems correct to me.

Have you tested the code with that many devices to see if it really can overflow?

thanks,

greg k-h

#5 lore raw
Quoted 44 lines · Greg KH
Quoted 28 lines · Shreenidhi Shedi
Quoted 27 lines · Greg KH
Quoted 16 lines · Shreenidhi Shedi

From: Shreenidhi Shedi <[email protected]>

After finishing the loop, index value can be equal to LP_NO and lp_table array is of size LP_NO, so this can end up in accessing an out of bound address in lp_register function.

---
 drivers/char/lp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/lp.c +0 -0
index 0e22e3b0a..d474d02b6 100644

drivers/char/lp.c static void lp_attach(struct parport *port) · line 976

Quoted 6 lines
drivers/char/lp.c +1 -1
@@ -972,7 +972,7 @@ static void lp_attach(struct parport *port)
 			if (port_num[i] == -1)
 				break;
 
-		if (!lp_register(i, port))
+		if (i < LP_NO && !lp_register(i, port))
 			lp_count++;

How can this ever be needed? Look at the check further up for the check of lp_count which prevents this from every going too large.

Quoted 8 lines
Quoted 5 lines

So how can an address be accessed out of bound here?

thanks,

greg k-h

Thanks for the review. Assume lp_count is less than LP_NO now and we enter the for loop and for some reason for loop exits after i reaching the value LP_NO

Wait, how can that happen? That's what I am saying, the loop will never reach that value from what I can tell.

Yes, this whole thing should be moved to something more sane like an idr structure, but as-is, it seems correct to me.

Quoted 6 lines

Have you tested the code with that many devices to see if it really can overflow?

thanks,

greg k-h

No, I did not actually test it with real hardware but I ran a static analyzer check on this file and it also thinks the same.

```
Checking drivers/char/lp.c ...
drivers/char/lp.c:926:10: error: inconclusive: Array 'lp_table[8]' accessed at index 8, which is out of bounds. [arrayIndexOutOfBounds]
 lp_table[nr].dev = parport_register_dev_model(port, "lp",
         ^
drivers/char/lp.c:971:17: note: Assuming that condition 'i<8' is not redundant
  for (i = 0; i < LP_NO; i++)
                ^
drivers/char/lp.c:975:20: note: Calling function 'lp_register', 1st argument 'i' value is 8
  if (!lp_register(i, port))
                   ^
drivers/char/lp.c:926:10: note: Array index out of bounds
 lp_table[nr].dev = parport_register_dev_model(port, "lp",
         ^
drivers/char/lp.c:928:14: error: inconclusive: Array 'lp_table[8]' accessed at index 8, which is out of bounds. [arrayIndexOutOfBounds]
 if (lp_table[nr].dev == NULL)
             ^
drivers/char/lp.c:971:17: note: Assuming that condition 'i<8' is not redundant
  for (i = 0; i < LP_NO; i++)
                ^
drivers/char/lp.c:975:20: note: Calling function 'lp_register', 1st argument 'i' value is 8
  if (!lp_register(i, port))
                   ^
drivers/char/lp.c:928:14: note: Array index out of bounds
 if (lp_table[nr].dev == NULL)
```
Signature · 1 line
Shedi
maintainer
#6 lore raw
Quoted 48 lines · Shreenidhi Shedi
Quoted 47 lines · Greg KH
Quoted 28 lines · Shreenidhi Shedi
Quoted 27 lines · Greg KH
Quoted 16 lines · Shreenidhi Shedi

From: Shreenidhi Shedi <[email protected]>

After finishing the loop, index value can be equal to LP_NO and lp_table array is of size LP_NO, so this can end up in accessing an out of bound address in lp_register function.

---
 drivers/char/lp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/lp.c +0 -0
index 0e22e3b0a..d474d02b6 100644

drivers/char/lp.c static void lp_attach(struct parport *port) · line 976

Quoted 6 lines
drivers/char/lp.c +1 -1
@@ -972,7 +972,7 @@ static void lp_attach(struct parport *port)
 			if (port_num[i] == -1)
 				break;
 
-		if (!lp_register(i, port))
+		if (i < LP_NO && !lp_register(i, port))
 			lp_count++;

How can this ever be needed? Look at the check further up for the check of lp_count which prevents this from every going too large.

Quoted 8 lines
Quoted 5 lines

So how can an address be accessed out of bound here?

thanks,

greg k-h

Thanks for the review. Assume lp_count is less than LP_NO now and we enter the for loop and for some reason for loop exits after i reaching the value LP_NO

Wait, how can that happen? That's what I am saying, the loop will never reach that value from what I can tell.

Yes, this whole thing should be moved to something more sane like an idr structure, but as-is, it seems correct to me.

Have you tested the code with that many devices to see if it really can overflow?

Quoted 6 lines
Quoted 3 lines

thanks,

greg k-h

No, I did not actually test it with real hardware but I ran a static analyzer check on this file and it also thinks the same.

Please try it on real hardware. static tools are not always the smartest thing out there.

good luck!

greg k-h