f2fs: refine comments for inline flags
PATCH 1/1 f2fs: refine comments for inline flags
From: Chao Liu <[email protected]>
Currently, we use f2fs_has_inline_xattr() to check whether the inode can store inline xattr. However, it might be misinterpreted as the inode has at least one inline xattr.
The same is true for f2fs_has_inline_data() and f2fs_has_inline_dentry(). To be more intuitive and specific, refine comments of inline flags.
--- fs/f2fs/f2fs.h | 6 +++--- include/linux/f2fs_fs.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
fs/f2fs/f2fs.h +3 -3
@@ -730,9 +730,9 @@ enum {FI_NO_ALLOC ,/* should not allocate any blocks */ FI_FREE_NID ,/* free allocated nide */ FI_NO_EXTENT ,/* not to use the extent cache */ -FI_INLINE_XATTR ,/* used for inline xattr */ -FI_INLINE_DATA ,/* used for inline data*/ -FI_INLINE_DENTRY ,/* used for inline dentry */ +FI_INLINE_XATTR ,/* inode can store inline xattr */ +FI_INLINE_DATA ,/* inode can store inline data */ +FI_INLINE_DENTRY ,/* inode can store inline dentry */ FI_APPEND_WRITE ,/* inode has appended data */ FI_UPDATE_WRITE ,/* inode has in-place-update data */ FI_NEED_IPU, /* used for ipu per file */
include/linux/f2fs_fs.h +3 -3
@@ -223,9 +223,9 @@ struct f2fs_extent {#define NODE_IND2_BLOCK (DEF_ADDRS_PER_INODE + 4)#define NODE_DIND_BLOCK (DEF_ADDRS_PER_INODE + 5) -#define F2FS_INLINE_XATTR 0x01/* file inline xattr flag */ -#define F2FS_INLINE_DATA 0x02/* file inline data flag */ -#define F2FS_INLINE_DENTRY 0x04/* file inline dentry flag */ +#define F2FS_INLINE_XATTR 0x01/* file can store inline xattr */ +#define F2FS_INLINE_DATA 0x02/* file can store inline data */ +#define F2FS_INLINE_DENTRY 0x04/* file can store inline dentry */ #define F2FS_DATA_EXIST 0x08/* file inline data exist flag */ #define F2FS_INLINE_DOTS 0x10/* file having implicit dot dentries */ #define F2FS_EXTRA_ATTR 0x20/* file having extra attribute */
Signature · 1 line
2.36.1
Quoted 11 lines · Chao Liu
From: Chao Liu <[email protected]>
Currently, we use
f2fs_has_inline_xattr()to check whether the inode can store inline xattr. However, it might be misinterpreted as the inode has at least one inline xattr.The same is true for
f2fs_has_inline_data()andf2fs_has_inline_dentry(). To be more intuitive and specific, refine comments of inline flags.Signed-off-by Chao Liu <[email protected]>
Thanks,
Jaegeuk Kim
maintainerQuoted 9 lines · Chao Liu
From: Chao Liu <[email protected]>
Currently, we use
f2fs_has_inline_xattr()to check whether the inode can store inline xattr. However, it might be misinterpreted as the inode has at least one inline xattr.The same is true for
f2fs_has_inline_data()andf2fs_has_inline_dentry(). To be more intuitive and specific, refine comments of inline flags.
I don't see a big benefit to get this patch, but will lose the history.
Quoted 43 lines
Signed-off-by Chao Liu <[email protected]>--- fs/f2fs/f2fs.h | 6 +++--- include/linux/f2fs_fs.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)fs/f2fs/f2fs.h +3
-3@@ -730,9 +730,9 @@ enum {FI_NO_ALLOC ,/* should not allocate any blocks */ FI_FREE_NID ,/* free allocated nide */ FI_NO_EXTENT ,/* not to use the extent cache */ -FI_INLINE_XATTR ,/* used for inline xattr */ -FI_INLINE_DATA ,/* used for inline data*/ -FI_INLINE_DENTRY ,/* used for inline dentry */ +FI_INLINE_XATTR ,/* inode can store inline xattr */ +FI_INLINE_DATA ,/* inode can store inline data */ +FI_INLINE_DENTRY ,/* inode can store inline dentry */ FI_APPEND_WRITE ,/* inode has appended data */ FI_UPDATE_WRITE ,/* inode has in-place-update data */ FI_NEED_IPU, /* used for ipu per file */include/linux/f2fs_fs.h +3
-3@@ -223,9 +223,9 @@ struct f2fs_extent {#define NODE_IND2_BLOCK (DEF_ADDRS_PER_INODE + 4)#define NODE_DIND_BLOCK (DEF_ADDRS_PER_INODE + 5) -#define F2FS_INLINE_XATTR 0x01/* file inline xattr flag */ -#define F2FS_INLINE_DATA 0x02/* file inline data flag */ -#define F2FS_INLINE_DENTRY 0x04/* file inline dentry flag */ +#define F2FS_INLINE_XATTR 0x01/* file can store inline xattr */ +#define F2FS_INLINE_DATA 0x02/* file can store inline data */ +#define F2FS_INLINE_DENTRY 0x04/* file can store inline dentry */ #define F2FS_DATA_EXIST 0x08/* file inline data exist flag */ #define F2FS_INLINE_DOTS 0x10/* file having implicit dot dentries */ #define F2FS_EXTRA_ATTR 0x20/* file having extra attribute */ Signature · 1 line
2.36.1
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel