serial: 8250_dw: Sort headers alphabetically
Subsystems (3)
Andy Shevchenko
reviewerPATCH 1/1 serial: 8250_dw: Sort headers alphabetically
For the sake of better maintenance, sort included headers alphabetically. While at it, split the serial group of headers which makes clear the subsystem the driver belongs to.
--- drivers/tty/serial/8250/8250_dw.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
drivers/tty/serial/8250/8250_dw.c +9 -8
@@ -9,26 +9,27 @@* LCR is written whilst busy. If it is, then a busy detect interrupt is * raised, the LCR needs to be rewritten and the uart status register read. */ +#include <linux/acpi.h> +#include <linux/clk.h> #include <linux/delay.h> #include <linux/device.h> #include <linux/io.h> #include <linux/mod_devicetable.h> #include <linux/module.h> -#include <linux/serial_8250.h> -#include <linux/serial_reg.h> +#include <linux/notifier.h> #include <linux/of.h> #include <linux/platform_device.h> +#include <linux/pm_runtime.h> #include <linux/property.h> -#include <linux/workqueue.h> -#include <linux/notifier.h> -#include <linux/slab.h> -#include <linux/acpi.h> -#include <linux/clk.h> #include <linux/reset.h> -#include <linux/pm_runtime.h> +#include <linux/slab.h> +#include <linux/workqueue.h> #include <asm/byteorder.h> +#include <linux/serial_8250.h> +#include <linux/serial_reg.h> +#include "8250_dwlib.h" /* Offsets for the DesignWare specific registers */
Signature · 1 line
2.35.1
Quoted 5 lines · Andy Shevchenko
For the sake of better maintenance, sort included headers alphabetically. While at it, split the serial group of headers which makes clear the subsystem the driver belongs to.
Signed-off-by Andy Shevchenko <[email protected]>
Signature · 1 line
i.
Greg Kroah-Hartman
maintainerQuoted 1 line · Andy Shevchenko
For the sake of better maintenance, sort included headers alphabetically.
How does that make anything easier to maintain?
Quoted 2 lines
While at it, split the serial group of headers which makes clear the subsystem the driver belongs to.
Where did you do that?
Quoted 32 lines
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/tty/serial/8250/8250_dw.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)drivers/tty/serial/8250/8250_dw.c +4
-6@@ -9,26 +9,27 @@* LCR is written whilst busy. If it is, then a busy detect interrupt is * raised, the LCR needs to be rewritten and the uart status register read. */ +#include <linux/acpi.h> +#include <linux/clk.h> #include <linux/delay.h> #include <linux/device.h> #include <linux/io.h> #include <linux/mod_devicetable.h> #include <linux/module.h> -#include <linux/serial_8250.h> -#include <linux/serial_reg.h> +#include <linux/notifier.h> #include <linux/of.h> #include <linux/platform_device.h> +#include <linux/pm_runtime.h> #include <linux/property.h> -#include <linux/workqueue.h> -#include <linux/notifier.h> -#include <linux/slab.h> -#include <linux/acpi.h>
drivers/tty/serial/8250/8250_dw.c line 31
Quoted 10 lines
drivers/tty/serial/8250/8250_dw.c +4
-2-#include <linux/clk.h> #include <linux/reset.h> -#include <linux/pm_runtime.h> +#include <linux/slab.h> +#include <linux/workqueue.h> #include <asm/byteorder.h> +#include <linux/serial_8250.h> +#include <linux/serial_reg.h>
Is this the "split"?
Anyway, it's just code churn, I'll apply it...
thanks,
greg k-h