nfs: Replace kmap() with kmap_local_page()
Subsystems (2)
PATCH 1/1 nfs: Replace kmap() with kmap_local_page()
The use of kmap() is being deprecated in favor of kmap_local_page().
With kmap_local_page(), the mapping is per thread, CPU local and not globally visible. Furthermore, the mapping can be acquired from any context (including interrupts).
Therefore, use kmap_local_page() in nfs_do_filldir() because this mapping is per thread, CPU local, and not globally visible.
---
I cannot test this patch for several reasons. While these changes seem safe and trivial, I would feel better if people familiar with NFS could take the time to properly test this patch. Thank you.
fs/nfs/dir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/nfs/dir.c +2 -2
@@ -1084,7 +1084,7 @@ static void nfs_do_filldir(struct nfs_readdir_descriptor *desc,struct nfs_cache_array *array;unsigned int i; - array =kmap (desc->page); + array =kmap_local_page (desc->page);for (i = desc->cache_entry_index; i < array->size; i++) {struct nfs_cache_array_entry *ent;
@@ -1110,7 +1110,7 @@ static void nfs_do_filldir(struct nfs_readdir_descriptor *desc,if (array->page_is_eof) desc->eof = !desc->eob; -kunmap (desc->page); +kunmap_local (array);dfprintk (DIRCACHE ,"NFS: nfs_do_filldir() filling ended @ cookie %llu\n" , (unsigned long long )desc->dir_cookie); }
Signature · 1 line
2.36.1
Quoted 10 lines · Fabio M. De Francesco
The use of
kmap()is being deprecated in favor ofkmap_local_page().With
kmap_local_page(), the mapping is per thread, CPU local and not globally visible. Furthermore, the mapping can be acquired from any context (including interrupts).Therefore, use
kmap_local_page()innfs_do_filldir()because this mapping is per thread, CPU local, and not globally visible.Suggested-by Ira Weiny <[email protected]>
Quoted 35 lines
Signed-off-by Fabio M. De Francesco <[email protected]>---
I cannot test this patch for several reasons. While these changes seem safe and trivial, I would feel better if people familiar with NFS could take the time to properly test this patch. Thank you.
fs/nfs/dir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/nfs/dir.c +2
-2@@ -1084,7 +1084,7 @@ static void nfs_do_filldir(struct nfs_readdir_descriptor *desc,struct nfs_cache_array *array;unsigned int i; - array =kmap (desc->page); + array =kmap_local_page (desc->page);for (i = desc->cache_entry_index; i < array->size; i++) {struct nfs_cache_array_entry *ent;@@ -1110,7 +1110,7 @@ static void nfs_do_filldir(struct nfs_readdir_descriptor *desc,if (array->page_is_eof) desc->eof = !desc->eob; -kunmap (desc->page); +kunmap_local (array);dfprintk (DIRCACHE ,"NFS: nfs_do_filldir() filling ended @ cookie %llu\n" , (unsigned long long )desc->dir_cookie); }Signature · 1 line
2.36.1