Skip to contentSkip to conversation

uapi: Make __{u,s}64 match {u,}int64_t in userspace

PATCH In review Cyril Hrubis 4 participants 5 messages Jun 21, 2022 – Jun 23, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 uapi: Make __{u,s}64 match {u,}int64_t in userspace

This changes the __u64 and __s64 in userspace on 64bit platforms from long long (unsigned) int to just long (unsigned) int in order to match the uint64_t and int64_t size in userspace for C code.

We cannot make the change for C++ since that would be non-backwards compatible change and may cause possible regressions and even compilation failures, e.g. overloaded function may no longer find a correct match.

This allows us to use the kernel structure definitions in userspace in C code. For example we can use PRIu64 and PRId64 modifiers in printf() to print structure membere. Morever with this there would be no need to redefine these structures in an libc implementations as it is done now.

Consider for example the newly added statx() syscall. If we use the header from uapi we will get warnings when attempting to print it's members as:

	printf("%" PRIu64 "\n", stx.stx_size);

We get:

	warning: format '%lu' expects argument of type 'long unsigned int',
	         but argument 5 has type '__u64' {aka 'long long unsigned int'}
---
 include/uapi/asm-generic/types.h | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

v2: Make sure we do not break C++ applications
v3: Update commit message to explain C++ exclusion

include/uapi/asm-generic/types.h +9 -2
index dfaa50d99d8f..11e468a39d1e 100644
@@ -1,9 +1,16 @@
 /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
 #ifndef _ASM_GENERIC_TYPES_H
 #define _ASM_GENERIC_TYPES_H
+
+#include <asm/bitsperlong.h>
+
 /*
- * int-ll64 is used everywhere now.
+ * int-ll64 is used everywhere in kernel now.
  */
-#include <asm-generic/int-ll64.h>
+#if !defined(__KERNEL__) && !defined(__cplusplus) && __BITSPERLONG == 64
+# include <asm-generic/int-l64.h>
+#else
+# include <asm-generic/int-ll64.h>
+#endif
 
 #endif /* _ASM_GENERIC_TYPES_H */
Signature · 1 line
2.35.1
Acked-by on v3 1/1
#1 lore raw
Quoted 18 lines · Cyril Hrubis

This changes the __u64 and __s64 in userspace on 64bit platforms from long long (unsigned) int to just long (unsigned) int in order to match the uint64_t and int64_t size in userspace for C code.

We cannot make the change for C++ since that would be non-backwards compatible change and may cause possible regressions and even compilation failures, e.g. overloaded function may no longer find a correct match.

This allows us to use the kernel structure definitions in userspace in C code. For example we can use PRIu64 and PRId64 modifiers in printf() to print structure membere. Morever with this there would be no need to redefine these structures in an libc implementations as it is done now.

Consider for example the newly added statx() syscall. If we use the header from uapi we will get warnings when attempting to print it's members as:

Quoted 8 lines
	printf("%" PRIu64 "\n", stx.stx_size);

We get:

	warning: format '%lu' expects argument of type 'long unsigned int',
	         but argument 5 has type '__u64' {aka 'long long unsigned int'}
Quoted 9 lines
---
  include/uapi/asm-generic/types.h | 11 +++++++++--
  1 file changed, 9 insertions(+), 2 deletions(-)

v2: Make sure we do not break C++ applications
v3: Update commit message to explain C++ exclusion

include/uapi/asm-generic/types.h +0 -0
index dfaa50d99d8f..11e468a39d1e 100644
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw
In reply to Cyril Hrubis

From: Cyril Hrubis

Quoted 10 lines

Sent: 21 June 2022 13:04

This changes the __u64 and __s64 in userspace on 64bit platforms from long long (unsigned) int to just long (unsigned) int in order to match the uint64_t and int64_t size in userspace for C code.

We cannot make the change for C++ since that would be non-backwards compatible change and may cause possible regressions and even compilation failures, e.g. overloaded function may no longer find a correct match.

Isn't is enough just to mention C++ name mangling?

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

#3 lore raw

Hi!

Quoted 10 lines
Quoted 8 lines

This changes the __u64 and __s64 in userspace on 64bit platforms from long long (unsigned) int to just long (unsigned) int in order to match the uint64_t and int64_t size in userspace for C code.

We cannot make the change for C++ since that would be non-backwards compatible change and may cause possible regressions and even compilation failures, e.g. overloaded function may no longer find a correct match.

Isn't is enough just to mention C++ name mangling?

I just picked up the argument that was brought up in the discussion about the v1 patch and used it as a concrete example. Mangling is I guess more straightforward example of a breakage. I can change the description if there is consensus that such description would be better.

Signature · 2 lines
Cyril Hrubis
[email protected]
maintainer
#4 lore raw
In reply to Cyril Hrubis
Quoted 19 lines · Cyril Hrubis

This changes the __u64 and __s64 in userspace on 64bit platforms from long long (unsigned) int to just long (unsigned) int in order to match the uint64_t and int64_t size in userspace for C code.

We cannot make the change for C++ since that would be non-backwards compatible change and may cause possible regressions and even compilation failures, e.g. overloaded function may no longer find a correct match.

This allows us to use the kernel structure definitions in userspace in C code. For example we can use PRIu64 and PRId64 modifiers in printf() to print structure membere. Morever with this there would be no need to redefine these structures in an libc implementations as it is done now.

Consider for example the newly added statx() syscall. If we use the header from uapi we will get warnings when attempting to print it's members as:

Quoted 8 lines
        printf("%" PRIu64 "\n", stx.stx_size);

We get:

warning: format '%lu' expects argument of type 'long unsigned int',
but argument 5 has type '__u64' {aka 'long long unsigned int'}

I understand the problem you are solving here, but I'm not convinced that this is actually an overall improvement as you introduce two similar problems in its place:

- any application that has previously used the correct %ll or %ull format strings for members of kernel data structures now gains a new warning

- After your patch, neither the PRIu64 nor the "%ull" format strings are portable across old and new kernel headers, so applications are now forced to add an explicit cast to 'unsigned long long' or 'uint64_t' to every print statement for these members if they want to guarantee a clean build.

Do you have an estimate of how many build time warnings in common packages actually get fixed by your patch, compared to the number of warnings that get introduced?

Arnd

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp