mfd: dln2: Automatically detect and fill endpoint pointers
PATCH 1/1 mfd: dln2: Automatically detect and fill endpoint pointers
The usb_find_common_endpoints() finds and fills the endpoints in accordance with their types. Use it to automatically detect and fill endpoint pointers.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/mfd/dln2.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-)
drivers/mfd/dln2.c +4 -13
@@ -91,11 +91,6 @@ struct dln2_mod_rx_slots {spinlock_t lock; }; -enum dln2_endpoint { -DLN2_EP_OUT =0 , -DLN2_EP_IN =1 , -}; -struct dln2_dev {struct usb_device *usb_dev;struct usb_interface *interface;
@@ -777,16 +772,12 @@ static int dln2_probe(struct usb_interface *interface,int ret;int i, j; -if (hostif->desc.bInterfaceNumber !=0 || - hostif->desc.bNumEndpoints <2 ) +if (hostif->desc.bInterfaceNumber !=0 )return -ENODEV ; - epout = &hostif->endpoint[DLN2_EP_OUT ].desc; -if (!usb_endpoint_is_bulk_out (epout)) -return -ENODEV ; - epin = &hostif->endpoint[DLN2_EP_IN ].desc; -if (!usb_endpoint_is_bulk_in (epin)) -return -ENODEV ; + ret =usb_find_common_endpoints (hostif, &epin, &epout,NULL ,NULL ); +if (ret) +return ret; dln2 =kzalloc (sizeof (*dln2),GFP_KERNEL );if (!dln2)
Signature · 1 line
2.35.1
Lee Jones
AppliedQuoted 8 lines · Andy Shevchenko
The
usb_find_common_endpoints()finds and fills the endpoints in accordance with their types. Use it to automatically detect and fill endpoint pointers.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/mfd/dln2.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog