Skip to contentSkip to conversation

btf: Fix required space error

PATCH In review Jules Irenge 2 participants 3 messages Jun 29, 2022 – Jul 1, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 btf: Fix required space error

This patch fixes error reported ny Checkpatch at bpf_log()

ERROR: space required after that , ctx:VxV

---
 kernel/bpf/btf.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
kernel/bpf/btf.c +3 -1
index 2e2066d6af94..1bc496162572 100644
@@ -5454,7 +5454,9 @@ bool btf_ctx_access(int off, int size, enum bpf_access_type type,
 
 		if (ctx_arg_info->offset == off) {
 			if (!ctx_arg_info->btf_id) {
-				bpf_log(log,"invalid btf_id for context argument offset %u\n", off);
+				bpf_log(log,
+					"invalid btf_id for context argument offset %u\n",
+					off);
 				return false;
 			}
 
Signature · 1 line
2.36.1
#1 lore raw
Quoted 2 lines · Jules Irenge

This patch fixes error reported ny Checkpatch at bpf_log()

Please do not send patches suggested by checkpatch. checkpatch is not an authoritative tool. It's merely suggesting things.

#2 lore raw
Quoted 7 lines · Alexei Starovoitov
Quoted 2 lines · Jules Irenge

This patch fixes error reported ny Checkpatch at bpf_log()

Please do not send patches suggested by checkpatch. checkpatch is not an authoritative tool. It's merely suggesting things.

Thanks, I take good note. I will try with better tools with less false positive.