Skip to contentSkip to conversation

xhci-pci: Enable runtime PM on Alder Lake-N PCH xHCI controller

PATCH In review Ben Kao 2 participants 4 messages Jul 12, 2022 – Jul 14, 2022

Subsystems (2)
lore
Share & tools
lore

Ben Kao

author
#0 lore raw

PATCH 1/1 xhci-pci: Enable runtime PM on Alder Lake-N PCH xHCI controller

There are two Alder Lake-N xHCI host controllers with PCI IDs 0x464e and 0x54ed, now we add the quirk to default enable runtime PM for 0x54ed.

---
 drivers/usb/host/xhci-pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/host/xhci-pci.c +2 -0
index dce6c0ec8d34..44486156bd5d 100644
@@ -61,6 +61,7 @@
 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_XHCI		0x461e
 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_XHCI		0x464e
 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI	0x51ed
+#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI	0x54ed
 #define PCI_DEVICE_ID_INTEL_RAPTOR_LAKE_XHCI		0xa71e
 #define PCI_DEVICE_ID_INTEL_METEOR_LAKE_XHCI		0x7ec0
 
@@ -272,6 +273,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 	     pdev->device == PCI_DEVICE_ID_INTEL_ALDER_LAKE_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI ||
+	     pdev->device == PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_RAPTOR_LAKE_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_METEOR_LAKE_XHCI))
 		xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 14 lines · Ben Kao

There are two Alder Lake-N xHCI host controllers with PCI IDs 0x464e and 0x54ed, now we add the quirk to default enable runtime PM for 0x54ed.

---
 drivers/usb/host/xhci-pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/host/xhci-pci.c +0 -0
index dce6c0ec8d34..44486156bd5d 100644

drivers/usb/host/xhci-pci.c line 64

Quoted 4 lines
drivers/usb/host/xhci-pci.c +1 -0
@@ -61,6 +61,7 @@
 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_XHCI		0x461e
 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_XHCI		0x464e
 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI	0x51ed
+#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI	0x54ed

I think we ask this every time, but why don't we enable this for all devices and then only disable it for the tiny number that don't need it?

Why do you all force us to add this for every new device created?

thanks,

greg k-h

author
#2 lore raw
Quoted 27 lines

From: Greg KH <[email protected]>
Sent: Tuesday, July 12, 2022 8:45 PM
To: Kao, Ben <[email protected]>
Cc: Nyman, Mathias <[email protected]>; [email protected]; [email protected]; linux- [email protected]
Subject: Re: [PATCH] xhci-pci: Enable runtime PM on Alder Lake-N PCH xHCI controller

Quoted 14 lines · Ben Kao

There are two Alder Lake-N xHCI host controllers with PCI IDs 0x464e and 0x54ed, now we add the quirk to default enable runtime PM for 0x54ed.

---
 drivers/usb/host/xhci-pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/host/xhci-pci.c +0 -0
index dce6c0ec8d34..44486156bd5d 100644

drivers/usb/host/xhci-pci.c line 62

Quoted 2 lines
drivers/usb/host/xhci-pci.c +0 -0
@@ -61,6 +61,7 @@
 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_XHCI		0x461e
 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_XHCI
	0x464e
Quoted 5 lines

drivers/usb/host/xhci-pci.c line 64

Quoted 2 lines
drivers/usb/host/xhci-pci.c +1 -0
 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI	0x51ed
+#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI	0x54ed

I think we ask this every time, but why don't we enable this for all devices and then only disable it for the tiny number that don't need it?

Got it, I will provide another patch to enable runtime PM by default for all Intel devices if no one has concerns.

Quoted 6 lines

Why do you all force us to add this for every new device created?

thanks,

greg k-h

maintainer
#3 lore raw
Quoted 27 lines · Ben
Quoted 27 lines

From: Greg KH <[email protected]>
Sent: Tuesday, July 12, 2022 8:45 PM
To: Kao, Ben <[email protected]>
Cc: Nyman, Mathias <[email protected]>; [email protected]; [email protected]; linux- [email protected]
Subject: Re: [PATCH] xhci-pci: Enable runtime PM on Alder Lake-N PCH xHCI controller

Quoted 14 lines · Ben Kao

There are two Alder Lake-N xHCI host controllers with PCI IDs 0x464e and 0x54ed, now we add the quirk to default enable runtime PM for 0x54ed.

---
 drivers/usb/host/xhci-pci.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/host/xhci-pci.c +0 -0
index dce6c0ec8d34..44486156bd5d 100644

drivers/usb/host/xhci-pci.c line 62

Quoted 2 lines
drivers/usb/host/xhci-pci.c +0 -0
@@ -61,6 +61,7 @@
 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_XHCI		0x461e
 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_XHCI
	0x464e
Quoted 7 lines
Quoted 5 lines

drivers/usb/host/xhci-pci.c line 64

Quoted 2 lines
drivers/usb/host/xhci-pci.c +1 -0
 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI	0x51ed
+#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI	0x54ed

I think we ask this every time, but why don't we enable this for all devices and then only disable it for the tiny number that don't need it?

Got it, I will provide another patch to enable runtime PM by default for all Intel devices if no one has concerns.

Please test to verify that it works on the systems you enable it for and verify that future devices will also work properly.

thanks,

greg k-h