ovpn-dco: introduce data-channel offload support
Re: [Openvpn-devel] [PATCH 25/25] dco-win: update GH Actions config file
In reply to Antonio QuartulliI think this commit could use an additional sentence in the commit message on why exactly you remove this?
Doesn't immediately make sense to me.
Quoted 23 lines · Antonio Quartulli
Signed-off-by Lev Stipakov <[email protected]...>Signed-off-by Antonio Quartulli <[email protected]...>--- .github/workflows/build.yaml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-).github/workflows/build.yaml +0
-5@@ -59,11 +59,6 @@ jobs: steps: - name: Install dependencies run: sudo apt update && sudo apt install -y mingw-w64 libtool automake autoconf man2html unzip - - name: Checkout ovpn-dco-win - uses: actions/[email protected]... - with: - repository: OpenVPN/ovpn-dco-win - path: ovpn-dco-win - name: Checkout OpenVPN uses: actions/[email protected]... with:
.github/workflows/build.yaml jobs: · line 152
Quoted 8 lines
.github/workflows/build.yaml +1
-1@@ -151,7 +146,7 @@ jobs: run: cp ./tap-windows-${TAP_WINDOWS_VERSION}/include/tap-windows.h ${HOME}/mingw/opt/include/ - name: configure OpenVPN - run: PKG_CONFIG_PATH=${HOME}/mingw/opt/lib/pkgconfig DCO_SOURCEDIR=$(realpath ../ovpn-dco-win) LDFLAGS=-L$HOME/mingw/opt/lib CFLAGS=-I$HOME/mingw/opt/include OPENSSL_LIBS="-L${HOME}/opt/lib -lssl -lcrypto" OPENSSL_CFLAGS=-I$HOME/mingw/opt/include PREFIX=$HOME/mingw/opt LZO_CFLAGS=-I$HOME/mingw/opt/include LZO_LIBS="-L${HOME}/mingw/opt/lib -llzo2" ./configure --host=${CHOST} --disable-lz4 --enable-dco + run: PKG_CONFIG_PATH=${HOME}/mingw/opt/lib/pkgconfig LDFLAGS=-L$HOME/mingw/opt/lib CFLAGS=-I$HOME/mingw/opt/include OPENSSL_LIBS="-L${HOME}/opt/lib -lssl -lcrypto" OPENSSL_CFLAGS=-I$HOME/mingw/opt/include PREFIX=$HOME/mingw/opt LZO_CFLAGS=-I$HOME/mingw/opt/include LZO_LIBS="-L${HOME}/mingw/opt/lib -llzo2" ./configure --host=${CHOST} --disable-lz4 working-directory: openvpn - name: build OpenVPN
Regards,
Signature · 1 line
Frank Lichtenheld
Re: [Openvpn-devel] [PATCH 25/25] dco-win: update GH Actions config file
Hi,
Quoted 4 lines · Frank Lichtenheld
I think this commit could use an additional sentence in the commit message on why exactly you remove this?
Doesn't immediately make sense to me.
To be honest, I am not even sure why we have a build with DCO in the first place. There is no DCO code yet in master but somehow we have the GH action for that :-D
Anyway, can add a sentence to explain what is going on.
Cheers,
Quoted 35 lines · Antonio Quartulli
Quoted 23 lines
Signed-off-by Lev Stipakov <[email protected]...>Signed-off-by Antonio Quartulli <[email protected]...>--- .github/workflows/build.yaml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-).github/workflows/build.yaml +0
-5@@ -59,11 +59,6 @@ jobs: steps: - name: Install dependencies run: sudo apt update && sudo apt install -y mingw-w64 libtool automake autoconf man2html unzip - - name: Checkout ovpn-dco-win - uses: actions/[email protected]... - with: - repository: OpenVPN/ovpn-dco-win - path: ovpn-dco-win - name: Checkout OpenVPN uses: actions/[email protected]... with:.github/workflows/build.yaml jobs: · line 152
Quoted 8 lines
.github/workflows/build.yaml +1
-1@@ -151,7 +146,7 @@ jobs: run: cp ./tap-windows-${TAP_WINDOWS_VERSION}/include/tap-windows.h ${HOME}/mingw/opt/include/ - name: configure OpenVPN - run: PKG_CONFIG_PATH=${HOME}/mingw/opt/lib/pkgconfig DCO_SOURCEDIR=$(realpath ../ovpn-dco-win) LDFLAGS=-L$HOME/mingw/opt/lib CFLAGS=-I$HOME/mingw/opt/include OPENSSL_LIBS="-L${HOME}/opt/lib -lssl -lcrypto" OPENSSL_CFLAGS=-I$HOME/mingw/opt/include PREFIX=$HOME/mingw/opt LZO_CFLAGS=-I$HOME/mingw/opt/include LZO_LIBS="-L${HOME}/mingw/opt/lib -llzo2" ./configure --host=${CHOST} --disable-lz4 --enable-dco + run: PKG_CONFIG_PATH=${HOME}/mingw/opt/lib/pkgconfig LDFLAGS=-L$HOME/mingw/opt/lib CFLAGS=-I$HOME/mingw/opt/include OPENSSL_LIBS="-L${HOME}/opt/lib -lssl -lcrypto" OPENSSL_CFLAGS=-I$HOME/mingw/opt/include PREFIX=$HOME/mingw/opt LZO_CFLAGS=-I$HOME/mingw/opt/include LZO_LIBS="-L${HOME}/mingw/opt/lib -llzo2" ./configure --host=${CHOST} --disable-lz4 working-directory: openvpn - name: build OpenVPNRegards,
Signature · 1 line
Antonio Quartulli
Re: [Openvpn-devel] [PATCH 25/25] dco-win: update GH Actions config file
We have moved dco-win uapi header to openvpn repo, so we don't have to checkout ovpn-dco-win repo to get it - this is what this commit does. But yeah, good point on having dco builds without dco.
ti 5. heinäk. 2022 klo 12.36 Antonio Quartulli ([email protected]...) kirjoitti:
Quoted 61 lines
Hi,
Quoted 4 lines · Frank Lichtenheld
I think this commit could use an additional sentence in the commit message on why exactly you remove this?
Doesn't immediately make sense to me.
To be honest, I am not even sure why we have a build with DCO in the first place. There is no DCO code yet in master but somehow we have the GH action for that :-D
Anyway, can add a sentence to explain what is going on.
Cheers,
Quoted 27 lines · Antonio Quartulli
Quoted 25 lines
Signed-off-by Lev Stipakov <[email protected]...>Signed-off-by Antonio Quartulli <[email protected]...>--- .github/workflows/build.yaml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-).github/workflows/build.yaml +0
-5@@ -59,11 +59,6 @@ jobs: steps: - name: Install dependencies run: sudo apt update && sudo apt install -y mingw-w64 libtool automake autoconf man2html unzip - - name: Checkout ovpn-dco-win - uses: actions/[email protected]... - with: - repository: OpenVPN/ovpn-dco-win - path: ovpn-dco-win - name: Checkout OpenVPN uses: actions/[email protected]... with:@@ -151,7 +146,7 @@ jobs: run: cp ./tap-windows-${TAP_WINDOWS_VERSION}/include/tap-windows.h ${HOME}/mingw/opt/include/Quoted 8 lines
.github/workflows/build.yaml jobs: · line 152
Quoted 6 lines
.github/workflows/build.yaml +1
-1- name: configure OpenVPN - run: PKG_CONFIG_PATH=${HOME}/mingw/opt/lib/pkgconfig DCO_SOURCEDIR=$(realpath ../ovpn-dco-win) LDFLAGS=-L$HOME/mingw/opt/lib CFLAGS=-I$HOME/mingw/opt/include OPENSSL_LIBS="-L${HOME}/opt/lib -lssl -lcrypto" OPENSSL_CFLAGS=-I$HOME/mingw/opt/include PREFIX=$HOME/mingw/opt LZO_CFLAGS=-I$HOME/mingw/opt/include LZO_LIBS="-L${HOME}/mingw/opt/lib -llzo2" ./configure --host=${CHOST} --disable-lz4 --enable-dco + run: PKG_CONFIG_PATH=${HOME}/mingw/opt/lib/pkgconfig LDFLAGS=-L$HOME/mingw/opt/lib CFLAGS=-I$HOME/mingw/opt/include OPENSSL_LIBS="-L${HOME}/opt/lib -lssl -lcrypto" OPENSSL_CFLAGS=-I$HOME/mingw/opt/include PREFIX=$HOME/mingw/opt LZO_CFLAGS=-I$HOME/mingw/opt/include LZO_LIBS="-L${HOME}/mingw/opt/lib -llzo2" ./configure --host=${CHOST} --disable-lz4 working-directory: openvpn - name: build OpenVPNRegards,
--
Antonio Quartulli_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Signature · 1 line
-Lev
Re: [Openvpn-devel] [PATCH 25/25] dco-win: update GH Actions config file
In reply to Antonio QuartulliHi,
Quoted 9 lines · Antonio Quartulli
Quoted 4 lines · Frank Lichtenheld
I think this commit could use an additional sentence in the commit message on why exactly you remove this?
Doesn't immediately make sense to me.
To be honest, I am not even sure why we have a build with DCO in the first place. There is no DCO code yet in master but somehow we have the GH action for that :-D
Now there *is* DCO code in master, so why removing the --enable-dco?
So this patch definitely needs some more thought :-)
(And I thought there is an easy one to apply)
gert
Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany [email protected]...