gadgetfs: ep_io - wait until IRQ finishes
PATCH 1/1 gadgetfs: ep_io - wait until IRQ finishes
after usb_ep_queue() if wait_for_completion_interruptible() is interrupted we need to wait until IRQ gets finished.
Otherwise complete() from epio_complete() can corrupt stack.
--- drivers/usb/gadget/legacy/inode.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/gadget/legacy/inode.c +1 -0
@@ -362,6 +362,7 @@ ep_io (struct ep_data *epdata, void *buf, unsigned len)spin_unlock_irq (&epdata->dev->lock);DBG (epdata->dev,"endpoint gone\n" ); +wait_for_completion (&done); epdata->status = -ENODEV ; } }
Signature · 1 line
2.25.1
Greg Kroah-Hartman
maintainerQuoted 6 lines · Jozef Martiniak
after
usb_ep_queue()ifwait_for_completion_interruptible()is interrupted we need to wait until IRQ gets finished.Otherwise
complete()fromepio_complete()can corrupt stack.Signed-off-by Jozef Martiniak <[email protected]>
What commit id does this fix?
thanks,
greg k-h
The first commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
pi 8. 7. 2022 o 9:19 Greg Kroah-Hartman <[email protected]> napísal(a):
Quoted 14 lines · Jozef Martiniak
Quoted 6 lines
after
usb_ep_queue()ifwait_for_completion_interruptible()is interrupted we need to wait until IRQ gets finished.Otherwise
complete()fromepio_complete()can corrupt stack.Signed-off-by Jozef Martiniak <[email protected]>What commit id does this fix?
thanks,
greg k-h
Quoted 2 lines · Jozef Martiniak
after
usb_ep_queue()ifwait_for_completion_interruptible()is interrupted we need to wait until IRQ gets finished.
This should say "request" or "I/O request", not "IRQ". Not a big deal.
Quoted 5 lines
Otherwise
complete()fromepio_complete()can corrupt stack.Signed-off-by Jozef Martiniak <[email protected]>---
Quoted 18 lines
drivers/usb/gadget/legacy/inode.c | 1 + 1 file changed, 1 insertion(+)drivers/usb/gadget/legacy/inode.c +1
-0@@ -362,6 +362,7 @@ ep_io (struct ep_data *epdata, void *buf, unsigned len)spin_unlock_irq (&epdata->dev->lock);DBG (epdata->dev,"endpoint gone\n" ); +wait_for_completion (&done); epdata->status = -ENODEV ; } }Signature · 1 line
2.25.1