random: Use try_cmpxchg in _credit_init_bits
PATCH 1/1 random: Use try_cmpxchg in _credit_init_bits
Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in _credit_init_bits. x86 CMPXCHG instruction returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg).
Also, try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg fails, enabling further code simplifications.
No functional change intended.
--- drivers/char/random.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/char/random.c +2 -2
@@ -643,10 +643,10 @@ static void __cold _credit_init_bits(size_t bits) add =min_t (size_t, bits,POOL_BITS ); + orig =READ_ONCE (input_pool.init_bits);do { - orig =READ_ONCE (input_pool.init_bits); new = min_t(unsigned int, POOL_BITS, orig + add); - }while (cmpxchg (&input_pool.init_bits, orig, new) != orig); + }while (!try_cmpxchg (&input_pool.init_bits, &orig, new));if (orig <POOL_READY_BITS && new >=POOL_READY_BITS ) {crng_reseed ();/* Sets crng_init to CRNG_READY under base_crng.lock. */
Signature · 1 line
2.35.3
Jason A. Donenfeld
maintainerHi Uros,
Quoted 9 lines · Uros Bizjak
Use
try_cmpxchginstead of cmpxchg (*ptr, old, new) == old in_credit_init_bits. x86 CMPXCHG instruction returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg).Also,
try_cmpxchgimplicitly assigns old *ptr value to "old" when cmpxchg fails, enabling further code simplifications.No functional change intended.
Thanks for the patch.
Jason