migration: remove unreachable code after reading data
PATCH 1/1 migration: remove unreachable code after reading data
The code calls qio_channel_read() in a loop when it reports QIO_CHANNEL_ERR_BLOCK. This code is reported when errno==EAGAIN.
As such the later block of code will always hit the 'errno != EAGAIN' condition, making the final 'else' unreachable.
--- migration/qemu-file.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
migration/qemu-file.c +1 -3
@@ -384,10 +384,8 @@ static ssize_t qemu_fill_buffer(QEMUFile *f) f->total_transferred += len; }else if (len ==0 ) {qemu_file_set_error_obj (f, -EIO , local_error); - }else if (len != -EAGAIN ) { -qemu_file_set_error_obj (f, len, local_error); }else { -error_free (local_error); +qemu_file_set_error_obj (f, len, local_error); }return len;
Signature · 1 line
2.36.1
Quoted 8 lines · * Daniel P. Berrangé ([email protected]) wrote:
The code calls
qio_channel_read()in a loop when it reportsQIO_CHANNEL_ERR_BLOCK. This code is reported when errno==EAGAIN.As such the later block of code will always hit the 'errno != EAGAIN' condition, making the final 'else' unreachable.
Fixes Coverity CID 1490203Signed-off-by Daniel P. Berrangé <[email protected]>
Quoted 23 lines
--- migration/qemu-file.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)migration/qemu-file.c +1
-3@@ -384,10 +384,8 @@ static ssize_t qemu_fill_buffer(QEMUFile *f) f->total_transferred += len; }else if (len ==0 ) {qemu_file_set_error_obj (f, -EIO , local_error); - }else if (len != -EAGAIN ) { -qemu_file_set_error_obj (f, len, local_error); }else { -error_free (local_error); +qemu_file_set_error_obj (f, len, local_error); }return len;Signature · 1 line
2.36.1
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Quoted 8 lines · * Daniel P. Berrangé ([email protected]) wrote:
The code calls
qio_channel_read()in a loop when it reportsQIO_CHANNEL_ERR_BLOCK. This code is reported when errno==EAGAIN.As such the later block of code will always hit the 'errno != EAGAIN' condition, making the final 'else' unreachable.
Fixes Coverity CID 1490203Signed-off-by Daniel P. Berrangé <[email protected]>
Queued
Quoted 24 lines
--- migration/qemu-file.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)migration/qemu-file.c +1
-3@@ -384,10 +384,8 @@ static ssize_t qemu_fill_buffer(QEMUFile *f) f->total_transferred += len; }else if (len ==0 ) {qemu_file_set_error_obj (f, -EIO , local_error); - }else if (len != -EAGAIN ) { -qemu_file_set_error_obj (f, len, local_error); }else { -error_free (local_error); +qemu_file_set_error_obj (f, len, local_error); }return len;Signature · 1 line
2.36.1
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK