mmc: cavium-octeon: Add of_node_put() when breaking out of loop
Subsystems (2)
PATCH 1/2 mmc: cavium-octeon: Add of_node_put() when breaking out of loop
In octeon_mmc_probe(), we should call of_node_put() when breaking out of for_each_child_of_node() which has increased and decreased the refcount during each iteration.
--- drivers/mmc/host/cavium-octeon.c | 1 + 1 file changed, 1 insertion(+)
drivers/mmc/host/cavium-octeon.c +1 -0
@@ -277,6 +277,7 @@ static int octeon_mmc_probe(struct platform_device *pdev)if (ret) {dev_err (&pdev->dev,"Error populating slots\n" );octeon_mmc_set_shared_power (host,0 ); +of_node_put (cn); goto error; } i++;
Signature · 1 line
2.25.1
PATCH 2/2 mmc: cavium-thunderx: Add of_node_put() when breaking out of loop
In thunder_mmc_probe(), we should call of_node_put() when breaking out of for_each_child_of_node() which has increased and decreased the refcount during each iteration.
--- drivers/mmc/host/cavium-thunderx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mmc/host/cavium-thunderx.c +3 -1
@@ -142,8 +142,10 @@ static int thunder_mmc_probe(struct pci_dev *pdev,continue ; ret =cvm_mmc_of_slot_probe (&host->slot_pdev[i]->dev, host); -if (ret) +if (ret) { +of_node_put (child_node); goto error; + } } i++; }
Signature · 1 line
2.25.1
Re: [PATCH 2/2] mmc: cavium-thunderx: Add of_node_put() when breaking out of loop
Quoted 6 lines · Liang He
In
thunder_mmc_probe(), we should callof_node_put()when breaking out offor_each_child_of_node()which has increased and decreased the refcount during each iteration.Fixes 166bac38c3c5 ("mmc: cavium: Add MMC PCI driver for ThunderX SOCs")Signed-off-by Liang He <[email protected]>
Quoted 3 lines
--- drivers/mmc/host/cavium-thunderx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Re: [PATCH 2/2] mmc: cavium-thunderx: Add of_node_put() when breaking out of loop
In reply to Liang HeQuoted 7 lines · Liang He
In
thunder_mmc_probe(), we should callof_node_put()when breaking out offor_each_child_of_node()which has increased and decreased the refcount during each iteration.Fixes 166bac38c3c5 ("mmc: cavium: Add MMC PCI driver for ThunderX SOCs")Signed-off-by Liang He <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 23 lines
--- drivers/mmc/host/cavium-thunderx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/mmc/host/cavium-thunderx.c +3
-2@@ -142,8 +142,10 @@ static int thunder_mmc_probe(struct pci_dev *pdev,continue ; ret =cvm_mmc_of_slot_probe (&host->slot_pdev[i]->dev, host); -if (ret) +if (ret) { +of_node_put (child_node); goto error; + } } i++; } --2.25.1
Quoted 6 lines · Liang He
In
octeon_mmc_probe(), we should callof_node_put()when breaking out offor_each_child_of_node()which has increased and decreased the refcount during each iteration.Fixes 01d95843335c ("mmc: cavium: Add MMC support for Octeon SOCs.")Signed-off-by Liang He <[email protected]>
Quoted 3 lines
--- drivers/mmc/host/cavium-octeon.c | 1 + 1 file changed, 1 insertion(+)
Quoted 7 lines · Liang He
In
octeon_mmc_probe(), we should callof_node_put()when breaking out offor_each_child_of_node()which has increased and decreased the refcount during each iteration.Fixes 01d95843335c ("mmc: cavium: Add MMC support for Octeon SOCs.")Signed-off-by Liang He <[email protected]>
Applied for next, thanks!
Kind regards
Ulf Hansson
Quoted 19 lines
--- drivers/mmc/host/cavium-octeon.c | 1 + 1 file changed, 1 insertion(+)drivers/mmc/host/cavium-octeon.c +1
-1@@ -277,6 +277,7 @@ static int octeon_mmc_probe(struct platform_device *pdev)if (ret) {dev_err (&pdev->dev,"Error populating slots\n" );octeon_mmc_set_shared_power (host,0 ); +of_node_put (cn); goto error; } i++; --2.25.1