mlxsw: fix devlink use after frees
PATCH 1/1 mlxsw: fix devlink use after frees
Unlock "devlink" before freeing it instead of after.
Fixes 72a4c8c94efa ("mlxsw: convert driver to use unlocked devlink API during init/fini")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/net/ethernet/mellanox/mlxsw/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/mellanox/mlxsw/core.c +2 -2
@@ -2296,8 +2296,8 @@ void mlxsw_core_bus_device_unregister(struct mlxsw_core *mlxsw_core,devl_resources_unregister (devlink); mlxsw_core->bus->fini (mlxsw_core->bus_priv);if (!reload) { -devlink_free (devlink);devl_unlock (devlink); +devlink_free (devlink); }return ;
@@ -2305,8 +2305,8 @@ void mlxsw_core_bus_device_unregister(struct mlxsw_core *mlxsw_core, reload_fail_deinit:mlxsw_core_params_unregister (mlxsw_core);devl_resources_unregister (devlink); -devlink_free (devlink);devl_unlock (devlink); +devlink_free (devlink); }EXPORT_SYMBOL (mlxsw_core_bus_device_unregister);
Signature · 1 line
2.35.1
Ido Schimmel
maintainerQuoted 4 lines · Dan Carpenter
Unlock "devlink" before freeing it instead of after.
Fixes 72a4c8c94efa ("mlxsw: convert driver to use unlocked devlink API during init/fini")Signed-off-by Dan Carpenter <[email protected]>
Thanks for the patch, but a fix was already posted yesterday:
https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/