Skip to contentSkip to conversation

drm/panel-edp: add AUO B133UAN02.1 panel entry

PATCH In review Johan Hovold 3 participants 6 messages Jul 11, 2022 – Aug 23, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel-edp: add AUO B133UAN02.1 panel entry

Add an eDP panel entry for AUO B133UAN02.1.

Due to lack of documentation, use the delay_200_500_e50 timings like some other AUO entries for now.

---
 drivers/gpu/drm/panel/panel-edp.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/panel/panel-edp.c +1 -0
index fe3897b86665..30f69cd8f9ee 100644
@@ -1845,6 +1845,7 @@ static const struct panel_delay delay_100_500_e200 = {
  * Sort first by vendor, then by product ID.
  */
 static const struct edp_panel_entry edp_panels[] = {
+	EDP_PANEL_ENTRY('A', 'U', 'O', 0x1e9b, &delay_200_500_e50, "B133UAN02.1"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B116XAK01"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0x615c, &delay_200_500_e50, "B116XAN06.1"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0x8594, &delay_200_500_e50, "B133UAN01.0"),
Signature · 1 line
2.35.1
#1 lore raw
Quoted 6 lines · Johan Hovold

Add an eDP panel entry for AUO B133UAN02.1.

Due to lack of documentation, use the delay_200_500_e50 timings like some other AUO entries for now.

Any comments to this one?

It looks like it hasn't shown up in the dri-devel patchwork and just want to make sure it isn't lost.

Rob Clark mentioned something about a spam filter on IRC.

Quoted 9 lines
---
 drivers/gpu/drm/panel/panel-edp.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/panel/panel-edp.c +0 -0
index fe3897b86665..30f69cd8f9ee 100644

drivers/gpu/drm/panel/panel-edp.c static const struct panel_delay delay_100_500_e200 = { · line 1851

Quoted 7 lines
drivers/gpu/drm/panel/panel-edp.c +1 -0
@@ -1845,6 +1845,7 @@ static const struct panel_delay delay_100_500_e200 = {
  * Sort first by vendor, then by product ID.
  */
 static const struct edp_panel_entry edp_panels[] = {
+	EDP_PANEL_ENTRY('A', 'U', 'O', 0x1e9b, &delay_200_500_e50, "B133UAN02.1"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B116XAK01"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0x615c, &delay_200_500_e50, "B116XAN06.1"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0x8594, &delay_200_500_e50, "B133UAN01.0"),

Johan

#2 lore raw
Quoted 6 lines · Johan Hovold
Quoted 5 lines · Johan Hovold

Add an eDP panel entry for AUO B133UAN02.1.

Due to lack of documentation, use the delay_200_500_e50 timings like some other AUO entries for now.

Quoted 8 lines
Quoted 1 line

Any comments to this one?

It looks like it hasn't shown up in the dri-devel patchwork and just want to make sure it isn't lost.

Rob Clark mentioned something about a spam filter on IRC.

This one still hasn't been picked up.

Is this something you can do, Doug? I noticed you applied a couple of patches to this driver recently.

Or who is really responsible for this driver?

Quoted 4 lines
Quoted 4 lines
---
 drivers/gpu/drm/panel/panel-edp.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 12 lines

drivers/gpu/drm/panel/panel-edp.c static const struct panel_delay delay_100_500_e200 = { · line 1851

Quoted 12 lines
drivers/gpu/drm/panel/panel-edp.c +1 -0
index fe3897b86665..30f69cd8f9ee 100644
@@ -1845,6 +1845,7 @@ static const struct panel_delay delay_100_500_e200 = {
  * Sort first by vendor, then by product ID.
  */
 static const struct edp_panel_entry edp_panels[] = {
+	EDP_PANEL_ENTRY('A', 'U', 'O', 0x1e9b, &delay_200_500_e50, "B133UAN02.1"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B116XAK01"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0x615c, &delay_200_500_e50, "B116XAN06.1"),
 	EDP_PANEL_ENTRY('A', 'U', 'O', 0x8594, &delay_200_500_e50, "B133UAN01.0"),

Johan

reviewer
#3 lore raw

Hi,

Quoted 15 lines · Johan Hovold
Quoted 13 lines · Johan Hovold
Quoted 6 lines · Johan Hovold

Add an eDP panel entry for AUO B133UAN02.1.

Due to lack of documentation, use the delay_200_500_e50 timings like some other AUO entries for now.

Any comments to this one?

It looks like it hasn't shown up in the dri-devel patchwork and just want to make sure it isn't lost.

Quoted 8 lines
Quoted 1 line

Rob Clark mentioned something about a spam filter on IRC.

This one still hasn't been picked up.

Is this something you can do, Doug? I noticed you applied a couple of patches to this driver recently.

Or who is really responsible for this driver?

Officially it falls within this section of maintainers:

DRM PANEL DRIVERS

M:      Thierry Reding <[email protected]>
R:      Sam Ravnborg <[email protected]>
L:      [email protected]
S:      Maintained
T:      git git://anongit.freedesktop.org/drm/drm-misc
F:      Documentation/devicetree/bindings/display/panel/
F:      drivers/gpu/drm/drm_panel.c
F:      drivers/gpu/drm/panel/
F:      include/drm/drm_panel.h

...and then you just have to know that if the "tree" is drm-misc that it falls under drm-misc rules. That means that anyone who is a drm-misc-next committer can commit it.

I've been trying to keep an eye on panel-edp ever since I split it out from panel-simple, though. I'll post up a MAINTAINERS entry to try to make that more official.

In any case, I've landed this on drm-misc-next:

ee50b0024408 drm/panel-edp: add AUO B133UAN02.1 panel entry

-Doug

reviewer
#4 lore raw

Hi,

Quoted 41 lines · Doug Anderson

Hi,

Quoted 15 lines · Johan Hovold
Quoted 13 lines · Johan Hovold
Quoted 6 lines · Johan Hovold

Add an eDP panel entry for AUO B133UAN02.1.

Due to lack of documentation, use the delay_200_500_e50 timings like some other AUO entries for now.

Any comments to this one?

It looks like it hasn't shown up in the dri-devel patchwork and just want to make sure it isn't lost.

Quoted 8 lines
Quoted 1 line

Rob Clark mentioned something about a spam filter on IRC.

This one still hasn't been picked up.

Is this something you can do, Doug? I noticed you applied a couple of patches to this driver recently.

Or who is really responsible for this driver?

Officially it falls within this section of maintainers:

DRM PANEL DRIVERS

M:      Thierry Reding <[email protected]>
R:      Sam Ravnborg <[email protected]>
L:      [email protected]
S:      Maintained
T:      git git://anongit.freedesktop.org/drm/drm-misc
F:      Documentation/devicetree/bindings/display/panel/
F:      drivers/gpu/drm/drm_panel.c
F:      drivers/gpu/drm/panel/
F:      include/drm/drm_panel.h
Quoted 7 lines

...and then you just have to know that if the "tree" is drm-misc that it falls under drm-misc rules. That means that anyone who is a drm-misc-next committer can commit it.

I've been trying to keep an eye on panel-edp ever since I split it out from panel-simple, though. I'll post up a MAINTAINERS entry to try to make that more official.

Posted a patch to add myself in MAINTAINERS:

https://lore.kernel.org/r/20220822105340.1.I66a9a5577f9b0af66492ef13c47bc78ed85e5d6b@changeid

...though I had a brain-fail and didn't CC anyone on it. ;-)

-Doug

#5 lore raw
In reply to Doug Anderson
Quoted 33 lines · Doug Anderson

Hi,

Quoted 8 lines · Johan Hovold
Quoted 6 lines · Johan Hovold
Quoted 5 lines · Johan Hovold

Add an eDP panel entry for AUO B133UAN02.1.

Due to lack of documentation, use the delay_200_500_e50 timings like some other AUO entries for now.

Quoted 8 lines
Quoted 1 line
Quoted 1 line

This one still hasn't been picked up.

Is this something you can do, Doug? I noticed you applied a couple of patches to this driver recently.

Or who is really responsible for this driver?

Officially it falls within this section of maintainers:

DRM PANEL DRIVERS

M:      Thierry Reding <[email protected]>
R:      Sam Ravnborg <[email protected]>
L:      [email protected]
S:      Maintained
T:      git git://anongit.freedesktop.org/drm/drm-misc
F:      Documentation/devicetree/bindings/display/panel/
F:      drivers/gpu/drm/drm_panel.c
F:      drivers/gpu/drm/panel/
F:      include/drm/drm_panel.h
Quoted 7 lines

...and then you just have to know that if the "tree" is drm-misc that it falls under drm-misc rules. That means that anyone who is a drm-misc-next committer can commit it.

I've been trying to keep an eye on panel-edp ever since I split it out from panel-simple, though. I'll post up a MAINTAINERS entry to try to make that more official.

Sounds good.

Quoted 3 lines

In any case, I've landed this on drm-misc-next:

ee50b0024408 drm/panel-edp: add AUO B133UAN02.1 panel entry

Thanks for that! Perhaps you can take look also at this one:

	https://lore.kernel.org/all/[email protected]/

which is for another panel found on some X13s?

Johan