Skip to contentSkip to conversation

Bluetooth: mgmt: Fix double free on error path

PATCH Applied Dan Carpenter 3 participants 3 messages Jul 26, 2022 – Jul 29, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: mgmt: Fix double free on error path

Don't call mgmt_pending_remove() twice (double free).

Fixes 6b88eff43704 ("Bluetooth: hci_sync: Refactor remove Adv Monitor")
---
 net/bluetooth/mgmt.c | 1 -
 1 file changed, 1 deletion(-)
net/bluetooth/mgmt.c +0 -1
index 0c6878095709..2bca36b9f3a2 100644
@@ -5056,7 +5056,6 @@ static int remove_adv_monitor(struct sock *sk, struct hci_dev *hdev,
 		else
 			status = MGMT_STATUS_FAILED;
 
-		mgmt_pending_remove(cmd);
 		goto unlock;
 	}
 
Signature · 1 line
2.35.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=663130

---Test result---

Test Summary:

CheckPatch                    PASS      1.91 seconds
GitLint                       PASS      1.22 seconds
SubjectPrefix                 PASS      0.94 seconds
BuildKernel                   PASS      33.00 seconds
BuildKernel32                 PASS      28.54 seconds
Incremental Build with patchesPASS      41.68 seconds
TestRunner: Setup             PASS      478.13 seconds
TestRunner: l2cap-tester      PASS      16.71 seconds
TestRunner: bnep-tester       PASS      6.27 seconds
TestRunner: mgmt-tester       PASS      98.49 seconds
TestRunner: rfcomm-tester     PASS      9.46 seconds
TestRunner: sco-tester        PASS      9.30 seconds
TestRunner: smp-tester        PASS      9.38 seconds
TestRunner: userchan-tester   PASS      6.41 seconds

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Dan Carpenter
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 7 lines · On Tue, 26 Jul 2022 18:13:44 +0300 you wrote:

Don't call mgmt_pending_remove() twice (double free).

Fixes 6b88eff43704 ("Bluetooth: hci_sync: Refactor remove Adv Monitor")
---
 net/bluetooth/mgmt.c | 1 -
 1 file changed, 1 deletion(-)

Here is the summary with links:
- Bluetooth: mgmt: Fix double free on error path

    https://git.kernel.org/bluetooth/bluetooth-next/c/b7d8b9c71aa2

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html