Skip to contentSkip to conversation

drm/amd/display: Fix apply_synaptics_fifo_reset_wa()

PATCH New Dan Carpenter 1 participant 1 message Jul 26, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/display: Fix apply_synaptics_fifo_reset_wa()

There is a stray return which accidentally turns the last part of the function into dead code.

Fixes 2ca97adccdc9 ("drm/amd/display: Add Synaptics Fifo Reset Workaround")

---
From static analysis. Untested.

 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +0 -1
index a0154a5f7183..0d200e276e67 100644
@@ -671,7 +671,6 @@ static void apply_synaptics_fifo_reset_wa(struct drm_dp_aux *aux)
 		return;
 
 	data[0] |= (1 << 1); // set bit 1 to 1
-		return;
 
 	if (!execute_synaptics_rc_command(aux, false, 0x31, 4, 0x221198, data))
 		return;
Signature · 1 line
2.35.1