perf build: Suppress openssl v3 deprecation warnings in libcrypto feature test

With OpenSSL v3 installed, the libcrypto feature check fails as it use the deprecated MD5_* API (and is compiled with -Werror). The error message is as follows.

$ make tools/perf
```
Makefile.config:778: No libcrypto.h found, disables jitted code injection,
please install openssl-devel or libssl-dev

Auto-detecting system features:

...                         dwarf: [ on  ]
...            dwarf_getlocations: [ on  ]
...                         glibc: [ on  ]
...                        libbfd: [ on  ]
...                libbfd-buildid: [ on  ]
...                        libcap: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...        numa_num_possible_cpus: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                     libcrypto: [ OFF ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]
...                        libaio: [ on  ]
...                       libzstd: [ on  ]
...        disassembler-four-args: [ on  ]

```

This is very confusing because the suggested library (on my Ubuntu 20.04 it is libssl-dev) is already installed. As the test only checks for the presence of libcrypto, this commit suppresses the deprecation warning to allow the test to pass.

Signed-off-by Zixuan Tan <[email protected]>

---
 tools/build/feature/test-libcrypto.c | 6 ++++++
 1 file changed, 6 insertions(+)

tools/build/feature/test-libcrypto.c +0 -0

index a98174e0569c..31afff093d0b 100644

tools/build/feature/test-libcrypto.c +2 -0

+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+
 int main(void)
 {
 	MD5_CTX context;

Signature · 1 line

2.34.1

Quoted 51 lines

With OpenSSL v3 installed, the libcrypto feature check fails as it use the deprecated MD5_* API (and is compiled with -Werror). The error message is as follows.

$ make tools/perf
```
Makefile.config:778: No libcrypto.h found, disables jitted code injection,
please install openssl-devel or libssl-dev

Auto-detecting system features:

...                         dwarf: [ on  ]
...            dwarf_getlocations: [ on  ]
...                         glibc: [ on  ]
...                        libbfd: [ on  ]
...                libbfd-buildid: [ on  ]
...                        libcap: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...        numa_num_possible_cpus: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                     libcrypto: [ OFF ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]
...                        libaio: [ on  ]
...                       libzstd: [ on  ]
...        disassembler-four-args: [ on  ]

```

This is very confusing because the suggested library (on my Ubuntu 20.04 it is libssl-dev) is already installed. As the test only checks for the presence of libcrypto, this commit suppresses the deprecation warning to allow the test to pass.

Signed-off-by Zixuan Tan <[email protected]>

---
 tools/build/feature/test-libcrypto.c | 6 ++++++
 1 file changed, 6 insertions(+)

tools/build/feature/test-libcrypto.c +0 -0

index a98174e0569c..31afff093d0b 100644
@@ -2,6 +2,12 @@
 #include <openssl/sha.h>
 #include <openssl/md5.h>
 

tools/build/feature/test-libcrypto.c line 8

Quoted 4 lines

tools/build/feature/test-libcrypto.c +4 -0

+/*
+ * The MD5_* API have been deprecated since OpenSSL 3.0, which causes the
+ * feature test to fail silently. This is a workaround.
+ */

then we use these deprecated MD5 calls in util/genelf.c if libcrypto is detected, so I wonder how come the rest of the compilation passed for you.. do you have CONFIG_JITDUMP disabled?

Quoted 48 lines · Zixuan Tan

With OpenSSL v3 installed, the libcrypto feature check fails as it use the deprecated MD5_* API (and is compiled with -Werror). The error message is as follows.

$ make tools/perf
```
Makefile.config:778: No libcrypto.h found, disables jitted code injection,
please install openssl-devel or libssl-dev

Auto-detecting system features:

...                         dwarf: [ on  ]
...            dwarf_getlocations: [ on  ]
...                         glibc: [ on  ]
...                        libbfd: [ on  ]
...                libbfd-buildid: [ on  ]
...                        libcap: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...        numa_num_possible_cpus: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                     libcrypto: [ OFF ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]
...                        libaio: [ on  ]
...                       libzstd: [ on  ]
...        disassembler-four-args: [ on  ]

```

This is very confusing because the suggested library (on my Ubuntu 20.04 it is libssl-dev) is already installed. As the test only checks for the presence of libcrypto, this commit suppresses the deprecation warning to allow the test to pass.

Signed-off-by Zixuan Tan <[email protected]>

---
 tools/build/feature/test-libcrypto.c | 6 ++++++
 1 file changed, 6 insertions(+)

tools/build/feature/test-libcrypto.c +0 -0

index a98174e0569c..31afff093d0b 100644

tools/build/feature/test-libcrypto.c line 8

Quoted 7 lines

tools/build/feature/test-libcrypto.c +4 -0

@@ -2,6 +2,12 @@
 #include <openssl/sha.h>
 #include <openssl/md5.h>
 
+/*
+ * The MD5_* API have been deprecated since OpenSSL 3.0, which causes the
+ * feature test to fail silently. This is a workaround.
+ */

then we use these deprecated MD5 calls in util/genelf.c if libcrypto is detected, so I wonder how come the rest of the compilation passed for you.. do you have CONFIG_JITDUMP disabled?

thanks,
jirka

Quoted 8 lines

tools/build/feature/test-libcrypto.c +2 -1

+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+
 int main(void)
 {
      MD5_CTX context;
--

2.34.1

Quoted 62 lines · Jiri Olsa

Quoted 48 lines · Zixuan Tan

With OpenSSL v3 installed, the libcrypto feature check fails as it use the deprecated MD5_* API (and is compiled with -Werror). The error message is as follows.

$ make tools/perf
```
Makefile.config:778: No libcrypto.h found, disables jitted code injection,
please install openssl-devel or libssl-dev

Auto-detecting system features:

...                         dwarf: [ on  ]
...            dwarf_getlocations: [ on  ]
...                         glibc: [ on  ]
...                        libbfd: [ on  ]
...                libbfd-buildid: [ on  ]
...                        libcap: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...        numa_num_possible_cpus: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                     libcrypto: [ OFF ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]
...                        libaio: [ on  ]
...                       libzstd: [ on  ]
...        disassembler-four-args: [ on  ]

```

This is very confusing because the suggested library (on my Ubuntu 20.04 it is libssl-dev) is already installed. As the test only checks for the presence of libcrypto, this commit suppresses the deprecation warning to allow the test to pass.

Signed-off-by Zixuan Tan <[email protected]>

---
 tools/build/feature/test-libcrypto.c | 6 ++++++
 1 file changed, 6 insertions(+)

tools/build/feature/test-libcrypto.c +0 -0

index a98174e0569c..31afff093d0b 100644

tools/build/feature/test-libcrypto.c line 8

Quoted 7 lines

tools/build/feature/test-libcrypto.c +4 -0

@@ -2,6 +2,12 @@
 #include <openssl/sha.h>
 #include <openssl/md5.h>
 
+/*
+ * The MD5_* API have been deprecated since OpenSSL 3.0, which causes the
+ * feature test to fail silently. This is a workaround.
+ */

then we use these deprecated MD5 calls in util/genelf.c if libcrypto is detected, so I wonder how come the rest of the compilation passed for you.. do you have CONFIG_JITDUMP disabled?

Quoted 3 lines

thanks,
jirka

No, CONFIG_JITDUMP is not disabled. I am using the default configuration.

Yes, you are right. The rest of the compilation should fail, but it doesn't. I checked the verbose build commands. This seems to be the result of another inconsistency.

If libcrypto is detected, the macro "HAVE_LIBCRYPTO_SUPPORT" will be defined, but in perf/util/genelf.c, "HAVE_LIBCRYPTO" without the "_SUPPORT" prefix is checked. This causes urandom always be used to create build id rather than MD5 and SHA1, no matter what the detection result is.

In perf/Makefile.config, from line 776

```
ifndef NO_LIBCRYPTO
  ifneq ($(feature-libcrypto), 1)
    msg := $(warning No libcrypto.h found, disables jitted code injection,
            please install openssl-devel or libssl-dev);
    NO_LIBCRYPTO := 1
  else                                  <-- if libcrypto feature detected
    CFLAGS += -DHAVE_LIBCRYPTO_SUPPORT  <-- define this
    EXTLIBS += -lcrypto
    $(call detected,CONFIG_CRYPTO)
  endif
endif
```

In perf/util/genelf.c, from line 33
```
#ifdef HAVE_LIBCRYPTO <-- but check this, it's always false

#define BUILD_ID_MD5
#undef BUILD_ID_SHA /* does not seem to work well when linked with Java */ #undef BUILD_ID_URANDOM /* different uuid for each run */

#ifdef BUILD_ID_SHA
#include <openssl/sha.h>
#endif

#ifdef BUILD_ID_MD5
#include <openssl/md5.h>
#endif
#endif <-- this block will be skipped
```

Maybe we should fix this, to really make use of libcrypto if it is available?

Links:
This commit include the genelf.c:
https://lore.kernel.org/all/[email protected]/T/#mb6d3e18bee4901b71a4d4ef4f406feaaf48346d9
This commit include the feature test:
https://lore.kernel.org/all/[email protected]/T/#m12a2ababf8ad3e366d56d9efab870592e6ff60a5

Thanks,
Zixuan

Quoted 8 lines

Quoted 8 lines

tools/build/feature/test-libcrypto.c +2 -1

+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+
 int main(void)
 {
      MD5_CTX context;
--

2.34.1

Quoted 92 lines · 谭梓煊

Quoted 62 lines · Jiri Olsa

Quoted 48 lines · Zixuan Tan

With OpenSSL v3 installed, the libcrypto feature check fails as it use the deprecated MD5_* API (and is compiled with -Werror). The error message is as follows.

$ make tools/perf
```
Makefile.config:778: No libcrypto.h found, disables jitted code injection,
please install openssl-devel or libssl-dev

Auto-detecting system features:

...                         dwarf: [ on  ]
...            dwarf_getlocations: [ on  ]
...                         glibc: [ on  ]
...                        libbfd: [ on  ]
...                libbfd-buildid: [ on  ]
...                        libcap: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...        numa_num_possible_cpus: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                     libcrypto: [ OFF ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]
...                        libaio: [ on  ]
...                       libzstd: [ on  ]
...        disassembler-four-args: [ on  ]

```

This is very confusing because the suggested library (on my Ubuntu 20.04 it is libssl-dev) is already installed. As the test only checks for the presence of libcrypto, this commit suppresses the deprecation warning to allow the test to pass.

Signed-off-by Zixuan Tan <[email protected]>

---
 tools/build/feature/test-libcrypto.c | 6 ++++++
 1 file changed, 6 insertions(+)

tools/build/feature/test-libcrypto.c +0 -0

index a98174e0569c..31afff093d0b 100644

tools/build/feature/test-libcrypto.c line 8

Quoted 7 lines

tools/build/feature/test-libcrypto.c +4 -0

@@ -2,6 +2,12 @@
 #include <openssl/sha.h>
 #include <openssl/md5.h>
 
+/*
+ * The MD5_* API have been deprecated since OpenSSL 3.0, which causes the
+ * feature test to fail silently. This is a workaround.
+ */

then we use these deprecated MD5 calls in util/genelf.c if libcrypto is detected, so I wonder how come the rest of the compilation passed for you.. do you have CONFIG_JITDUMP disabled?

Quoted 3 lines

thanks,
jirka

No, CONFIG_JITDUMP is not disabled. I am using the default configuration.

Yes, you are right. The rest of the compilation should fail, but it doesn't. I checked the verbose build commands. This seems to be the result of another inconsistency.

If libcrypto is detected, the macro "HAVE_LIBCRYPTO_SUPPORT" will be defined, but in perf/util/genelf.c, "HAVE_LIBCRYPTO" without the "_SUPPORT" prefix is checked. This causes urandom always be used to create build id rather than MD5 and SHA1, no matter what the detection result is.

In perf/Makefile.config, from line 776

```
ifndef NO_LIBCRYPTO
  ifneq ($(feature-libcrypto), 1)
    msg := $(warning No libcrypto.h found, disables jitted code injection,
            please install openssl-devel or libssl-dev);
    NO_LIBCRYPTO := 1
  else                                  <-- if libcrypto feature detected
    CFLAGS += -DHAVE_LIBCRYPTO_SUPPORT  <-- define this
    EXTLIBS += -lcrypto
    $(call detected,CONFIG_CRYPTO)
  endif
endif
```

Quoted 3 lines

In perf/util/genelf.c, from line 33
```
#ifdef HAVE_LIBCRYPTO <-- but check this, it's always false

nice :)

Quoted 15 lines

#define BUILD_ID_MD5
#undef BUILD_ID_SHA /* does not seem to work well when linked with Java */ #undef BUILD_ID_URANDOM /* different uuid for each run */

#ifdef BUILD_ID_SHA
#include <openssl/sha.h>
#endif

#ifdef BUILD_ID_MD5
#include <openssl/md5.h>
#endif
#endif <-- this block will be skipped
```

Quoted 1 line

Maybe we should fix this, to really make use of libcrypto if it is available?

yea, I think that was the original idea, let's keep the variable with SUPPORT suffix and use the -Wdeprecated-declarations for genelf.c

full fix would be to detect the new API and use it when it's available but.. given that the check was false at least since 2016, perhaps we could remove that code? ;-) Stephane?

Quoted 116 lines · 谭梓煊

Quoted 92 lines · Jiri Olsa

Quoted 62 lines · Zixuan Tan

Quoted 48 lines

With OpenSSL v3 installed, the libcrypto feature check fails as it use the deprecated MD5_* API (and is compiled with -Werror). The error message is as follows.

$ make tools/perf
```
Makefile.config:778: No libcrypto.h found, disables jitted code injection,
please install openssl-devel or libssl-dev

Auto-detecting system features:

...                         dwarf: [ on  ]
...            dwarf_getlocations: [ on  ]
...                         glibc: [ on  ]
...                        libbfd: [ on  ]
...                libbfd-buildid: [ on  ]
...                        libcap: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...        numa_num_possible_cpus: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                     libcrypto: [ OFF ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]
...                        libaio: [ on  ]
...                       libzstd: [ on  ]
...        disassembler-four-args: [ on  ]

```

This is very confusing because the suggested library (on my Ubuntu 20.04 it is libssl-dev) is already installed. As the test only checks for the presence of libcrypto, this commit suppresses the deprecation warning to allow the test to pass.

Signed-off-by Zixuan Tan <[email protected]>

---
 tools/build/feature/test-libcrypto.c | 6 ++++++
 1 file changed, 6 insertions(+)

tools/build/feature/test-libcrypto.c +0 -0

index a98174e0569c..31afff093d0b 100644

tools/build/feature/test-libcrypto.c line 8

Quoted 7 lines

tools/build/feature/test-libcrypto.c +4 -0

@@ -2,6 +2,12 @@
 #include <openssl/sha.h>
 #include <openssl/md5.h>
 
+/*
+ * The MD5_* API have been deprecated since OpenSSL 3.0, which causes the
+ * feature test to fail silently. This is a workaround.
+ */

then we use these deprecated MD5 calls in util/genelf.c if libcrypto is detected, so I wonder how come the rest of the compilation passed for you.. do you have CONFIG_JITDUMP disabled?

Quoted 3 lines

thanks,
jirka

No, CONFIG_JITDUMP is not disabled. I am using the default configuration.

Yes, you are right. The rest of the compilation should fail, but it doesn't. I checked the verbose build commands. This seems to be the result of another inconsistency.

If libcrypto is detected, the macro "HAVE_LIBCRYPTO_SUPPORT" will be defined, but in perf/util/genelf.c, "HAVE_LIBCRYPTO" without the "_SUPPORT" prefix is checked. This causes urandom always be used to create build id rather than MD5 and SHA1, no matter what the detection result is.

In perf/Makefile.config, from line 776

```
ifndef NO_LIBCRYPTO
  ifneq ($(feature-libcrypto), 1)
    msg := $(warning No libcrypto.h found, disables jitted code injection,
            please install openssl-devel or libssl-dev);
    NO_LIBCRYPTO := 1
  else                                  <-- if libcrypto feature detected
    CFLAGS += -DHAVE_LIBCRYPTO_SUPPORT  <-- define this
    EXTLIBS += -lcrypto
    $(call detected,CONFIG_CRYPTO)
  endif
endif
```

Quoted 3 lines

In perf/util/genelf.c, from line 33
```
#ifdef HAVE_LIBCRYPTO <-- but check this, it's always false

nice :)

Quoted 16 lines

#define BUILD_ID_MD5
#undef BUILD_ID_SHA /* does not seem to work well when linked with Java */ #undef BUILD_ID_URANDOM /* different uuid for each run */

#ifdef BUILD_ID_SHA
#include <openssl/sha.h>
#endif

#ifdef BUILD_ID_MD5
#include <openssl/md5.h>
#endif
#endif <-- this block will be skipped
```

Maybe we should fix this, to really make use of libcrypto if it is available?

Quoted 6 lines

yea, I think that was the original idea, let's keep the variable with SUPPORT suffix and use the -Wdeprecated-declarations for genelf.c

full fix would be to detect the new API and use it when it's available but.. given that the check was false at least since 2016, perhaps we could remove that code? ;-) Stephane?

ping

Em Mon, Aug 01, 2022 at 03:24:18PM +0200, Jiri Olsa escreveu:

Quoted 117 lines · Jiri Olsa

Quoted 116 lines · 谭梓煊

Quoted 89 lines · Jiri Olsa

Quoted 53 lines · Zixuan Tan

Quoted 51 lines

With OpenSSL v3 installed, the libcrypto feature check fails as it use the deprecated MD5_* API (and is compiled with -Werror). The error message is as follows.

$ make tools/perf
```
Makefile.config:778: No libcrypto.h found, disables jitted code injection,
please install openssl-devel or libssl-dev

Auto-detecting system features:

...                         dwarf: [ on  ]
...            dwarf_getlocations: [ on  ]
...                         glibc: [ on  ]
...                        libbfd: [ on  ]
...                libbfd-buildid: [ on  ]
...                        libcap: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...        numa_num_possible_cpus: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                     libcrypto: [ OFF ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]
...                        libaio: [ on  ]
...                       libzstd: [ on  ]
...        disassembler-four-args: [ on  ]

```

This is very confusing because the suggested library (on my Ubuntu 20.04 it is libssl-dev) is already installed. As the test only checks for the presence of libcrypto, this commit suppresses the deprecation warning to allow the test to pass.

Signed-off-by Zixuan Tan <[email protected]>

---
 tools/build/feature/test-libcrypto.c | 6 ++++++
 1 file changed, 6 insertions(+)

tools/build/feature/test-libcrypto.c +0 -0

index a98174e0569c..31afff093d0b 100644
@@ -2,6 +2,12 @@
 #include <openssl/sha.h>
 #include <openssl/md5.h>
 

Quoted 9 lines

tools/build/feature/test-libcrypto.c line 8

Quoted 4 lines

tools/build/feature/test-libcrypto.c +4 -0

+/*
+ * The MD5_* API have been deprecated since OpenSSL 3.0, which causes the
+ * feature test to fail silently. This is a workaround.
+ */

then we use these deprecated MD5 calls in util/genelf.c if libcrypto is detected, so I wonder how come the rest of the compilation passed for you.. do you have CONFIG_JITDUMP disabled?

No, CONFIG_JITDUMP is not disabled. I am using the default configuration.

Yes, you are right. The rest of the compilation should fail, but it doesn't. I checked the verbose build commands. This seems to be the result of another inconsistency.

If libcrypto is detected, the macro "HAVE_LIBCRYPTO_SUPPORT" will be defined, but in perf/util/genelf.c, "HAVE_LIBCRYPTO" without the "_SUPPORT" prefix is checked. This causes urandom always be used to create build id rather than MD5 and SHA1, no matter what the detection result is.

In perf/Makefile.config, from line 776

```
ifndef NO_LIBCRYPTO
  ifneq ($(feature-libcrypto), 1)
    msg := $(warning No libcrypto.h found, disables jitted code injection,
            please install openssl-devel or libssl-dev);
    NO_LIBCRYPTO := 1
  else                                  <-- if libcrypto feature detected
    CFLAGS += -DHAVE_LIBCRYPTO_SUPPORT  <-- define this
    EXTLIBS += -lcrypto
    $(call detected,CONFIG_CRYPTO)
  endif
endif
```

Quoted 3 lines

In perf/util/genelf.c, from line 33
```
#ifdef HAVE_LIBCRYPTO <-- but check this, it's always false

nice :)

Quoted 9 lines

#define BUILD_ID_MD5
#undef BUILD_ID_SHA /* does not seem to work well when linked with Java */ #undef BUILD_ID_URANDOM /* different uuid for each run */

#ifdef BUILD_ID_SHA
#include <openssl/sha.h>
#endif

Quoted 7 lines

#ifdef BUILD_ID_MD5
#include <openssl/md5.h>
#endif
#endif <-- this block will be skipped
```

Maybe we should fix this, to really make use of libcrypto if it is available?

yea, I think that was the original idea, let's keep the variable with SUPPORT suffix and use the -Wdeprecated-declarations for genelf.c

Quoted 5 lines

Quoted 3 lines

full fix would be to detect the new API and use it when it's available but.. given that the check was false at least since 2016, perhaps we could remove that code? ;-) Stephane?

ping

So, we should start with 谭梓煊 patch, then fix that ifdef and go on from there?

Em Tue, Aug 02, 2022 at 03:09:05PM -0300, Arnaldo Carvalho de Melo escreveu:

Quoted 3 lines

So, we should start with 谭梓煊 patch, then fix that ifdef and go on from there?

I.e. with this:

tools/perf/util/genelf.c +0 -0

index aed49806a09bab8f..953338b9e887e26f 100644
@@ -30,7 +30,11 @@
 
 #define BUILD_ID_URANDOM /* different uuid for each run */

Em Mon, Aug 01, 2022 at 03:24:18PM +0200, Jiri Olsa escreveu:

Quoted 120 lines · Jiri Olsa

Quoted 119 lines · 谭梓煊

Quoted 92 lines · Jiri Olsa

Quoted 62 lines · Zixuan Tan

Quoted 48 lines

With OpenSSL v3 installed, the libcrypto feature check fails as it use the deprecated MD5_* API (and is compiled with -Werror). The error message is as follows.

$ make tools/perf
```
Makefile.config:778: No libcrypto.h found, disables jitted code injection,
please install openssl-devel or libssl-dev

Auto-detecting system features:

...                         dwarf: [ on  ]
...            dwarf_getlocations: [ on  ]
...                         glibc: [ on  ]
...                        libbfd: [ on  ]
...                libbfd-buildid: [ on  ]
...                        libcap: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...        numa_num_possible_cpus: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                     libcrypto: [ OFF ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]
...                        libaio: [ on  ]
...                       libzstd: [ on  ]
...        disassembler-four-args: [ on  ]

```

This is very confusing because the suggested library (on my Ubuntu 20.04 it is libssl-dev) is already installed. As the test only checks for the presence of libcrypto, this commit suppresses the deprecation warning to allow the test to pass.

Signed-off-by Zixuan Tan <[email protected]>

---
 tools/build/feature/test-libcrypto.c | 6 ++++++
 1 file changed, 6 insertions(+)

tools/build/feature/test-libcrypto.c +0 -0

index a98174e0569c..31afff093d0b 100644

tools/build/feature/test-libcrypto.c line 8

Quoted 7 lines

tools/build/feature/test-libcrypto.c +4 -0

@@ -2,6 +2,12 @@
 #include <openssl/sha.h>
 #include <openssl/md5.h>
 
+/*
+ * The MD5_* API have been deprecated since OpenSSL 3.0, which causes the
+ * feature test to fail silently. This is a workaround.
+ */

then we use these deprecated MD5 calls in util/genelf.c if libcrypto is detected, so I wonder how come the rest of the compilation passed for you.. do you have CONFIG_JITDUMP disabled?

Quoted 3 lines

thanks,
jirka

No, CONFIG_JITDUMP is not disabled. I am using the default configuration.

Yes, you are right. The rest of the compilation should fail, but it doesn't. I checked the verbose build commands. This seems to be the result of another inconsistency.

If libcrypto is detected, the macro "HAVE_LIBCRYPTO_SUPPORT" will be defined, but in perf/util/genelf.c, "HAVE_LIBCRYPTO" without the "_SUPPORT" prefix is checked. This causes urandom always be used to create build id rather than MD5 and SHA1, no matter what the detection result is.

In perf/Makefile.config, from line 776

```
ifndef NO_LIBCRYPTO
  ifneq ($(feature-libcrypto), 1)
    msg := $(warning No libcrypto.h found, disables jitted code injection,
            please install openssl-devel or libssl-dev);
    NO_LIBCRYPTO := 1
  else                                  <-- if libcrypto feature detected
    CFLAGS += -DHAVE_LIBCRYPTO_SUPPORT  <-- define this
    EXTLIBS += -lcrypto
    $(call detected,CONFIG_CRYPTO)
  endif
endif
```

Quoted 3 lines

In perf/util/genelf.c, from line 33
```
#ifdef HAVE_LIBCRYPTO <-- but check this, it's always false

nice :)

Quoted 9 lines

#define BUILD_ID_MD5
#undef BUILD_ID_SHA /* does not seem to work well when linked with Java */ #undef BUILD_ID_URANDOM /* different uuid for each run */

#ifdef BUILD_ID_SHA
#include <openssl/sha.h>
#endif

Quoted 7 lines

#ifdef BUILD_ID_MD5
#include <openssl/md5.h>
#endif
#endif <-- this block will be skipped
```

Maybe we should fix this, to really make use of libcrypto if it is available?

yea, I think that was the original idea, let's keep the variable with SUPPORT suffix and use the -Wdeprecated-declarations for genelf.c

Quoted 5 lines

Quoted 3 lines

full fix would be to detect the new API and use it when it's available but.. given that the check was false at least since 2016, perhaps we could remove that code? ;-) Stephane?

ping

So, we should start with 谭梓煊 patch, then fix that ifdef and go on from there?

Quoted 30 lines

Em Mon, Aug 01, 2022 at 03:24:18PM +0200, Jiri Olsa escreveu:

Quoted 29 lines · Jiri Olsa

Quoted 27 lines · 谭梓煊

Quoted 1 line

#ifdef HAVE_LIBCRYPTO <-- but check this, it's always false

nice :)

Quoted 8 lines

#define BUILD_ID_MD5
#undef BUILD_ID_SHA /* does not seem to work well when linked with Java */ #undef BUILD_ID_URANDOM /* different uuid for each run */

#ifdef BUILD_ID_SHA
#include <openssl/sha.h>
#endif

Quoted 7 lines

#ifdef BUILD_ID_MD5
#include <openssl/md5.h>
#endif
#endif <-- this block will be skipped
```

Maybe we should fix this, to really make use of libcrypto if it is available?

yea, I think that was the original idea, let's keep the variable with SUPPORT suffix and use the -Wdeprecated-declarations for genelf.c

full fix would be to detect the new API and use it when it's available but.. given that the check was false at least since 2016, perhaps we could remove that code? ;-) Stephane?

Quoted 4 lines

Quoted 1 line

ping

So, we should start with 谭梓煊 patch, then fix that ifdef and go on from there?

yes, I thought we could remove that, but there's no reply from Stephane so let's fix that