net/mlx5e: kTLS, Use _safe() iterator in mlx5e_tls_priv_tx_list_cleanup()
Subsystems (6)
PATCH 1/1 net/mlx5e: kTLS, Use _safe() iterator in mlx5e_tls_priv_tx_list_cleanup()
Use the list_for_each_entry_safe() macro to prevent dereferencing "obj" after it has been freed.
Fixes c4dfe704f53f ("net/mlx5e: kTLS, Recycle objects of device-offloaded TLS TX connections")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c +2 -2
@@ -246,7 +246,7 @@ static void mlx5e_tls_priv_tx_cleanup(struct mlx5e_ktls_offload_context_tx *privstatic void mlx5e_tls_priv_tx_list_cleanup (struct mlx5_core_dev *mdev,struct list_head *list,int size) { -struct mlx5e_ktls_offload_context_tx *obj; +struct mlx5e_ktls_offload_context_tx *obj, *n;struct mlx5e_async_ctx *bulk_async;int i;
@@ -255,7 +255,7 @@ static void mlx5e_tls_priv_tx_list_cleanup(struct mlx5_core_dev *mdev,return ; i =0 ; -list_for_each_entry (obj, list, list_node) { +list_for_each_entry_safe (obj, n, list, list_node) {mlx5e_tls_priv_tx_cleanup (obj, &bulk_async[i]); i++; }
Signature · 1 line
2.35.1
Quoted 23 lines · Dan Carpenter
Use the
list_for_each_entry_safe()macro to prevent dereferencing "obj" after it has been freed.Fixes c4dfe704f53f ("net/mlx5e: kTLS, Recycle objects of device-offloaded TLS TX connections")Signed-off-by Dan Carpenter <[email protected]>--- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c +1
-1@@ -246,7 +246,7 @@ static void mlx5e_tls_priv_tx_cleanup(struct mlx5e_ktls_offload_context_tx *privstatic void mlx5e_tls_priv_tx_list_cleanup (struct mlx5_core_dev *mdev,struct list_head *list,int size) { -struct mlx5e_ktls_offload_context_tx *obj; +struct mlx5e_ktls_offload_context_tx *obj, *n;struct mlx5e_async_ctx *bulk_async;int i;
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c static void mlx5e_tls_priv_tx_list_cleanup(struct mlx5_core_dev *mdev, · line 261
Quoted 8 lines
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c +1
-1@@ -255,7 +255,7 @@ static void mlx5e_tls_priv_tx_list_cleanup(struct mlx5_core_dev *mdev,return ; i =0 ; -list_for_each_entry (obj, list, list_node) { +list_for_each_entry_safe (obj, n, list, list_node) {mlx5e_tls_priv_tx_cleanup (obj, &bulk_async[i]); i++; }
Reviewed-by Tariq Toukan <[email protected]>
Thanks for your patch!