mfd: intel_soc_pmic_crc: Use devm_regmap_add_irq_chip()
PATCH RESEND 1/9 mfd: intel_soc_pmic_crc: Use devm_regmap_add_irq_chip()
Use devm_regmap_add_irq_chip() to simplify the code.
While at it, replace -1 magic parameter by PLATFORM_DEVID_NONE when calling mfd_add_devices().
Note, the mfd_add_devices() left in non-devm variant here due to potentially increased churn while wrapping pwm_remove_table().
--- drivers/mfd/intel_soc_pmic_crc.c | 24 +++++------------------- 1 file changed, 5 insertions(+), 19 deletions(-)
drivers/mfd/intel_soc_pmic_crc.c +5 -19
@@ -189,10 +189,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, pmic->irq = i2c->irq; - ret =regmap_add_irq_chip (pmic->regmap, pmic->irq, - config->irq_flags |IRQF_ONESHOT , -0 , config->irq_chip, - &pmic->irq_chip_data); + ret =devm_regmap_add_irq_chip (dev, pmic->regmap, pmic->irq, + config->irq_flags |IRQF_ONESHOT , +0 , config->irq_chip, &pmic->irq_chip_data);if (ret)return ret;
@@ -207,25 +206,12 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,irq_domain_update_bus_token (regmap_irq_get_domain (pmic->irq_chip_data),DOMAIN_BUS_NEXUS ); - ret =mfd_add_devices (dev,-1 , config->cell_dev, - config->n_cell_devs,NULL ,0 , -regmap_irq_get_domain (pmic->irq_chip_data)); -if (ret) - goto err_del_irq_chip; - -return 0 ; - -err_del_irq_chip: -regmap_del_irq_chip (pmic->irq, pmic->irq_chip_data); -return ret; +return mfd_add_devices (dev,PLATFORM_DEVID_NONE , config->cell_dev, config->n_cell_devs, +NULL ,0 ,regmap_irq_get_domain (pmic->irq_chip_data)); }static int intel_soc_pmic_i2c_remove (struct i2c_client *i2c) { -struct intel_soc_pmic *pmic =dev_get_drvdata (&i2c->dev); - -regmap_del_irq_chip (pmic->irq, pmic->irq_chip_data); -/* remove crc-pwm lookup table */ pwm_remove_table (crc_pwm_lookup,ARRAY_SIZE (crc_pwm_lookup));
Signature · 1 line
2.35.1
PATCH RESEND 2/9 mfd: intel_soc_pmic_crc: Convert to use i2c_get/set_clientdata()
We have the specific helpers for I2C device to set and get its driver data. Convert driver to use them instead of open coded variants.
--- drivers/mfd/intel_soc_pmic_crc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/intel_soc_pmic_crc.c +2 -2
@@ -181,7 +181,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,if (!pmic)return -ENOMEM ; -dev_set_drvdata (dev, pmic); +i2c_set_clientdata (i2c, pmic); pmic->regmap =devm_regmap_init_i2c (i2c, config->regmap_config);if (IS_ERR (pmic->regmap))
@@ -222,7 +222,7 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)static void intel_soc_pmic_shutdown (struct i2c_client *i2c) { -struct intel_soc_pmic *pmic =dev_get_drvdata (&i2c->dev); +struct intel_soc_pmic *pmic =i2c_get_clientdata (i2c);disable_irq (pmic->irq);
Signature · 1 line
2.35.1
PATCH RESEND 3/9 mfd: intel_soc_pmic_crc: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc
In reply to Andy ShevchenkoLetting the compiler remove these functions when the kernel is built without CONFIG_PM_SLEEP support is simpler and less error prone than the use of #ifdef based kernel configuration guards.
--- drivers/mfd/intel_soc_pmic_crc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/mfd/intel_soc_pmic_crc.c +2 -5
@@ -229,7 +229,6 @@ static void intel_soc_pmic_shutdown(struct i2c_client *i2c)return ; } -#if defined(CONFIG_PM_SLEEP )static int intel_soc_pmic_suspend (struct device *dev) {struct intel_soc_pmic *pmic =dev_get_drvdata (dev);
@@ -247,10 +246,8 @@ static int intel_soc_pmic_resume(struct device *dev)return 0 ; } -#endif -static SIMPLE_DEV_PM_OPS(intel_soc_pmic_pm_ops, intel_soc_pmic_suspend, - intel_soc_pmic_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(crystal_cove_pm_ops, intel_soc_pmic_suspend, intel_soc_pmic_resume);static const struct i2c_device_id intel_soc_pmic_i2c_id[] = { { }
@@ -268,7 +265,7 @@ MODULE_DEVICE_TABLE(acpi, intel_soc_pmic_acpi_match);static struct i2c_driver intel_soc_pmic_i2c_driver = { .driver = { .name ="intel_soc_pmic_i2c" , - .pm = &intel_soc_pmic_pm_ops, + .pm =pm_sleep_ptr (&crystal_cove_pm_ops), .acpi_match_table =ACPI_PTR (intel_soc_pmic_acpi_match), }, .probe = intel_soc_pmic_i2c_probe,
Signature · 1 line
2.35.1
PATCH RESEND 4/9 mfd: intel_soc_pmic_crc: Drop redundant ACPI_PTR() and ifdeffery
In reply to Andy ShevchenkoThe driver depends on ACPI, ACPI_PTR() resolution is always the same. Otherwise a compiler may produce a warning.
That said, the rule of thumb either ugly ifdeffery with ACPI_PTR or none should be used in a driver.
--- drivers/mfd/Kconfig | 4 ++-- drivers/mfd/intel_soc_pmic_crc.c | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-)
drivers/mfd/Kconfig +2 -2
@@ -588,8 +588,8 @@ config LPC_SCH config INTEL_SOC_PMIC bool "Support for Crystal Cove PMIC" - depends on ACPI && HAS_IOMEM && I2C=y && GPIOLIB && COMMON_CLK - depends on X86 || COMPILE_TEST + depends on HAS_IOMEM && I2C=y && GPIOLIB && COMMON_CLK + depends on (X86 && ACPI) || COMPILE_TEST depends on I2C_DESIGNWARE_PLATFORM=y select MFD_CORE select REGMAP_I2C
drivers/mfd/intel_soc_pmic_crc.c +2 -4
@@ -8,9 +8,9 @@* Author: Zhu, Lejun <[email protected]> */ -#include <linux/acpi.h> #include <linux/i2c.h> #include <linux/interrupt.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/mfd/core.h> #include <linux/mfd/intel_soc_pmic.h>
@@ -254,19 +254,17 @@ static const struct i2c_device_id intel_soc_pmic_i2c_id[] = { };MODULE_DEVICE_TABLE (i2c, intel_soc_pmic_i2c_id); -#if defined(CONFIG_ACPI )static const struct acpi_device_id intel_soc_pmic_acpi_match[] = { {"INT33FD" }, { }, };MODULE_DEVICE_TABLE (acpi, intel_soc_pmic_acpi_match); -#endif static struct i2c_driver intel_soc_pmic_i2c_driver = { .driver = { .name ="intel_soc_pmic_i2c" , .pm =pm_sleep_ptr (&crystal_cove_pm_ops), - .acpi_match_table =ACPI_PTR (intel_soc_pmic_acpi_match), + .acpi_match_table = intel_soc_pmic_acpi_match, }, .probe = intel_soc_pmic_i2c_probe, .remove = intel_soc_pmic_i2c_remove,
Signature · 1 line
2.35.1
PATCH RESEND 5/9 mfd: intel_soc_pmic_crc: Convert driver to use ->probe_new()
In reply to Andy ShevchenkoUse the ->probe_new() callback.
The driver does not use const struct i2c_device_id * argument, so convert it to utilise the simplified I²C driver registration.
--- drivers/mfd/intel_soc_pmic_crc.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
drivers/mfd/intel_soc_pmic_crc.c +2 -9
@@ -164,8 +164,7 @@ static const struct intel_soc_pmic_config intel_soc_pmic_config_cht_crc = { .irq_chip = &crystal_cove_irq_chip, }; -static int intel_soc_pmic_i2c_probe (struct i2c_client *i2c, -const struct i2c_device_id *i2c_id) +static int intel_soc_pmic_i2c_probe (struct i2c_client *i2c) {const struct intel_soc_pmic_config *config;struct device *dev = &i2c->dev;
@@ -249,11 +248,6 @@ static int intel_soc_pmic_resume(struct device *dev) static DEFINE_SIMPLE_DEV_PM_OPS(crystal_cove_pm_ops, intel_soc_pmic_suspend, intel_soc_pmic_resume); -static const struct i2c_device_id intel_soc_pmic_i2c_id[] = { - { } -}; -MODULE_DEVICE_TABLE (i2c, intel_soc_pmic_i2c_id); -static const struct acpi_device_id intel_soc_pmic_acpi_match[] = { {"INT33FD" }, { },
@@ -266,9 +260,8 @@ static struct i2c_driver intel_soc_pmic_i2c_driver = { .pm = pm_sleep_ptr(&crystal_cove_pm_ops), .acpi_match_table = intel_soc_pmic_acpi_match, }, - .probe = intel_soc_pmic_i2c_probe, + .probe_new = intel_soc_pmic_i2c_probe, .remove = intel_soc_pmic_i2c_remove, - .id_table = intel_soc_pmic_i2c_id, .shutdown = intel_soc_pmic_shutdown, };
Signature · 1 line
2.35.1
PATCH RESEND 6/9 mfd: intel_soc_pmic_crc: Replace intel_soc_pmic with crystal_cove
In reply to Andy ShevchenkoTo reflect the point that this driver is only for one type of the PMICs, replace intel_soc_pmic with crystal_cove (avoid using crc for possible namespace collisions with CRC library APIs).
Note, also rename the driver name since we don't expect any user that enumerates by it, only ACPI known so far.
--- drivers/mfd/intel_soc_pmic_crc.c | 42 ++++++++++++++++---------------- 1 file changed, 21 insertions(+), 21 deletions(-)
drivers/mfd/intel_soc_pmic_crc.c +21 -21
@@ -140,7 +140,7 @@ static struct pwm_lookup crc_pwm_lookup[] = { PWM_LOOKUP("crystal_cove_pwm", 0, "0000:00:02.0", "pwm_pmic_backlight", 0, PWM_POLARITY_NORMAL), }; -struct intel_soc_pmic_config { +struct crystal_cove_config {unsigned long irq_flags;struct mfd_cell *cell_dev;int n_cell_devs;
@@ -148,7 +148,7 @@ struct intel_soc_pmic_config {const struct regmap_irq_chip *irq_chip; }; -static const struct intel_soc_pmic_config intel_soc_pmic_config_byt_crc = { +static const struct crystal_cove_config crystal_cove_config_byt_crc = { .irq_flags =IRQF_TRIGGER_RISING , .cell_dev = crystal_cove_byt_dev, .n_cell_devs =ARRAY_SIZE (crystal_cove_byt_dev),
@@ -156,7 +156,7 @@ static const struct intel_soc_pmic_config intel_soc_pmic_config_byt_crc = { .irq_chip = &crystal_cove_irq_chip, }; -static const struct intel_soc_pmic_config intel_soc_pmic_config_cht_crc = { +static const struct crystal_cove_config crystal_cove_config_cht_crc = { .irq_flags =IRQF_TRIGGER_RISING , .cell_dev = crystal_cove_cht_dev, .n_cell_devs =ARRAY_SIZE (crystal_cove_cht_dev),
@@ -164,17 +164,17 @@ static const struct intel_soc_pmic_config intel_soc_pmic_config_cht_crc = { .irq_chip = &crystal_cove_irq_chip, }; -static int intel_soc_pmic_i2c_probe (struct i2c_client *i2c) +static int crystal_cove_i2c_probe (struct i2c_client *i2c) { -const struct intel_soc_pmic_config *config; +const struct crystal_cove_config *config;struct device *dev = &i2c->dev;struct intel_soc_pmic *pmic;int ret;if (soc_intel_is_byt ()) - config = &intel_soc_pmic_config_byt_crc; + config = &crystal_cove_config_byt_crc;else - config = &intel_soc_pmic_config_cht_crc; + config = &crystal_cove_config_cht_crc; pmic =devm_kzalloc (dev,sizeof (*pmic),GFP_KERNEL );if (!pmic)
@@ -209,7 +209,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c) NULL, 0, regmap_irq_get_domain(pmic->irq_chip_data)); } -static int intel_soc_pmic_i2c_remove (struct i2c_client *i2c) +static int crystal_cove_i2c_remove (struct i2c_client *i2c) {/* remove crc-pwm lookup table */ pwm_remove_table (crc_pwm_lookup,ARRAY_SIZE (crc_pwm_lookup));
@@ -219,7 +219,7 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)return 0 ; } -static void intel_soc_pmic_shutdown (struct i2c_client *i2c) +static void crystal_cove_shutdown (struct i2c_client *i2c) {struct intel_soc_pmic *pmic =i2c_get_clientdata (i2c);
@@ -228,7 +228,7 @@ static void intel_soc_pmic_shutdown(struct i2c_client *i2c)return ; } -static int intel_soc_pmic_suspend (struct device *dev) +static int crystal_cove_suspend (struct device *dev) {struct intel_soc_pmic *pmic =dev_get_drvdata (dev);
@@ -237,7 +237,7 @@ static int intel_soc_pmic_suspend(struct device *dev)return 0 ; } -static int intel_soc_pmic_resume (struct device *dev) +static int crystal_cove_resume (struct device *dev) {struct intel_soc_pmic *pmic =dev_get_drvdata (dev);
@@ -246,26 +246,26 @@ static int intel_soc_pmic_resume(struct device *dev)return 0 ; } -static DEFINE_SIMPLE_DEV_PM_OPS(crystal_cove_pm_ops, intel_soc_pmic_suspend, intel_soc_pmic_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(crystal_cove_pm_ops, crystal_cove_suspend, crystal_cove_resume); -static const struct acpi_device_id intel_soc_pmic_acpi_match[] = { +static const struct acpi_device_id crystal_cove_acpi_match[] = { {"INT33FD" }, { }, }; -MODULE_DEVICE_TABLE (acpi, intel_soc_pmic_acpi_match); +MODULE_DEVICE_TABLE (acpi, crystal_cove_acpi_match); -static struct i2c_driver intel_soc_pmic_i2c_driver = { +static struct i2c_driver crystal_cove_i2c_driver = { .driver = { - .name ="intel_soc_pmic_i2c" , + .name ="crystal_cove_i2c" , .pm =pm_sleep_ptr (&crystal_cove_pm_ops), - .acpi_match_table = intel_soc_pmic_acpi_match, + .acpi_match_table = crystal_cove_acpi_match, }, - .probe_new = intel_soc_pmic_i2c_probe, - .remove = intel_soc_pmic_i2c_remove, - .shutdown = intel_soc_pmic_shutdown, + .probe_new = crystal_cove_i2c_probe, + .remove = crystal_cove_i2c_remove, + .shutdown = crystal_cove_shutdown, }; -module_i2c_driver (intel_soc_pmic_i2c_driver); +module_i2c_driver (crystal_cove_i2c_driver);MODULE_DESCRIPTION ("I2C driver for Intel SoC PMIC" );MODULE_LICENSE ("GPL v2" );
Signature · 1 line
2.35.1
PATCH RESEND 7/9 mfd: intel_soc_pmic_crc: Update the copyright year
In reply to Andy ShevchenkoUpdate the copyright year to be 2012-2014, 2022.
--- drivers/mfd/intel_soc_pmic_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/intel_soc_pmic_crc.c +1 -1
@@ -2,7 +2,7 @@/* * Device access for Crystal Cove PMIC * -* Copyright (C) 2012-2014 Intel Corporation. All rights reserved. +* Copyright (C) 2012-2014, 2022 Intel Corporation. All rights reserved. * * Author: Yang, Bin <[email protected]> * Author: Zhu, Lejun <[email protected]>
Signature · 1 line
2.35.1
PATCH RESEND 8/9 mfd: intel_soc_pmic_bxtwc: Support IRQ chip hierarchy
In reply to Andy Shevchenko--- drivers/mfd/intel_soc_pmic_bxtwc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/mfd/intel_soc_pmic_bxtwc.c +4 -2
@@ -422,8 +422,10 @@ static int bxtwc_add_chained_irq_chip(struct intel_soc_pmic *pmic,return dev_err_probe (pmic->dev, irq,"Failed to get parent vIRQ(%d) for chip %s\n" , pirq, chip->name); -return devm_regmap_add_irq_chip (pmic->dev, pmic->regmap, irq, irq_flags, -0 , chip, data); +return __devm_regmap_add_irq_chip (pmic->dev, pmic->regmap, irq, + irq_flags,0 , +regmap_irq_get_domain (pdata), + chip, data); }static int bxtwc_probe (struct platform_device *pdev)
Signature · 1 line
2.35.1
Re: [RESEND][PATCH v1 8/9] mfd: intel_soc_pmic_bxtwc: Support IRQ chip hierarchy
On Mon, 18 Jul 2022, Andy Shevchenko wrote:
No commit message.
Probably needs to justify why it's calling a function denoted for internal use only.
Quoted 22 lines
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/mfd/intel_soc_pmic_bxtwc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/mfd/intel_soc_pmic_bxtwc.c +4
-2@@ -422,8 +422,10 @@ static int bxtwc_add_chained_irq_chip(struct intel_soc_pmic *pmic,return dev_err_probe (pmic->dev, irq,"Failed to get parent vIRQ(%d) for chip %s\n" , pirq, chip->name); -return devm_regmap_add_irq_chip (pmic->dev, pmic->regmap, irq, irq_flags, -0 , chip, data); +return __devm_regmap_add_irq_chip (pmic->dev, pmic->regmap, irq, + irq_flags,0 , +regmap_irq_get_domain (pdata), + chip, data); }static int bxtwc_probe (struct platform_device *pdev)
Signature · 1 line
DEPRECATED: Please use [email protected]
PATCH RESEND 9/9 Revert "mfd: intel_soc_pmic_bxtwc: Support IRQ chip hierarchy"
In reply to Andy ShevchenkoThis reverts commit 4a34dfdfcc185efea44da958b2e4a6005a70e7d4.
--- drivers/mfd/intel_soc_pmic_bxtwc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/mfd/intel_soc_pmic_bxtwc.c +2 -4
@@ -422,10 +422,8 @@ static int bxtwc_add_chained_irq_chip(struct intel_soc_pmic *pmic,return dev_err_probe (pmic->dev, irq,"Failed to get parent vIRQ(%d) for chip %s\n" , pirq, chip->name); -return __devm_regmap_add_irq_chip (pmic->dev, pmic->regmap, irq, - irq_flags,0 , -regmap_irq_get_domain (pdata), - chip, data); +return devm_regmap_add_irq_chip (pmic->dev, pmic->regmap, irq, irq_flags, +0 , chip, data); }static int bxtwc_probe (struct platform_device *pdev)
Signature · 1 line
2.35.1
Re: [RESEND][PATCH v1 9/9] Revert "mfd: intel_soc_pmic_bxtwc: Support IRQ chip hierarchy"
Quoted 1 line · Andy Shevchenko
This reverts commit
4a34dfdfcc185efea44da958b2e4a6005a70e7d4.
Sign-off?
Commit message?
Quoted 21 lines
--- drivers/mfd/intel_soc_pmic_bxtwc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/mfd/intel_soc_pmic_bxtwc.c +2
-4@@ -422,10 +422,8 @@ static int bxtwc_add_chained_irq_chip(struct intel_soc_pmic *pmic,return dev_err_probe (pmic->dev, irq,"Failed to get parent vIRQ(%d) for chip %s\n" , pirq, chip->name); -return __devm_regmap_add_irq_chip (pmic->dev, pmic->regmap, irq, - irq_flags,0 , -regmap_irq_get_domain (pdata), - chip, data); +return devm_regmap_add_irq_chip (pmic->dev, pmic->regmap, irq, irq_flags, +0 , chip, data); }static int bxtwc_probe (struct platform_device *pdev)
Signature · 1 line
DEPRECATED: Please use [email protected]
Re: [RESEND][PATCH v1 9/9] Revert "mfd: intel_soc_pmic_bxtwc: Support IRQ chip hierarchy"
Quoted 7 lines · Lee Jones
Quoted 1 line · Andy Shevchenko
This reverts commit
4a34dfdfcc185efea44da958b2e4a6005a70e7d4.Sign-off?
Commit message?
My guess is that you didn't mean to send 8 and 9, right?
Quoted 22 lines
Quoted 21 lines
--- drivers/mfd/intel_soc_pmic_bxtwc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/mfd/intel_soc_pmic_bxtwc.c +2
-4@@ -422,10 +422,8 @@ static int bxtwc_add_chained_irq_chip(struct intel_soc_pmic *pmic,return dev_err_probe (pmic->dev, irq,"Failed to get parent vIRQ(%d) for chip %s\n" , pirq, chip->name); -return __devm_regmap_add_irq_chip (pmic->dev, pmic->regmap, irq, - irq_flags,0 , -regmap_irq_get_domain (pdata), - chip, data); +return devm_regmap_add_irq_chip (pmic->dev, pmic->regmap, irq, irq_flags, +0 , chip, data); }static int bxtwc_probe (struct platform_device *pdev)
Signature · 1 line
DEPRECATED: Please use [email protected]
Re: [RESEND][PATCH v1 9/9] Revert "mfd: intel_soc_pmic_bxtwc: Support IRQ chip hierarchy"
Quoted 10 lines · Lee Jones
Quoted 7 lines · Lee Jones
Quoted 1 line · Andy Shevchenko
This reverts commit
4a34dfdfcc185efea44da958b2e4a6005a70e7d4.Sign-off?
Commit message?
My guess is that you didn't mean to send 8 and 9, right?
Right!
It was a wrong series, and I guess the latest one is this:
https://lore.kernel.org/lkml/[email protected]/
--
With Best Regards,
Andy Shevchenko
Quoted 8 lines · Andy Shevchenko
Use
devm_regmap_add_irq_chip()to simplify the code.While at it, replace -1 magic parameter by
PLATFORM_DEVID_NONEwhen callingmfd_add_devices().Note, the
mfd_add_devices()left in non-devm variant here due to potentially increased churn while wrappingpwm_remove_table().
Quoted 6 lines
Signed-off-by Andy Shevchenko <[email protected]>Tested-by Hans de Goede <[email protected]>Acked-for-MFD-by Lee Jones <[email protected]>--- drivers/mfd/intel_soc_pmic_crc.c | 24 +++++------------------- 1 file changed, 5 insertions(+), 19 deletions(-)
Doesn't apply, please rebase the set (probably on -next).
Signature · 1 line
DEPRECATED: Please use [email protected]
Quoted 11 lines · Lee Jones
Quoted 7 lines · Andy Shevchenko
Use
devm_regmap_add_irq_chip()to simplify the code.While at it, replace -1 magic parameter by
PLATFORM_DEVID_NONEwhen callingmfd_add_devices().Note, the
mfd_add_devices()left in non-devm variant here due to potentially increased churn while wrappingpwm_remove_table().Doesn't apply, please rebase the set (probably on -next).
It was a wrong series, and I guess the latest one is this:
https://lore.kernel.org/lkml/[email protected]/
Signature · 2 lines
With Best Regards, Andy Shevchenko