Skip to contentSkip to conversation

dt-bindings: marvell: Update Armada 37xx platform bindings

PATCH In review Pali Rohár 5 participants 19 messages Jul 13, 2022 – Feb 1, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: marvell: Update Armada 37xx platform bindings

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +6 -1
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+
  - compatible: must contain "marvell,armada3710"
 
 In addition, boards using the Marvell Armada 3720 SoC shall have the
@@ -13,7 +18,7 @@ following property before the previous one:
 
 Example:
 
-compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3710";
+compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3700";
 
 
 Power management
Signature · 1 line
2.20.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Pali Rohár

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
#2 lore raw
In reply to Pali Rohár

PING?

Quoted 37 lines · On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +6 -1
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+
  - compatible: must contain "marvell,armada3710"
 
 In addition, boards using the Marvell Armada 3720 SoC shall have the
@@ -13,7 +18,7 @@ following property before the previous one:
 
 Example:
 
-compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3710";
+compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3700";
 
 
 Power management
Signature · 1 line
2.20.1
#3 lore raw
Quoted 20 lines · Pali Rohár

PING?

Quoted 17 lines · On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +0 -0
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
Quoted 5 lines

Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt Marvell Armada 37xx Platforms Device Tree Bindings · line 11

Quoted 5 lines
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +5 -0
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+

The change is an ABI break, which looks reasonable, but still platform maintainer should comment on it. Especially on the aspect why the marvell,armada3710 fallback was chosen at the first place.

Unfortunately none of Marvel folks were CCed here, so you will need to resend it. Otherwise no one will apply it, regardless of our ack.

Best regards,
Krzysztof

#4 lore raw
Quoted 21 lines · On Tuesday 09 August 2022 08:58:50 Krzysztof Kozlowski wrote:
Quoted 20 lines · Pali Rohár

PING?

Quoted 17 lines · On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +0 -0
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
Quoted 9 lines
Quoted 5 lines

Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt Marvell Armada 37xx Platforms Device Tree Bindings · line 11

Quoted 5 lines
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +5 -0
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+

The change is an ABI break, which looks reasonable, but still platform maintainer should comment on it. Especially on the aspect why the marvell,armada3710 fallback was chosen at the first place.

I do not think this is ABI break but rather incorrect documentation and bug in some board dts files.

Quoted 2 lines

Unfortunately none of Marvel folks were CCed here, so you will need to resend it. Otherwise no one will apply it, regardless of our ack.

Done.

#5 lore raw
Quoted 32 lines · Pali Rohár
Quoted 21 lines · On Tuesday 09 August 2022 08:58:50 Krzysztof Kozlowski wrote:
Quoted 20 lines · Pali Rohár

PING?

Quoted 17 lines · On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +0 -0
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
Quoted 9 lines
Quoted 5 lines

Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt Marvell Armada 37xx Platforms Device Tree Bindings · line 11

Quoted 5 lines
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +5 -0
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+

The change is an ABI break, which looks reasonable, but still platform maintainer should comment on it. Especially on the aspect why the marvell,armada3710 fallback was chosen at the first place.

Quoted 2 lines

I do not think this is ABI break but rather incorrect documentation and bug in some board dts files.

This documentation is the ABI, especially if actually implemented in the DTS files, therefore by all definitions of DT ABI this is an ABI break.

What you are saying about "incorrect documentation and bug in some DTS files" is a good reason to break the ABI, but it is still a break.

Best regards,
Krzysztof

#6 lore raw
Quoted 33 lines · On Tuesday 09 August 2022 18:46:04 Krzysztof Kozlowski wrote:
Quoted 32 lines · Pali Rohár
Quoted 30 lines · On Tuesday 09 August 2022 08:58:50 Krzysztof Kozlowski wrote:
Quoted 20 lines · Pali Rohár

PING?

Quoted 17 lines · On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +0 -0
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
Quoted 5 lines

Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt Marvell Armada 37xx Platforms Device Tree Bindings · line 11

Quoted 5 lines
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +5 -0
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+

The change is an ABI break, which looks reasonable, but still platform maintainer should comment on it. Especially on the aspect why the marvell,armada3710 fallback was chosen at the first place.

Quoted 5 lines
Quoted 2 lines

I do not think this is ABI break but rather incorrect documentation and bug in some board dts files.

This documentation is the ABI, especially if actually implemented in the DTS files, therefore by all definitions of DT ABI this is an ABI break.

Ok.

Quoted 5 lines

What you are saying about "incorrect documentation and bug in some DTS files" is a good reason to break the ABI, but it is still a break.

Best regards,
Krzysztof

I think it is now clear what we both mean, just we used different terminology for the same thing.

#8 lore raw
Quoted 9 lines · On Saturday 24 September 2022 15:50:38 Krzysztof Kozlowski wrote:
Quoted 2 lines · Pali Rohár

PING?

You got the ack, what are you pinging us for?

Best regards,
Krzysztof

So, who can take this patch?

#9 lore raw
Quoted 11 lines · Pali Rohár
Quoted 9 lines · On Saturday 24 September 2022 15:50:38 Krzysztof Kozlowski wrote:
Quoted 2 lines · Pali Rohár

PING?

You got the ack, what are you pinging us for?

Best regards,
Krzysztof

So, who can take this patch?

This looks like platform bindings, so the platform maintainers. Would be easier for them to pick it up, if they were CCed. :)

I actually hoped they will pick up also fix for maintainers entry:
https://lore.kernel.org/all/875yi5g96s.fsf@BL-laptop/
...

Best regards,
Krzysztof

#10 lore raw
In reply to Pali Rohár

+ Andrew, Gregory, Sebastian

please comment on this

Quoted 37 lines · On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +6 -1
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+
  - compatible: must contain "marvell,armada3710"
 
 In addition, boards using the Marvell Armada 3720 SoC shall have the
@@ -13,7 +18,7 @@ following property before the previous one:
 
 Example:
 
-compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3710";
+compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3700";
 
 
 Power management
Signature · 1 line
2.20.1
maintainer
#11 lore raw
Quoted 3 lines · Pali Rohár

+ Andrew, Gregory, Sebastian

please comment on this

Quoted 3 lines · Krzysztof

The change is an ABI break, which looks reasonable, but still platform maintainer should comment on it. Especially on the aspect why the marvell,armada3710 fallback was chosen at the first place.

I was not involved in the armada37xx enablement. I have no idea why marvell,armada3710 fallback was chosen.

Gregory might know, he is the author of this file.

It does however seem reasonable. And a grep does suggest this compatible is purely cosmetic, it is not matched on anywhere.

Andrew

maintainer
#12 lore raw

Hello,

Quoted 11 lines · Pali Rohár
Quoted 3 lines

+ Andrew, Gregory, Sebastian

please comment on this

Quoted 3 lines · Krzysztof

The change is an ABI break, which looks reasonable, but still platform maintainer should comment on it. Especially on the aspect why the marvell,armada3710 fallback was chosen at the first place.

Quoted 7 lines

I was not involved in the armada37xx enablement. I have no idea why marvell,armada3710 fallback was chosen.

Gregory might know, he is the author of this file.

It does however seem reasonable. And a grep does suggest this compatible is purely cosmetic, it is not matched on anywhere.

This compatible was for the single core version of the Armada 37xx. I think the idea behind using it as fallback was the fact that if it works for aramda 3720 then it works for armada 3710.

Gregory

Quoted 2 lines

Andrew

Signature · 3 lines
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
#13 lore raw
In reply to Pali Rohár

PING?

Quoted 37 lines · On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +6 -1
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+
  - compatible: must contain "marvell,armada3710"
 
 In addition, boards using the Marvell Armada 3720 SoC shall have the
@@ -13,7 +18,7 @@ following property before the previous one:
 
 Example:
 
-compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3710";
+compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3700";
 
 
 Power management
Signature · 1 line
2.20.1
#14 lore raw
In reply to Pali Rohár

Gregory: ping

Quoted 37 lines · On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +6 -1
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+
  - compatible: must contain "marvell,armada3710"
 
 In addition, boards using the Marvell Armada 3720 SoC shall have the
@@ -13,7 +18,7 @@ following property before the previous one:
 
 Example:
 
-compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3710";
+compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3700";
 
 
 Power management
Signature · 1 line
2.20.1
#15 lore raw

PING?

Quoted 40 lines · On Sunday 09 October 2022 13:56:58 Pali Rohár wrote:

Gregory: ping

Quoted 37 lines · On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +6 -1
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+
  - compatible: must contain "marvell,armada3710"
 
 In addition, boards using the Marvell Armada 3720 SoC shall have the
@@ -13,7 +18,7 @@ following property before the previous one:
 
 Example:
 
-compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3710";
+compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3700";
 
 
 Power management
Signature · 1 line
2.20.1
#16 lore raw

PING?

Quoted 43 lines · On Tuesday 01 November 2022 23:43:00 Pali Rohár wrote:

PING?

Quoted 40 lines · On Sunday 09 October 2022 13:56:58 Pali Rohár wrote:

Gregory: ping

Quoted 37 lines · On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +6 -1
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+
  - compatible: must contain "marvell,armada3710"
 
 In addition, boards using the Marvell Armada 3720 SoC shall have the
@@ -13,7 +18,7 @@ following property before the previous one:
 
 Example:
 
-compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3710";
+compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3700";
 
 
 Power management
Signature · 1 line
2.20.1
#17 lore raw

PING?

Quoted 46 lines · On Monday 28 November 2022 19:18:29 Pali Rohár wrote:

PING?

Quoted 43 lines · On Tuesday 01 November 2022 23:43:00 Pali Rohár wrote:

PING?

Quoted 40 lines · On Sunday 09 October 2022 13:56:58 Pali Rohár wrote:

Gregory: ping

Quoted 37 lines · On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +6 -1
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+
  - compatible: must contain "marvell,armada3710"
 
 In addition, boards using the Marvell Armada 3720 SoC shall have the
@@ -13,7 +18,7 @@ following property before the previous one:
 
 Example:
 
-compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3710";
+compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3700";
 
 
 Power management
Signature · 1 line
2.20.1
#18 lore raw

PING?

Quoted 49 lines · On Friday 16 December 2022 19:20:01 Pali Rohár wrote:

PING?

Quoted 46 lines · On Monday 28 November 2022 19:18:29 Pali Rohár wrote:

PING?

Quoted 43 lines · On Tuesday 01 November 2022 23:43:00 Pali Rohár wrote:

PING?

Quoted 40 lines · On Sunday 09 October 2022 13:56:58 Pali Rohár wrote:

Gregory: ping

Quoted 37 lines · On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:

Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example.

---
 .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt +6 -1
index f6d6642d81c0..d2ca008de266 100644
@@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
 Boards using a SoC of the Marvell Armada 37xx family must carry the
 following root node property:
 
+ - compatible: must contain "marvell,armada3700"
+
+In addition, boards using the Marvell Armada 3710 SoC shall have the
+following property before the previous one:
+
  - compatible: must contain "marvell,armada3710"
 
 In addition, boards using the Marvell Armada 3720 SoC shall have the
@@ -13,7 +18,7 @@ following property before the previous one:
 
 Example:
 
-compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3710";
+compatible = "marvell,armada-3720-db", "marvell,armada3720", "marvell,armada3700";
 
 
 Power management
Signature · 1 line
2.20.1