mfd: fsl-imx25: fix check for platform_get_irq() errors
PATCH 1/1 mfd: fsl-imx25: fix check for platform_get_irq() errors
The mx25_tsadc_remove() function assumes all non-zero returns are success but the platform_get_irq() function returns negative on error and positive non-zero values on success. It never returns zero, but if it did then treat that as a success.
--- drivers/mfd/fsl-imx25-tsadc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/fsl-imx25-tsadc.c +2 -2
@@ -69,7 +69,7 @@ static int mx25_tsadc_setup_irq(struct platform_device *pdev,int irq; irq =platform_get_irq (pdev,0 ); -if (irq <=0 ) +if (irq <0 )return irq; tsadc->domain = irq_domain_add_simple(np, 2, 0, &mx25_tsadc_domain_ops,
@@ -179,7 +179,7 @@ static int mx25_tsadc_remove(struct platform_device *pdev)struct mx25_tsadc *tsadc =platform_get_drvdata (pdev);int irq =platform_get_irq (pdev,0 ); -if (irq) { +if (irq >=0 ) {irq_set_chained_handler_and_data (irq,NULL ,NULL );irq_domain_remove (tsadc->domain); }
Signature · 1 line
2.35.1
Thus wrote Dan Carpenter ([email protected]):
Quoted 35 lines
The
mx25_tsadc_remove()function assumes all non-zero returns are success but theplatform_get_irq()function returns negative on error and positive non-zero values on success. It never returns zero, but if it did then treat that as a success.Fixes 18f773937968 ("mfd: fsl-imx25: Clean up irq settings during removal")Signed-off-by Dan Carpenter <[email protected]>--- drivers/mfd/fsl-imx25-tsadc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/mfd/fsl-imx25-tsadc.c +2
-2@@ -69,7 +69,7 @@ static int mx25_tsadc_setup_irq(struct platform_device *pdev,int irq; irq =platform_get_irq (pdev,0 ); -if (irq <=0 ) +if (irq <0 )return irq; tsadc->domain = irq_domain_add_simple(np, 2, 0, &mx25_tsadc_domain_ops,@@ -179,7 +179,7 @@ static int mx25_tsadc_remove(struct platform_device *pdev)struct mx25_tsadc *tsadc =platform_get_drvdata (pdev);int irq =platform_get_irq (pdev,0 ); -if (irq) { +if (irq >=0 ) {irq_set_chained_handler_and_data (irq,NULL ,NULL );irq_domain_remove (tsadc->domain); }Signature · 1 line
2.35.1
Thanks,
Martin
Quoted 10 lines · Dan Carpenter
The
mx25_tsadc_remove()function assumes all non-zero returns are success but theplatform_get_irq()function returns negative on error and positive non-zero values on success. It never returns zero, but if it did then treat that as a success.Fixes 18f773937968 ("mfd: fsl-imx25: Clean up irq settings during removal")Signed-off-by Dan Carpenter <[email protected]>--- drivers/mfd/fsl-imx25-tsadc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Signature · 1 line
Lee Jones [李琼斯]