Skip to contentSkip to conversation

cxl: Add list verbose option to the cxl command

PATCH Superseded [email protected] 2 participants 3 messages Aug 12, 2022 Documentation

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 cxl: Add list verbose option to the cxl command

From: Matthew Ho <[email protected]>

This adds the new subcommands cxl list -v, cxl list -vv, and cxl list -vvv.

cxl list -v is now equivalent to cxl list -RMBDPT, cxl list -vv is equivalent to cxl list -RMBDPTi, and cxl list -vvv is equivalent to cxl list -RMBDPTiHI. These additions make it easier to list all of the CXL devices without having to remember which subcommand must be appended for each type of device.

---
Changes since v3[1]

- Fixed formatting of patch
- Amended patch to apply to latest region driver patches [2]
- Added missed "Acked-by"

[1]: https://lore.kernel.org/linux-cxl/[email protected]/
[2]: https://lore.kernel.org/linux-cxl/[email protected]/

Maybe this could be added to the region driver series?

 Documentation/cxl/cxl-list.txt | 20 ++++++++++++++++++++
 cxl/filter.h                   |  1 +
 cxl/list.c                     | 21 +++++++++++++++++++++
 3 files changed, 42 insertions(+)
Documentation/cxl/cxl-list.txt +20 -0
index 2906c2f6ef4b..0e7727ca167f 100644
@@ -336,6 +336,26 @@ OPTIONS
 --region::
 	Specify the region name to filter the emitted regions.
 
+-v::
+--verbose::
+	Increase verbosity of the output. This can be specified
+	multiple times to be even more verbose on the
+	informational and miscellaneous output, and can be used
+	to override omitted flags for showing specific
+	information. Note that cxl list --verbose --verbose is
+	equivalent to cxl list -vv, and likewise
+	cxl list --verbose --verbose --verbose is equivalent to
+	cxl list -vvv.
+	- *-v*
+	  Enable --memdevs, --regions, --buses,
+	  --ports, --decoders, and --targets.
+	- *-vv*
+	  Everything *-v* provides, plus include disabled
+	  devices with --idle.
+	- *-vvv*
+	  Everything *-vvv* provides, plus enable
+	  --health and --partition.
+
 --debug::
 	If the cxl tool was built with debug enabled, turn on debug
 	messages.
cxl/filter.h +1 -0
index d22d8b1f798b..256df49c3d0c 100644
@@ -26,6 +26,7 @@ struct cxl_filter_params {
 	bool human;
 	bool health;
 	bool partition;
+	int verbose;
 	struct log_ctx ctx;
 };
 
cxl/list.c +21 -0
index 5f604ecddf3c..8c48fbbaaec3 100644
@@ -52,6 +52,8 @@ static const struct option options[] = {
 		    "include memory device health information"),
 	OPT_BOOLEAN('I', "partition", &param.partition,
 		    "include memory device partition information"),
+	OPT_INCR('v', "verbose", &param.verbose,
+		 "increase output detail"),
 #ifdef ENABLE_DEBUG
 	OPT_BOOLEAN(0, "debug", &debug, "debug list walk"),
 #endif
@@ -106,6 +108,25 @@ int cmd_list(int argc, const char **argv, struct cxl_ctx *ctx)
 		param.memdevs = true;
 	}
 
+	switch(param.verbose){
+	default:
+	case 3:
+		param.health = true;
+		param.partition = true;
+		/* fallthrough */
+	case 2:
+		param.idle = true;
+		/* fallthrough */
+	case 1:
+		param.buses = true;
+		param.ports = true;
+		param.decoders = true;
+		param.targets = true;
+		/*fallthrough*/
+	case 0:
+		break;
+	}
+
 	log_init(&param.ctx, "cxl list", "CXL_LIST_LOG");
 	if (debug) {
 		cxl_set_log_priority(ctx, LOG_DEBUG);

--
2.34.1

#1 lore raw
Quoted 17 lines · On Fri, 2022-08-12 at 11:12 -0700, [email protected] wrote:

From: Matthew Ho <[email protected]>

This adds the new subcommands cxl list -v, cxl list -vv, and cxl list -vvv.

cxl list -v is now equivalent to cxl list -RMBDPT, cxl list -vv is equivalent to cxl list -RMBDPTi, and cxl list -vvv is equivalent to cxl list -RMBDPTiHI. These additions make it easier to list all of the CXL devices without having to remember which subcommand must be appended for each type of device.

---
Changes since v3[1]

Quoted 8 lines

 - Fixed formatting of patch
 - Amended patch to apply to latest region driver patches [2]
 - Added missed "Acked-by"

[1]: https://lore.kernel.org/linux-cxl/[email protected]/
[2]: https://lore.kernel.org/linux-cxl/[email protected]/

Maybe this could be added to the region driver series?

Hi Matthew,

Thanks for the update. I intend to pick up all pending patches in the next week or so in preparation for the v74 release, and I will include this.

One comment and small typo below - otherwise this looks good.

Quoted 16 lines

 Documentation/cxl/cxl-list.txt | 20 ++++++++++++++++++++ cxl/filter.h                   |  1 +
 cxl/list.c                     | 21 +++++++++++++++++++++

 3 files changed, 42 insertions(+)
Documentation/cxl/cxl-list.txt +0 -0
index 2906c2f6ef4b..0e7727ca167f 100644
@@ -336,6 +336,26 @@ OPTIONS

 --region::
        Specify the region name to filter the emitted regions.

+-v::
+--verbose::
Quoted 8 lines

+       Increase verbosity of the output. This can be specified +       multiple times to be even more verbose on the +       informational and miscellaneous output, and can be used +       to override omitted flags for showing specific +       information. Note that cxl list --verbose --verbose is +       equivalent to cxl list -vv, and likewise
+       cxl list --verbose --verbose --verbose is equivalent to +       cxl list -vvv.

I'd say a single example, of -vv is sufficient here.

Quoted 8 lines

+       - *-v*
+         Enable --memdevs, --regions, --buses, +         --ports, --decoders, and --targets.
+       - *-vv*
+         Everything *-v* provides, plus include disabled +         devices with --idle.
+       - *-vvv*
+         Everything *-vvv* provides, plus enable

The above should be -vv

Quoted 59 lines

+         --health and --partition.
+
 --debug::
        If the cxl tool was built with debug enabled, turn on debug messages.

cxl/filter.h +1 -0
index d22d8b1f798b..256df49c3d0c 100644
@@ -26,6 +26,7 @@ struct cxl_filter_params {
         bool human;
         bool health;
         bool partition;
+       int verbose;
         struct log_ctx ctx;
  };
 
cxl/list.c +21 -1
index 5f604ecddf3c..8c48fbbaaec3 100644
@@ -52,6 +52,8 @@ static const struct option options[] = {
                     "include memory device health information"),
         OPT_BOOLEAN('I', "partition", &param.partition,
                     "include memory device partition information"),
+       OPT_INCR('v', "verbose", &param.verbose,
+                "increase output detail"),
  #ifdef ENABLE_DEBUG
         OPT_BOOLEAN(0, "debug", &debug, "debug list walk"),
  #endif
@@ -106,6 +108,25 @@ int cmd_list(int argc, const char **argv, struct cxl_ctx *ctx)
                 param.memdevs = true;
         }
 
+       switch(param.verbose){
+       default:
+       case 3:
+               param.health = true;
+               param.partition = true;
+               /* fallthrough */
+       case 2:
+               param.idle = true;
+               /* fallthrough */
+       case 1:
+               param.buses = true;
+               param.ports = true;
+               param.decoders = true;
+               param.targets = true;
+               /*fallthrough*/
+       case 0:
+               break;
+       }
+
         log_init(&param.ctx, "cxl list", "CXL_LIST_LOG");
         if (debug) {
                 cxl_set_log_priority(ctx, LOG_DEBUG);
--

2.34.1

author
#2 lore raw
Quoted 25 lines · Vishal L
Quoted 24 lines · On Fri, 2022-08-12 at 11:12 -0700, [email protected] wrote:

From: Matthew Ho <[email protected]>

This adds the new subcommands cxl list -v, cxl list -vv, and cxl list -vvv.

cxl list -v is now equivalent to cxl list -RMBDPT, cxl list -vv is equivalent to cxl list -RMBDPTi, and cxl list -vvv is equivalent to cxl list -RMBDPTiHI. These additions make it easier to list all of the CXL devices without having to remember which subcommand must be appended for each type of device.

---
Changes since v3[1]

 - Fixed formatting of patch
 - Amended patch to apply to latest region driver patches [2]
 - Added missed "Acked-by"

[1]: https://lore.kernel.org/linux-cxl/[email protected]/
[2]: https://lore.kernel.org/linux-cxl/[email protected]/

Quoted 7 lines
Quoted 1 line

Maybe this could be added to the region driver series?

Hi Matthew,

Thanks for the update. I intend to pick up all pending patches in the next week or so in preparation for the v74 release, and I will include this.

Thanks, sounds great! I'll fix the changes in a v5.

Quoted 17 lines

One comment and small typo below - otherwise this looks good.

Quoted 14 lines

 Documentation/cxl/cxl-list.txt | 20 ++++++++++++++++++++ cxl/filter.h                   |  1 +
 cxl/list.c                     | 21 +++++++++++++++++++++

 3 files changed, 42 insertions(+)
Documentation/cxl/cxl-list.txt +0 -0
index 2906c2f6ef4b..0e7727ca167f 100644
@@ -336,6 +336,26 @@ OPTIONS

 --region::
        Specify the region name to filter the emitted regions.

Quoted 12 lines
Quoted 10 lines
+-v::
+--verbose::

+       Increase verbosity of the output. This can be specified +       multiple times to be even more verbose on the +       informational and miscellaneous output, and can be used +       to override omitted flags for showing specific +       information. Note that cxl list --verbose --verbose is +       equivalent to cxl list -vv, and likewise
+       cxl list --verbose --verbose --verbose is equivalent to +       cxl list -vvv.

I'd say a single example, of -vv is sufficient here.

Sounds good, will remove the -vvv example.

Quoted 10 lines
Quoted 8 lines

+       - *-v*
+         Enable --memdevs, --regions, --buses, +         --ports, --decoders, and --targets.
+       - *-vv*
+         Everything *-v* provides, plus include disabled +         devices with --idle.
+       - *-vvv*
+         Everything *-vvv* provides, plus enable

The above should be -vv

Oops, thanks for the catch, will fix.

Quoted 52 lines
Quoted 52 lines

+         --health and --partition.
+
 --debug::
        If the cxl tool was built with debug enabled, turn on debug messages.

cxl/filter.h +1 -0
index d22d8b1f798b..256df49c3d0c 100644
@@ -26,6 +26,7 @@ struct cxl_filter_params {
         bool human;
         bool health;
         bool partition;
+       int verbose;
         struct log_ctx ctx;
  };
 
cxl/list.c +19 -0
index 5f604ecddf3c..8c48fbbaaec3 100644
@@ -52,6 +52,8 @@ static const struct option options[] = {
                     "include memory device health information"),
         OPT_BOOLEAN('I', "partition", &param.partition,
                     "include memory device partition information"),
+       OPT_INCR('v', "verbose", &param.verbose,
+                "increase output detail"),
  #ifdef ENABLE_DEBUG
         OPT_BOOLEAN(0, "debug", &debug, "debug list walk"),
  #endif
@@ -106,6 +108,25 @@ int cmd_list(int argc, const char **argv, struct cxl_ctx *ctx)
                 param.memdevs = true;
         }
 
+       switch(param.verbose){
+       default:
+       case 3:
+               param.health = true;
+               param.partition = true;
+               /* fallthrough */
+       case 2:
+               param.idle = true;
+               /* fallthrough */
+       case 1:
+               param.buses = true;
+               param.ports = true;
+               param.decoders = true;
+               param.targets = true;
+               /*fallthrough*/
+       case 0:
+               break;
Quoted 9 lines
Quoted 8 lines
cxl/list.c +2 -1
+       }
+
         log_init(&param.ctx, "cxl list", "CXL_LIST_LOG");
         if (debug) {
                 cxl_set_log_priority(ctx, LOG_DEBUG);
--

2.34.1

Thanks again for the feedback!

Best,
Matthew