sched: core: remove access_ok() before copy_to_user()
PATCH 1/1 sched: core: remove access_ok() before copy_to_user()
If usize > ksize, usize may be not valid and if(!access_ok()) will return -EFAULT. But ksize may be valid, copy_to_user() should be executed.And also, copy_to_user() will calls access_ok() to test whether a block of memory is a valid user space address.
--- kernel/sched/core.c | 3 --- 1 file changed, 3 deletions(-)
kernel/sched/core.c +0 -3
@@ -7975,9 +7975,6 @@ sched_attr_copy_to_user(struct sched_attr __user *uattr, {unsigned int ksize =sizeof (*kattr); -if (!access_ok (uattr, usize)) -return -EFAULT ; -/* * sched_getattr() ABI forwards and backwards compatibility: *
Signature · 1 line
2.17.1
Peter Zijlstra
maintainerQuoted 4 lines · Tuo Cao
If usize > ksize, usize may be not valid and if(!access_ok()) will return
-EFAULT. But ksize may be valid,copy_to_user()should be executed.And also,copy_to_user()will callsaccess_ok()to test whether a block of memory is a valid user space address.
I don't follow, why do you want this to continue if the user provided garbage input?
I just think usize has limited in caller of sched_attr_copy_to_user() : SCHED_ATTR_SIZE_VER0 < usize < PAGE_SIZE. Maybe user provided garbage input and cause (usize + uattr) > TASK_SIZE, but if (ksize + uattr) < TASK_SIZE, user can also get the struct sched_attr correctly by copy_to_user() only and there are no side effects.
So, should we really limit user get the struct sched_attr in this situation? Thanks.
Quoted 9 lines · Peter Zijlstra <[email protected]> 于2022年8月16日周二 17:18写道:
Quoted 4 lines · Tuo Cao
If usize > ksize, usize may be not valid and if(!access_ok()) will return
-EFAULT. But ksize may be valid,copy_to_user()should be executed.And also,copy_to_user()will callsaccess_ok()to test whether a block of memory is a valid user space address.I don't follow, why do you want this to continue if the user provided garbage input?