usb: typec: tcpm: Return ENOTSUPP for power supply prop writes
Subsystems (4)
Badhri Jagan Sridharan
maintainerPATCH v2 1/1 usb: typec: tcpm: Return ENOTSUPP for power supply prop writes
When the port does not support USB PD, prevent transition to PD only states when power supply property is written. In this case, TCPM transitions to SNK_NEGOTIATE_CAPABILITIES
which should not be the case given that the port is not pd_capable.
[ 84.308251] state change SNK_READY -> SNK_NEGOTIATE_CAPABILITIES [rev3 NONE_AMS] [ 84.308335] Setting usb_comm capable false [ 84.323367] set_auto_vbus_discharge_threshold mode:3 pps_active:n vbus:5000 ret:0 [ 84.323376] state change SNK_NEGOTIATE_CAPABILITIES -> SNK_WAIT_CAPABILITIES [rev3 NONE_AMS]
---
Changes since v1:
- Add Fixes tag.
--- drivers/usb/typec/tcpm/tcpm.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/usb/typec/tcpm/tcpm.c +7 -0
@@ -6320,6 +6320,13 @@ static int tcpm_psy_set_prop(struct power_supply *psy,struct tcpm_port *port =power_supply_get_drvdata (psy);int ret; +/* +* All the properties below are related to USB PD. The check needs to be +* property specific when a non-pd related property is added. +*/ +if (!port->pd_supported) +return -EOPNOTSUPP ; +switch (psp) {case POWER_SUPPLY_PROP_ONLINE : ret =tcpm_psy_set_online (port, val);
Signature · 1 line
2.37.1.595.g718a3a8f04-goog
kernel test robot
build botFYI: kernel test robot notices the stable kernel rule is not satisfied.
Hi,
Thanks for your patch.
FYI: kernel test robot notices the stable kernel rule is not satisfied.
Rule: 'Cc: [email protected]' or 'commit <sha1> upstream.'
Subject: [PATCH v2] usb: typec: tcpm: Return ENOTSUPP for power supply prop writes
The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
Signature · 2 lines
0-DAY CI Kernel Test Service https://01.org/lkp
Greg Kroah-Hartman
maintainerQuoted 10 lines · Badhri Jagan Sridharan
When the port does not support USB PD, prevent transition to PD only states when power supply property is written. In this case, TCPM transitions to
SNK_NEGOTIATE_CAPABILITIES
which should not be the case given that the port is notpd_capable.[ 84.308251] state change SNK_READY -> SNK_NEGOTIATE_CAPABILITIES [rev3 NONE_AMS] [ 84.308335] Setting usb_comm capable false [ 84.323367] set_auto_vbus_discharge_threshold mode:3 pps_active:n vbus:5000 ret:0 [ 84.323376] state change SNK_NEGOTIATE_CAPABILITIES -> SNK_WAIT_CAPABILITIES [rev3 NONE_AMS]
Quoted 8 lines
Fixes e9e6e164ed8f6 ("usb: typec: tcpm: Support non-PD mode")Signed-off-by Badhri Jagan Sridharan <[email protected]>---
Changes since v1:
- Add Fixes tag.--- drivers/usb/typec/tcpm/tcpm.c | 7 +++++++ 1 file changed, 7 insertions(+)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>