Fix console probe delay when stdout-path isn't set
Subsystems (49)
v2 cover Fix console probe delay when stdout-path isn't set
These patches are on top of driver-core-next.
Even if stdout-path isn't set in DT, this patch should take console probe times back to how they were before the deferred_probe_timeout clean up series[1].
v1->v2:
- Fixed the accidental change that Tobias pointed out.
- Added Tested-by tag
[1] - https://lore.kernel.org/lkml/[email protected]/
-Saravana
Saravana Kannan (2):
driver core: Add probe_no_timeout flag for drivers
serial: Set probe_no_timeout for all DT based drivers
drivers/base/base.h | 1 + drivers/base/core.c | 7 +++++++ drivers/base/dd.c | 3 +++ drivers/tty/ehv_bytechan.c | 1 + drivers/tty/goldfish.c | 1 + drivers/tty/hvc/hvc_opal.c | 1 + drivers/tty/serial/8250/8250_aspeed_vuart.c | 1 + drivers/tty/serial/8250/8250_bcm2835aux.c | 1 + drivers/tty/serial/8250/8250_bcm7271.c | 1 + drivers/tty/serial/8250/8250_dw.c | 1 + drivers/tty/serial/8250/8250_em.c | 1 + drivers/tty/serial/8250/8250_ingenic.c | 1 + drivers/tty/serial/8250/8250_lpc18xx.c | 1 + drivers/tty/serial/8250/8250_mtk.c | 1 + drivers/tty/serial/8250/8250_of.c | 1 + drivers/tty/serial/8250/8250_omap.c | 1 + drivers/tty/serial/8250/8250_pxa.c | 1 + drivers/tty/serial/8250/8250_tegra.c | 1 + drivers/tty/serial/8250/8250_uniphier.c | 1 + drivers/tty/serial/altera_jtaguart.c | 1 + drivers/tty/serial/altera_uart.c | 1 + drivers/tty/serial/amba-pl011.c | 1 + drivers/tty/serial/apbuart.c | 1 + drivers/tty/serial/ar933x_uart.c | 1 + drivers/tty/serial/arc_uart.c | 1 + drivers/tty/serial/atmel_serial.c | 1 + drivers/tty/serial/bcm63xx_uart.c | 1 + drivers/tty/serial/clps711x.c | 1 + drivers/tty/serial/cpm_uart/cpm_uart_core.c | 1 + drivers/tty/serial/digicolor-usart.c | 1 + drivers/tty/serial/fsl_linflexuart.c | 1 + drivers/tty/serial/fsl_lpuart.c | 1 + drivers/tty/serial/imx.c | 1 + drivers/tty/serial/lantiq.c | 1 + drivers/tty/serial/liteuart.c | 1 + drivers/tty/serial/lpc32xx_hs.c | 1 + drivers/tty/serial/max310x.c | 1 + drivers/tty/serial/meson_uart.c | 1 + drivers/tty/serial/milbeaut_usio.c | 1 + drivers/tty/serial/mpc52xx_uart.c | 1 + drivers/tty/serial/mps2-uart.c | 1 + drivers/tty/serial/msm_serial.c | 1 + drivers/tty/serial/mvebu-uart.c | 1 + drivers/tty/serial/mxs-auart.c | 1 + drivers/tty/serial/omap-serial.c | 1 + drivers/tty/serial/owl-uart.c | 1 + drivers/tty/serial/pic32_uart.c | 1 + drivers/tty/serial/pmac_zilog.c | 1 + drivers/tty/serial/pxa.c | 1 + drivers/tty/serial/qcom_geni_serial.c | 1 + drivers/tty/serial/rda-uart.c | 1 + drivers/tty/serial/samsung_tty.c | 1 + drivers/tty/serial/sc16is7xx.c | 1 + drivers/tty/serial/serial-tegra.c | 1 + drivers/tty/serial/sh-sci.c | 1 + drivers/tty/serial/sifive.c | 1 + drivers/tty/serial/sprd_serial.c | 1 + drivers/tty/serial/st-asc.c | 1 + drivers/tty/serial/stm32-usart.c | 1 + drivers/tty/serial/sunhv.c | 1 + drivers/tty/serial/sunplus-uart.c | 1 + drivers/tty/serial/sunsab.c | 1 + drivers/tty/serial/sunsu.c | 1 + drivers/tty/serial/sunzilog.c | 1 + drivers/tty/serial/tegra-tcu.c | 1 + drivers/tty/serial/uartlite.c | 1 + drivers/tty/serial/ucc_uart.c | 1 + drivers/tty/serial/vt8500_serial.c | 1 + drivers/tty/serial/xilinx_uartps.c | 1 + include/linux/device.h | 7 +++++++ include/linux/device/driver.h | 11 +++++++++++ 71 files changed, 95 insertions(+)
Signature · 1 line
2.37.0.rc0.161.g10f37bed90-goog
PATCH v2 1/2 driver core: Add probe_no_timeout flag for drivers
This flag only needs to be set for drivers of devices that meet all the following conditions:
- Need to probe successfully before userspace init in started
- Have optional suppliers
- Can't wait for deferred_probe_timeout to expire
fw_devlink=on uses this info, as needed, to ignore dependencies on supplier devices that have not been added or supplier devices that don't have any drivers. It's still up to the driver to decide which of the missing suppliers are optional or not.
--- drivers/base/base.h | 1 + drivers/base/core.c | 7 +++++++ drivers/base/dd.c | 3 +++ include/linux/device.h | 7 +++++++ include/linux/device/driver.h | 11 +++++++++++ 5 files changed, 29 insertions(+)
drivers/base/base.h +1 -0
@@ -193,6 +193,7 @@ extern void device_links_no_driver(struct device *dev);extern bool device_links_busy (struct device *dev);extern void device_links_unbind_consumers (struct device *dev);extern void fw_devlink_drivers_done (void ); +extern void fw_devlink_probe_no_timeout (void );/* device pm support */ void device_pm_move_to_tail (struct device *dev);
drivers/base/core.c +7 -0
@@ -54,6 +54,7 @@ static unsigned int defer_sync_state_count = 1;static DEFINE_MUTEX (fwnode_link_lock);static bool fw_devlink_is_permissive (void );static bool fw_devlink_drv_reg_done; +static bool fw_devlink_no_timeout;static bool fw_devlink_best_effort;/**
@@ -969,6 +970,7 @@ static void device_links_missing_supplier(struct device *dev)static bool dev_is_best_effort (struct device *dev) {return (fw_devlink_best_effort && dev->can_match) || + (fw_devlink_no_timeout && dev->probe_no_timeout) || (dev->fwnode && (dev->fwnode->flags &FWNODE_FLAG_BEST_EFFORT )); }
@@ -1688,6 +1690,11 @@ void fw_devlink_drivers_done(void)device_links_write_unlock (); } +void fw_devlink_probe_no_timeout (void ) +{ + fw_devlink_no_timeout = true; +} +/** * wait_for_init_devices_probe - Try to probe any device needed for init *
drivers/base/dd.c +3 -0
@@ -324,6 +324,8 @@ static int deferred_probe_initcall(void)if (!IS_ENABLED (CONFIG_MODULES ))fw_devlink_drivers_done (); +else +fw_devlink_probe_no_timeout ();/* * Trigger deferred probe again, this time we won't defer anything
@@ -734,6 +736,7 @@ static int __driver_probe_device(struct device_driver *drv, struct device *dev)return -EBUSY ; dev->can_match = true; + dev->probe_no_timeout = drv->probe_no_timeout;pr_debug ("bus: '%s': %s: matched device %s with driver %s\n" , drv->bus->name, __func__,dev_name (dev), drv->name);
include/linux/device.h +7 -0
@@ -536,6 +536,12 @@ struct device_physical_location {* @can_match: The device has matched with a driver at least once or it is in * a bus (like AMBA) which can't check for matching drivers until * other devices probe successfully. +* @probe_no_timeout: Set by driver core to indicate that this device's probe +* can't wait till driver_probe_timeout expires. This information +* is used by fw_devlink=on to avoid deferring the probe of this +* device to wait on supplier devices that haven't been added or +* probed successfully. +* See also: probe_no_timeout in struct driver. * @dma_coherent: this particular device is dma coherent, even if the * architecture supports non-coherent devices. * @dma_ops_bypass: If set to %true then the dma_ops are bypassed for the
@@ -642,6 +648,7 @@ struct device { bool of_node_reused:1; bool state_synced:1; bool can_match:1; + bool probe_no_timeout:1;#if defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_DEVICE ) || \ defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU ) || \ defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL )
include/linux/device/driver.h +11 -0
@@ -55,6 +55,15 @@ enum probe_type {* @owner: The module owner. * @mod_name: Used for built-in modules. * @suppress_bind_attrs: Disables bind/unbind via sysfs. +* @probe_no_timeout: Set to true by drivers that bind to devices that meet all +* these conditions: +* - Need to probe successfully before userspace init in started +* - Have optional suppliers +* - Can't wait for deferred_probe_timeout to expire +* fw_devlink=on uses this info, as needed, to ignore dependencies +* on supplier devices that have not been added or supplier devices +* that don't have any drivers. It's still up to the driver to +* decide which of the missing suppliers are optional or not. * @probe_type: Type of the probe (synchronous or asynchronous) to use. * @of_match_table: The open firmware table. * @acpi_match_table: The ACPI match table.
@@ -101,6 +110,8 @@ struct device_driver {const char *mod_name;/* used for built-in modules */ bool suppress_bind_attrs;/* disables bind/unbind via sysfs */ +bool probe_no_timeout; +enum probe_type probe_type;const struct of_device_id *of_match_table;
Signature · 1 line
2.37.0.rc0.161.g10f37bed90-goog
PATCH v2 2/2 serial: Set probe_no_timeout for all DT based drivers
In reply to Saravana KannanWith commit 71066545b48e ("driver core: Set fw_devlink.strict=1 by default") the probing of TTY consoles could get delayed if they have optional suppliers that are listed in DT, but those suppliers don't probe by the time kernel boot finishes. The console devices will probe eventually after driver_probe_timeout expires.
However, since consoles are often used for debugging kernel issues, it does not make sense to delay their probe. So, set the newly added probe_no_timeout flag for all serial drivers that at DT based. This way, fw_devlink will know not to delay the probing of the consoles past kernel boot.
--- drivers/tty/ehv_bytechan.c | 1 + drivers/tty/goldfish.c | 1 + drivers/tty/hvc/hvc_opal.c | 1 + drivers/tty/serial/8250/8250_aspeed_vuart.c | 1 + drivers/tty/serial/8250/8250_bcm2835aux.c | 1 + drivers/tty/serial/8250/8250_bcm7271.c | 1 + drivers/tty/serial/8250/8250_dw.c | 1 + drivers/tty/serial/8250/8250_em.c | 1 + drivers/tty/serial/8250/8250_ingenic.c | 1 + drivers/tty/serial/8250/8250_lpc18xx.c | 1 + drivers/tty/serial/8250/8250_mtk.c | 1 + drivers/tty/serial/8250/8250_of.c | 1 + drivers/tty/serial/8250/8250_omap.c | 1 + drivers/tty/serial/8250/8250_pxa.c | 1 + drivers/tty/serial/8250/8250_tegra.c | 1 + drivers/tty/serial/8250/8250_uniphier.c | 1 + drivers/tty/serial/altera_jtaguart.c | 1 + drivers/tty/serial/altera_uart.c | 1 + drivers/tty/serial/amba-pl011.c | 1 + drivers/tty/serial/apbuart.c | 1 + drivers/tty/serial/ar933x_uart.c | 1 + drivers/tty/serial/arc_uart.c | 1 + drivers/tty/serial/atmel_serial.c | 1 + drivers/tty/serial/bcm63xx_uart.c | 1 + drivers/tty/serial/clps711x.c | 1 + drivers/tty/serial/cpm_uart/cpm_uart_core.c | 1 + drivers/tty/serial/digicolor-usart.c | 1 + drivers/tty/serial/fsl_linflexuart.c | 1 + drivers/tty/serial/fsl_lpuart.c | 1 + drivers/tty/serial/imx.c | 1 + drivers/tty/serial/lantiq.c | 1 + drivers/tty/serial/liteuart.c | 1 + drivers/tty/serial/lpc32xx_hs.c | 1 + drivers/tty/serial/max310x.c | 1 + drivers/tty/serial/meson_uart.c | 1 + drivers/tty/serial/milbeaut_usio.c | 1 + drivers/tty/serial/mpc52xx_uart.c | 1 + drivers/tty/serial/mps2-uart.c | 1 + drivers/tty/serial/msm_serial.c | 1 + drivers/tty/serial/mvebu-uart.c | 1 + drivers/tty/serial/mxs-auart.c | 1 + drivers/tty/serial/omap-serial.c | 1 + drivers/tty/serial/owl-uart.c | 1 + drivers/tty/serial/pic32_uart.c | 1 + drivers/tty/serial/pmac_zilog.c | 1 + drivers/tty/serial/pxa.c | 1 + drivers/tty/serial/qcom_geni_serial.c | 1 + drivers/tty/serial/rda-uart.c | 1 + drivers/tty/serial/samsung_tty.c | 1 + drivers/tty/serial/sc16is7xx.c | 1 + drivers/tty/serial/serial-tegra.c | 1 + drivers/tty/serial/sh-sci.c | 1 + drivers/tty/serial/sifive.c | 1 + drivers/tty/serial/sprd_serial.c | 1 + drivers/tty/serial/st-asc.c | 1 + drivers/tty/serial/stm32-usart.c | 1 + drivers/tty/serial/sunhv.c | 1 + drivers/tty/serial/sunplus-uart.c | 1 + drivers/tty/serial/sunsab.c | 1 + drivers/tty/serial/sunsu.c | 1 + drivers/tty/serial/sunzilog.c | 1 + drivers/tty/serial/tegra-tcu.c | 1 + drivers/tty/serial/uartlite.c | 1 + drivers/tty/serial/ucc_uart.c | 1 + drivers/tty/serial/vt8500_serial.c | 1 + drivers/tty/serial/xilinx_uartps.c | 1 + 66 files changed, 66 insertions(+)
drivers/tty/ehv_bytechan.c +1 -0
@@ -739,6 +739,7 @@ static struct platform_driver ehv_bc_tty_driver = { .driver = { .name = "ehv-bc", .of_match_table = ehv_bc_tty_of_ids, + .probe_no_timeout = true, .suppress_bind_attrs = true, }, .probe = ehv_bc_tty_probe,
drivers/tty/goldfish.c +1 -0
@@ -474,6 +474,7 @@ static struct platform_driver goldfish_tty_platform_driver = { .driver = { .name = "goldfish_tty", .of_match_table = goldfish_tty_of_match, + .probe_no_timeout = true, } };
drivers/tty/hvc/hvc_opal.c +1 -0
@@ -253,6 +253,7 @@ static struct platform_driver hvc_opal_driver = { .driver = { .name = hvc_opal_name, .of_match_table = hvc_opal_match, + .probe_no_timeout = true, } };
drivers/tty/serial/8250/8250_aspeed_vuart.c +1 -0
@@ -592,6 +592,7 @@ static struct platform_driver aspeed_vuart_driver = { .driver = { .name = "aspeed-vuart", .of_match_table = aspeed_vuart_table, + .probe_no_timeout = true, }, .probe = aspeed_vuart_probe, .remove = aspeed_vuart_remove,
drivers/tty/serial/8250/8250_bcm2835aux.c +1 -0
@@ -223,6 +223,7 @@ static struct platform_driver bcm2835aux_serial_driver = { .name = "bcm2835-aux-uart", .of_match_table = bcm2835aux_serial_match, .acpi_match_table = bcm2835aux_serial_acpi_match, + .probe_no_timeout = true, }, .probe = bcm2835aux_serial_probe, .remove = bcm2835aux_serial_remove,
drivers/tty/serial/8250/8250_bcm7271.c +1 -0
@@ -1193,6 +1193,7 @@ static struct platform_driver brcmuart_platform_driver = { .name = "bcm7271-uart", .pm = &brcmuart_dev_pm_ops, .of_match_table = brcmuart_dt_ids, + .probe_no_timeout = true, }, .probe = brcmuart_probe, .remove = brcmuart_remove,
drivers/tty/serial/8250/8250_dw.c +1 -0
@@ -795,6 +795,7 @@ static struct platform_driver dw8250_platform_driver = { .pm = &dw8250_pm_ops, .of_match_table = dw8250_of_match, .acpi_match_table = dw8250_acpi_match, + .probe_no_timeout = true, }, .probe = dw8250_probe, .remove = dw8250_remove,
drivers/tty/serial/8250/8250_em.c +1 -0
@@ -151,6 +151,7 @@ static struct platform_driver serial8250_em_platform_driver = { .driver = { .name = "serial8250-em", .of_match_table = serial8250_em_dt_ids, + .probe_no_timeout = true, }, .probe = serial8250_em_probe, .remove = serial8250_em_remove,
drivers/tty/serial/8250/8250_ingenic.c +1 -0
@@ -341,6 +341,7 @@ static struct platform_driver ingenic_uart_platform_driver = { .driver = { .name = "ingenic-uart", .of_match_table = of_match, + .probe_no_timeout = true, }, .probe = ingenic_uart_probe, .remove = ingenic_uart_remove,
drivers/tty/serial/8250/8250_lpc18xx.c +1 -0
@@ -215,6 +215,7 @@ static struct platform_driver lpc18xx_serial_driver = { .driver = { .name = "lpc18xx-uart", .of_match_table = lpc18xx_serial_match, + .probe_no_timeout = true, }, };module_platform_driver (lpc18xx_serial_driver);
drivers/tty/serial/8250/8250_mtk.c +1 -0
@@ -671,6 +671,7 @@ static struct platform_driver mtk8250_platform_driver = { .name = "mt6577-uart", .pm = &mtk8250_pm_ops, .of_match_table = mtk8250_of_match, + .probe_no_timeout = true, }, .probe = mtk8250_probe, .remove = mtk8250_remove,
drivers/tty/serial/8250/8250_of.c +1 -0
@@ -343,6 +343,7 @@ static struct platform_driver of_platform_serial_driver = { .driver = { .name = "of_serial", .of_match_table = of_platform_serial_table, + .probe_no_timeout = true, .pm = &of_serial_pm_ops, }, .probe = of_platform_serial_probe,
drivers/tty/serial/8250/8250_omap.c +1 -0
@@ -1694,6 +1694,7 @@ static struct platform_driver omap8250_platform_driver = { .name = "omap8250", .pm = &omap8250_dev_pm_ops, .of_match_table = omap8250_dt_ids, + .probe_no_timeout = true, }, .probe = omap8250_probe, .remove = omap8250_remove,
drivers/tty/serial/8250/8250_pxa.c +1 -0
@@ -165,6 +165,7 @@ static struct platform_driver serial_pxa_driver = { .name = "pxa2xx-uart", .pm = &serial_pxa_pm_ops, .of_match_table = serial_pxa_dt_ids, + .probe_no_timeout = true, }, };
drivers/tty/serial/8250/8250_tegra.c +1 -0
@@ -187,6 +187,7 @@ static struct platform_driver tegra_uart_driver = { .pm = &tegra_uart_pm_ops, .of_match_table = tegra_uart_of_match, .acpi_match_table = ACPI_PTR(tegra_uart_acpi_match), + .probe_no_timeout = true, }, .probe = tegra_uart_probe, .remove = tegra_uart_remove,
drivers/tty/serial/8250/8250_uniphier.c +1 -0
@@ -297,6 +297,7 @@ static struct platform_driver uniphier_uart_platform_driver = { .driver = { .name = "uniphier-uart", .of_match_table = uniphier_uart_match, + .probe_no_timeout = true, .pm = &uniphier_uart_pm_ops, }, };
drivers/tty/serial/altera_jtaguart.c +1 -0
@@ -493,6 +493,7 @@ static struct platform_driver altera_jtaguart_platform_driver = { .driver = { .name = DRV_NAME, .of_match_table = of_match_ptr(altera_jtaguart_match), + .probe_no_timeout = true, }, };
drivers/tty/serial/altera_uart.c +1 -0
@@ -645,6 +645,7 @@ static struct platform_driver altera_uart_platform_driver = { .driver = { .name = DRV_NAME, .of_match_table = of_match_ptr(altera_uart_match), + .probe_no_timeout = true, }, };
drivers/tty/serial/amba-pl011.c +1 -0
@@ -2912,6 +2912,7 @@ static struct platform_driver arm_sbsa_uart_platform_driver = { .pm = &pl011_dev_pm_ops, .of_match_table = of_match_ptr(sbsa_uart_of_match), .acpi_match_table = ACPI_PTR(sbsa_uart_acpi_match), + .probe_no_timeout = true, .suppress_bind_attrs = IS_BUILTIN(CONFIG_SERIAL_AMBA_PL011), }, };
drivers/tty/serial/apbuart.c +1 -0
@@ -583,6 +583,7 @@ static struct platform_driver grlib_apbuart_of_driver = { .driver = { .name = "grlib-apbuart", .of_match_table = apbuart_match, + .probe_no_timeout = true, }, };
drivers/tty/serial/ar933x_uart.c +1 -0
@@ -842,6 +842,7 @@ static struct platform_driver ar933x_uart_platform_driver = { .driver = { .name = DRIVER_NAME, .of_match_table = of_match_ptr(ar933x_uart_of_ids), + .probe_no_timeout = true, }, };
drivers/tty/serial/arc_uart.c +1 -0
@@ -650,6 +650,7 @@ static struct platform_driver arc_platform_driver = { .driver = { .name = DRIVER_NAME, .of_match_table = arc_uart_dt_ids, + .probe_no_timeout = true, }, };
drivers/tty/serial/atmel_serial.c +1 -0
@@ -3020,6 +3020,7 @@ static struct platform_driver atmel_serial_driver = { .driver = { .name = "atmel_usart_serial", .of_match_table = of_match_ptr(atmel_serial_dt_ids), + .probe_no_timeout = true, }, };
drivers/tty/serial/bcm63xx_uart.c +1 -0
@@ -890,6 +890,7 @@ static struct platform_driver bcm_uart_platform_driver = { .driver = { .name = "bcm63xx_uart", .of_match_table = bcm63xx_of_match, + .probe_no_timeout = true, }, };
drivers/tty/serial/clps711x.c +1 -0
@@ -528,6 +528,7 @@ static struct platform_driver clps711x_uart_platform = { .driver = { .name = "clps711x-uart", .of_match_table = of_match_ptr(clps711x_uart_dt_ids), + .probe_no_timeout = true, }, .probe = uart_clps711x_probe, .remove = uart_clps711x_remove,
drivers/tty/serial/cpm_uart/cpm_uart_core.c +1 -0
@@ -1470,6 +1470,7 @@ static struct platform_driver cpm_uart_driver = { .driver = { .name = "cpm_uart", .of_match_table = cpm_uart_match, + .probe_no_timeout = true, }, .probe = cpm_uart_probe, .remove = cpm_uart_remove,
drivers/tty/serial/digicolor-usart.c +1 -0
@@ -524,6 +524,7 @@ static struct platform_driver digicolor_uart_platform = { .driver = { .name = "digicolor-usart", .of_match_table = of_match_ptr(digicolor_uart_dt_ids), + .probe_no_timeout = true, }, .probe = digicolor_uart_probe, .remove = digicolor_uart_remove,
drivers/tty/serial/fsl_linflexuart.c +1 -0
@@ -889,6 +889,7 @@ static struct platform_driver linflex_driver = { .driver = { .name = DRIVER_NAME, .of_match_table = linflex_dt_ids, + .probe_no_timeout = true, .pm = &linflex_pm_ops, }, };
drivers/tty/serial/fsl_lpuart.c +1 -0
@@ -2857,6 +2857,7 @@ static struct platform_driver lpuart_driver = { .driver = { .name = "fsl-lpuart", .of_match_table = lpuart_dt_ids, + .probe_no_timeout = true, .pm = &lpuart_pm_ops, }, };
drivers/tty/serial/imx.c +1 -0
@@ -2604,6 +2604,7 @@ static struct platform_driver imx_uart_platform_driver = { .driver = { .name = "imx-uart", .of_match_table = imx_uart_dt_ids, + .probe_no_timeout = true, .pm = &imx_uart_pm_ops, }, };
drivers/tty/serial/lantiq.c +1 -0
@@ -942,6 +942,7 @@ static struct platform_driver lqasc_driver = { .driver = { .name = DRVNAME, .of_match_table = ltq_asc_match, + .probe_no_timeout = true, }, };
drivers/tty/serial/liteuart.c +1 -0
@@ -324,6 +324,7 @@ static struct platform_driver liteuart_platform_driver = { .driver = { .name = "liteuart", .of_match_table = liteuart_of_match, + .probe_no_timeout = true, }, };
drivers/tty/serial/lpc32xx_hs.c +1 -0
@@ -727,6 +727,7 @@ static struct platform_driver serial_hs_lpc32xx_driver = { .driver = { .name = MODNAME, .of_match_table = serial_hs_lpc32xx_dt_ids, + .probe_no_timeout = true, }, };
drivers/tty/serial/max310x.c +1 -0
@@ -1504,6 +1504,7 @@ static struct spi_driver max310x_spi_driver = { .driver = { .name = MAX310X_NAME, .of_match_table = max310x_dt_ids, + .probe_no_timeout = true, .pm = &max310x_pm_ops, }, .probe = max310x_spi_probe,
drivers/tty/serial/meson_uart.c +1 -0
@@ -826,6 +826,7 @@ static struct platform_driver meson_uart_platform_driver = { .driver = { .name = "meson_uart", .of_match_table = meson_uart_dt_match, + .probe_no_timeout = true, }, };
drivers/tty/serial/milbeaut_usio.c +1 -0
@@ -576,6 +576,7 @@ static struct platform_driver mlb_usio_driver = { .driver = { .name = USIO_NAME, .of_match_table = mlb_usio_dt_ids, + .probe_no_timeout = true, }, };
drivers/tty/serial/mpc52xx_uart.c +1 -0
@@ -1885,6 +1885,7 @@ static struct platform_driver mpc52xx_uart_of_driver = { .driver = { .name = "mpc52xx-psc-uart", .of_match_table = mpc52xx_uart_of_match, + .probe_no_timeout = true, }, };
drivers/tty/serial/mps2-uart.c +1 -0
@@ -634,6 +634,7 @@ static struct platform_driver mps2_serial_driver = { .driver = { .name = DRIVER_NAME, .of_match_table = of_match_ptr(mps2_match), + .probe_no_timeout = true, .suppress_bind_attrs = true, }, };
drivers/tty/serial/msm_serial.c +1 -0
@@ -1890,6 +1890,7 @@ static struct platform_driver msm_platform_driver = { .name = "msm_serial", .pm = &msm_serial_dev_pm_ops, .of_match_table = msm_match_table, + .probe_no_timeout = true, }, };
drivers/tty/serial/mvebu-uart.c +1 -0
@@ -1049,6 +1049,7 @@ static struct platform_driver mvebu_uart_platform_driver = { .driver = { .name = "mvebu-uart", .of_match_table = of_match_ptr(mvebu_uart_of_match), + .probe_no_timeout = true, .suppress_bind_attrs = true,#if defined(CONFIG_PM ) .pm = &mvebu_uart_pm_ops,
drivers/tty/serial/mxs-auart.c +1 -0
@@ -1725,6 +1725,7 @@ static struct platform_driver mxs_auart_driver = { .driver = { .name = "mxs-auart", .of_match_table = mxs_auart_dt_ids, + .probe_no_timeout = true, }, };
drivers/tty/serial/omap-serial.c +1 -0
@@ -1834,6 +1834,7 @@ static struct platform_driver serial_omap_driver = { .name = OMAP_SERIAL_DRIVER_NAME, .pm = &serial_omap_dev_pm_ops, .of_match_table = of_match_ptr(omap_serial_of_match), + .probe_no_timeout = true, }, };
drivers/tty/serial/owl-uart.c +1 -0
@@ -766,6 +766,7 @@ static struct platform_driver owl_uart_platform_driver = { .driver = { .name = "owl-uart", .of_match_table = owl_uart_dt_matches, + .probe_no_timeout = true, }, };
drivers/tty/serial/pic32_uart.c +1 -0
@@ -986,6 +986,7 @@ static struct platform_driver pic32_uart_platform_driver = { .driver = { .name = PIC32_DEV_NAME, .of_match_table = of_match_ptr(pic32_serial_dt_ids), + .probe_no_timeout = true, .suppress_bind_attrs = IS_BUILTIN(CONFIG_SERIAL_PIC32), }, };
drivers/tty/serial/pmac_zilog.c +1 -0
@@ -1790,6 +1790,7 @@ static struct macio_driver pmz_driver = { .name = "pmac_zilog", .owner = THIS_MODULE, .of_match_table = pmz_match, + .probe_no_timeout = true, }, .probe = pmz_attach, .remove = pmz_detach,
drivers/tty/serial/pxa.c +1 -0
@@ -910,6 +910,7 @@ static struct platform_driver serial_pxa_driver = {#endif .suppress_bind_attrs = true, .of_match_table = serial_pxa_dt_ids, + .probe_no_timeout = true, }, };
drivers/tty/serial/qcom_geni_serial.c +1 -0
@@ -1541,6 +1541,7 @@ static struct platform_driver qcom_geni_serial_platform_driver = { .driver = { .name = "qcom_geni_serial", .of_match_table = qcom_geni_serial_match_table, + .probe_no_timeout = true, .pm = &qcom_geni_serial_pm_ops, }, };
drivers/tty/serial/rda-uart.c +1 -0
@@ -797,6 +797,7 @@ static struct platform_driver rda_uart_platform_driver = { .driver = { .name = "rda-uart", .of_match_table = rda_uart_dt_matches, + .probe_no_timeout = true, }, };
drivers/tty/serial/samsung_tty.c +1 -0
@@ -2939,6 +2939,7 @@ static struct platform_driver samsung_serial_driver = { .name = "samsung-uart", .pm = SERIAL_SAMSUNG_PM_OPS, .of_match_table = of_match_ptr(s3c24xx_uart_dt_match), + .probe_no_timeout = true, }, };
drivers/tty/serial/sc16is7xx.c +1 -0
@@ -1652,6 +1652,7 @@ static struct spi_driver sc16is7xx_spi_uart_driver = { .driver = { .name = SC16IS7XX_NAME, .of_match_table = sc16is7xx_dt_ids, + .probe_no_timeout = true, }, .probe = sc16is7xx_spi_probe, .remove = sc16is7xx_spi_remove,
drivers/tty/serial/serial-tegra.c +1 -0
@@ -1653,6 +1653,7 @@ static struct platform_driver tegra_uart_platform_driver = { .driver = { .name = "serial-tegra", .of_match_table = tegra_uart_of_match, + .probe_no_timeout = true, .pm = &tegra_uart_pm_ops, }, };
drivers/tty/serial/sh-sci.c +1 -0
@@ -3396,6 +3396,7 @@ static struct platform_driver sci_driver = { .name = "sh-sci", .pm = &sci_dev_pm_ops, .of_match_table = of_match_ptr(of_sci_match), + .probe_no_timeout = true, }, };
drivers/tty/serial/sifive.c +1 -0
@@ -1066,6 +1066,7 @@ static struct platform_driver sifive_serial_platform_driver = { .driver = { .name = SIFIVE_SERIAL_NAME, .of_match_table = of_match_ptr(sifive_serial_of_match), + .probe_no_timeout = true, }, };
drivers/tty/serial/sprd_serial.c +1 -0
@@ -1278,6 +1278,7 @@ static struct platform_driver sprd_platform_driver = { .driver = { .name = "sprd_serial", .of_match_table = of_match_ptr(serial_ids), + .probe_no_timeout = true, .pm = &sprd_pm_ops, }, };
drivers/tty/serial/st-asc.c +1 -0
@@ -973,6 +973,7 @@ static struct platform_driver asc_serial_driver = { .name = DRIVER_NAME, .pm = &asc_serial_pm_ops, .of_match_table = of_match_ptr(asc_match), + .probe_no_timeout = true, }, };
drivers/tty/serial/stm32-usart.c +1 -0
@@ -2019,6 +2019,7 @@ static struct platform_driver stm32_serial_driver = { .name = DRIVER_NAME, .pm = &stm32_serial_pm_ops, .of_match_table = of_match_ptr(stm32_match), + .probe_no_timeout = true, }, };
drivers/tty/serial/sunhv.c +1 -0
@@ -630,6 +630,7 @@ static struct platform_driver hv_driver = { .driver = { .name = "hv", .of_match_table = hv_match, + .probe_no_timeout = true, }, .probe = hv_probe, .remove = hv_remove,
drivers/tty/serial/sunplus-uart.c +1 -0
@@ -709,6 +709,7 @@ static struct platform_driver sunplus_uart_platform_driver = { .driver = { .name = "sunplus_uart", .of_match_table = sp_uart_of_match, + .probe_no_timeout = true, .pm = &sunplus_uart_pm_ops, } };
drivers/tty/serial/sunsab.c +1 -0
@@ -1103,6 +1103,7 @@ static struct platform_driver sab_driver = { .driver = { .name = "sab", .of_match_table = sab_match, + .probe_no_timeout = true, }, .probe = sab_probe, .remove = sab_remove,
drivers/tty/serial/sunsu.c +1 -0
@@ -1566,6 +1566,7 @@ static struct platform_driver su_driver = { .driver = { .name = "su", .of_match_table = su_match, + .probe_no_timeout = true, }, .probe = su_probe, .remove = su_remove,
drivers/tty/serial/sunzilog.c +1 -0
@@ -1541,6 +1541,7 @@ static struct platform_driver zs_driver = { .driver = { .name = "zs", .of_match_table = zs_match, + .probe_no_timeout = true, }, .probe = zs_probe, .remove = zs_remove,
drivers/tty/serial/tegra-tcu.c +1 -0
@@ -292,6 +292,7 @@ static struct platform_driver tegra_tcu_driver = { .driver = { .name = "tegra-tcu", .of_match_table = tegra_tcu_match, + .probe_no_timeout = true, }, .probe = tegra_tcu_probe, .remove = tegra_tcu_remove,
drivers/tty/serial/uartlite.c +1 -0
@@ -919,6 +919,7 @@ static struct platform_driver ulite_platform_driver = { .driver = { .name = "uartlite", .of_match_table = of_match_ptr(ulite_of_match), + .probe_no_timeout = true, .pm = &ulite_pm_ops, }, };
drivers/tty/serial/ucc_uart.c +1 -0
@@ -1500,6 +1500,7 @@ static struct platform_driver ucc_uart_of_driver = { .driver = { .name = "ucc_uart", .of_match_table = ucc_uart_match, + .probe_no_timeout = true, }, .probe = ucc_uart_probe, .remove = ucc_uart_remove,
drivers/tty/serial/vt8500_serial.c +1 -0
@@ -722,6 +722,7 @@ static struct platform_driver vt8500_platform_driver = { .driver = { .name = "vt8500_serial", .of_match_table = wmt_dt_ids, + .probe_no_timeout = true, .suppress_bind_attrs = true, }, };
drivers/tty/serial/xilinx_uartps.c +1 -0
@@ -1656,6 +1656,7 @@ static struct platform_driver cdns_uart_platform_driver = { .driver = { .name = CDNS_UART_NAME, .of_match_table = cdns_uart_of_match, + .probe_no_timeout = true, .pm = &cdns_uart_dev_pm_ops, .suppress_bind_attrs = IS_BUILTIN(CONFIG_SERIAL_XILINX_PS_UART), },
Signature · 1 line
2.37.0.rc0.161.g10f37bed90-goog
Re: [PATCH v2 2/2] serial: Set probe_no_timeout for all DT based drivers
Quoted 7 lines · Saravana Kannan
With commit
71066545b48e("driver core: Set fw_devlink.strict=1 by default") the probing of TTY consoles could get delayed if they have optional suppliers that are listed in DT, but those suppliers don't probe by the time kernel boot finishes. The console devices will probe eventually afterdriver_probe_timeoutexpires.
Quoted 5 lines
However, since consoles are often used for debugging kernel issues, it does not make sense to delay their probe. So, set the newly added
probe_no_timeoutflag for all serial drivers that at DT based. This way,fw_devlinkwill know not to delay the probing of the consoles past kernel boot.
Same question, do you think only serial drivers need that?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Greg Kroah-Hartman
maintainerQuoted 5 lines · Saravana Kannan
These patches are on top of driver-core-next.
Even if stdout-path isn't set in DT, this patch should take console probe times back to how they were before the
deferred_probe_timeoutclean up series[1].
Now dropped from my queue due to lack of a response to other reviewer's questions.
thanks,
greg k-h
Quoted 10 lines · Greg Kroah-Hartman
Quoted 5 lines · Saravana Kannan
These patches are on top of driver-core-next.
Even if stdout-path isn't set in DT, this patch should take console probe times back to how they were before the
deferred_probe_timeoutclean up series[1].Now dropped from my queue due to lack of a response to other reviewer's questions.
Sorry, I somehow missed those emails. I'll respond later today/tomorrow.
-Saravana
Quoted 10 lines · Greg Kroah-Hartman
Quoted 5 lines · Saravana Kannan
These patches are on top of driver-core-next.
Even if stdout-path isn't set in DT, this patch should take console probe times back to how they were before the
deferred_probe_timeoutclean up series[1].Now dropped from my queue due to lack of a response to other reviewer's questions.
What happened to this patch? I have a 10 second timeout on console probe on my SiFive Unmatched, and I don't see this flag being set for the serial driver. In fact, I don't see it anywhere in-tree. I can't seem to locate another patchset from Saravana around this though, so I'm not sure where to look for a missing piece for the sifive serial driver.
This is the second boot time regression (this one not fatal, unlike the Layerscape PCIe one) from the fw_devlink patchset.
Greg, can you revert the whole set for 6.0, please? It's obviously nowhere near tested enough to go in and I expect we'll see a bunch of -stable fixups due to this if we let it remain in.
This seems to be one of the worst releases I've encountered in recent years on my hardware here due to this patchset. :-(
-Olof
Greg Kroah-Hartman
maintainerQuoted 20 lines · Olof Johansson
Quoted 10 lines · Greg Kroah-Hartman
Quoted 5 lines · Saravana Kannan
These patches are on top of driver-core-next.
Even if stdout-path isn't set in DT, this patch should take console probe times back to how they were before the
deferred_probe_timeoutclean up series[1].Now dropped from my queue due to lack of a response to other reviewer's questions.
What happened to this patch? I have a 10 second timeout on console probe on my SiFive Unmatched, and I don't see this flag being set for the serial driver. In fact, I don't see it anywhere in-tree. I can't seem to locate another patchset from Saravana around this though, so I'm not sure where to look for a missing piece for the sifive serial driver.
Quoted 6 lines
This is the second boot time regression (this one not fatal, unlike the Layerscape PCIe one) from the
fw_devlinkpatchset.Greg, can you revert the whole set for 6.0, please? It's obviously nowhere near tested enough to go in and I expect we'll see a bunch of -stable fixups due to this if we let it remain in.
What exactly is "the whole set"? I have the default option fix queued up and will send that to Linus later this week (am traveling back from Plumbers still), but have not heard any problems about any other issues at all other than your report.
thnaks,
greg k-h
Quoted 25 lines · Greg Kroah-Hartman
Quoted 23 lines · Olof Johansson
Quoted 10 lines · Greg Kroah-Hartman
Quoted 5 lines · Saravana Kannan
These patches are on top of driver-core-next.
Even if stdout-path isn't set in DT, this patch should take console probe times back to how they were before the
deferred_probe_timeoutclean up series[1].Now dropped from my queue due to lack of a response to other reviewer's questions.
What happened to this patch? I have a 10 second timeout on console probe on my SiFive Unmatched, and I don't see this flag being set for the serial driver. In fact, I don't see it anywhere in-tree. I can't seem to locate another patchset from Saravana around this though, so I'm not sure where to look for a missing piece for the sifive serial driver.
This is the second boot time regression (this one not fatal, unlike the Layerscape PCIe one) from the
fw_devlinkpatchset.
Quoted 8 lines
Quoted 3 lines
Greg, can you revert the whole set for 6.0, please? It's obviously nowhere near tested enough to go in and I expect we'll see a bunch of -stable fixups due to this if we let it remain in.
What exactly is "the whole set"? I have the default option fix queued up and will send that to Linus later this week (am traveling back from Plumbers still), but have not heard any problems about any other issues at all other than your report.
I stand corrected in this case, the issue on the Hifive Unmatched was a regression due to a PWM clock change -- I just sent a patch for that (serial driver fix).
So it seems like as long as the fw_devlink.strict=1 patch is reverted, things are back to a working state here.
I still struggle with how the fw_devlink patchset is expected to work though, since DT is expected to describe the hardware configuration, and it has no knowledge of whether there are drivers that will be bound to any referenced supplier devnodes. It's not going to work well to assume that they will always be bound, and to add 10 second timeouts for those cases isn't a good solution. Seems like the number of special cases will keep adding up.
The whole design feels like it's falling short, and it's been patched here and there to deal with the shortcomings, instead of revisiting the full solution. (The patches are the console one, and another to deal with nfsroot boots).
As long as it doesn't keep regressing others, I suppose the work to redesign it can happen in-tree, but it's not usually how we try to do it for new functionality. Especially since it's still being iterated on (with active patch sets posted around -rc1 for improvements).
Oh, and one more thing for the future -- the main patch that changes behavior due to dependency tracking is 2f8c3ae8288e, named "driver
core: Add wait_for_init_devices_probe helper function". It's easy to overlook this when looking at a list of patches since it's said to just introduce a helper.
-Olof
Quoted 44 lines · Olof Johansson
Quoted 25 lines · Greg Kroah-Hartman
Quoted 23 lines · Olof Johansson
Quoted 10 lines · Greg Kroah-Hartman
Quoted 5 lines · Saravana Kannan
These patches are on top of driver-core-next.
Even if stdout-path isn't set in DT, this patch should take console probe times back to how they were before the
deferred_probe_timeoutclean up series[1].Now dropped from my queue due to lack of a response to other reviewer's questions.
What happened to this patch? I have a 10 second timeout on console probe on my SiFive Unmatched, and I don't see this flag being set for the serial driver. In fact, I don't see it anywhere in-tree. I can't seem to locate another patchset from Saravana around this though, so I'm not sure where to look for a missing piece for the sifive serial driver.
This is the second boot time regression (this one not fatal, unlike the Layerscape PCIe one) from the
fw_devlinkpatchset.Quoted 8 lines
Quoted 3 lines
Greg, can you revert the whole set for 6.0, please? It's obviously nowhere near tested enough to go in and I expect we'll see a bunch of -stable fixups due to this if we let it remain in.
What exactly is "the whole set"? I have the default option fix queued up and will send that to Linus later this week (am traveling back from Plumbers still), but have not heard any problems about any other issues at all other than your report.
I stand corrected in this case, the issue on the Hifive Unmatched was a regression due to a PWM clock change -- I just sent a patch for that (serial driver fix).
So it seems like as long as the fw_devlink.strict=1 patch is reverted, things are back to a working state here.
Quoted 7 lines
I still struggle with how the
fw_devlinkpatchset is expected to work though, since DT is expected to describe the hardware configuration, and it has no knowledge of whether there are drivers that will be bound to any referenced supplier devnodes. It's not going to work well to assume that they will always be bound, and to add 10 second timeouts for those cases isn't a good solution. Seems like the number of special cases will keep adding up.
Since the introduction of deferred probe, the kernel has always assumed if there is a device described, then there is or will be a driver for it. The result is you can't use new DTs (if they add providers) with older kernels.
We've ended up with a timeout because no one has come up with a better way to handle it. What the kernel needs is userspace saying "I'm done loading modules", but it's debatable whether that's a good solution too.
Rob
Andy Shevchenko
reviewerQuoted 58 lines · Rob Herring
Quoted 44 lines · Olof Johansson
Quoted 25 lines · Greg Kroah-Hartman
Quoted 23 lines · Olof Johansson
Quoted 10 lines · Greg Kroah-Hartman
Quoted 5 lines · Saravana Kannan
These patches are on top of driver-core-next.
Even if stdout-path isn't set in DT, this patch should take console probe times back to how they were before the
deferred_probe_timeoutclean up series[1].Now dropped from my queue due to lack of a response to other reviewer's questions.
What happened to this patch? I have a 10 second timeout on console probe on my SiFive Unmatched, and I don't see this flag being set for the serial driver. In fact, I don't see it anywhere in-tree. I can't seem to locate another patchset from Saravana around this though, so I'm not sure where to look for a missing piece for the sifive serial driver.
This is the second boot time regression (this one not fatal, unlike the Layerscape PCIe one) from the
fw_devlinkpatchset.Quoted 8 lines
Quoted 3 lines
Greg, can you revert the whole set for 6.0, please? It's obviously nowhere near tested enough to go in and I expect we'll see a bunch of -stable fixups due to this if we let it remain in.
What exactly is "the whole set"? I have the default option fix queued up and will send that to Linus later this week (am traveling back from Plumbers still), but have not heard any problems about any other issues at all other than your report.
I stand corrected in this case, the issue on the Hifive Unmatched was a regression due to a PWM clock change -- I just sent a patch for that (serial driver fix).
So it seems like as long as the fw_devlink.strict=1 patch is reverted, things are back to a working state here.
Quoted 7 lines
I still struggle with how the
fw_devlinkpatchset is expected to work though, since DT is expected to describe the hardware configuration, and it has no knowledge of whether there are drivers that will be bound to any referenced supplier devnodes. It's not going to work well to assume that they will always be bound, and to add 10 second timeouts for those cases isn't a good solution. Seems like the number of special cases will keep adding up.Since the introduction of deferred probe, the kernel has always assumed if there is a device described, then there is or will be a driver for it. The result is you can't use new DTs (if they add providers) with older kernels.
Quoted 4 lines
We've ended up with a timeout because no one has come up with a better way to handle it. What the kernel needs is userspace saying "I'm done loading modules", but it's debatable whether that's a good solution too.
In my opinion the deferred probe is a big hack and that is the root cause of the issues we have here and there. It has to be redesigned to be mathematically robust. It was an attempt by Andrzej Hajda to solve this [1].
Signature · 9 lines
With Best Regards, Andy Shevchenko _______________________________________________ linux-snps-arc mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Greg Kroah-Hartman
maintainerQuoted 64 lines · Andy Shevchenko
Quoted 58 lines · Rob Herring
Quoted 44 lines · Olof Johansson
Quoted 25 lines · Greg Kroah-Hartman
Quoted 23 lines · Olof Johansson
Quoted 10 lines · Greg Kroah-Hartman
Quoted 5 lines · Saravana Kannan
These patches are on top of driver-core-next.
Even if stdout-path isn't set in DT, this patch should take console probe times back to how they were before the
deferred_probe_timeoutclean up series[1].Now dropped from my queue due to lack of a response to other reviewer's questions.
What happened to this patch? I have a 10 second timeout on console probe on my SiFive Unmatched, and I don't see this flag being set for the serial driver. In fact, I don't see it anywhere in-tree. I can't seem to locate another patchset from Saravana around this though, so I'm not sure where to look for a missing piece for the sifive serial driver.
This is the second boot time regression (this one not fatal, unlike the Layerscape PCIe one) from the
fw_devlinkpatchset.Quoted 8 lines
Quoted 3 lines
Greg, can you revert the whole set for 6.0, please? It's obviously nowhere near tested enough to go in and I expect we'll see a bunch of -stable fixups due to this if we let it remain in.
What exactly is "the whole set"? I have the default option fix queued up and will send that to Linus later this week (am traveling back from Plumbers still), but have not heard any problems about any other issues at all other than your report.
I stand corrected in this case, the issue on the Hifive Unmatched was a regression due to a PWM clock change -- I just sent a patch for that (serial driver fix).
So it seems like as long as the fw_devlink.strict=1 patch is reverted, things are back to a working state here.
Quoted 7 lines
I still struggle with how the
fw_devlinkpatchset is expected to work though, since DT is expected to describe the hardware configuration, and it has no knowledge of whether there are drivers that will be bound to any referenced supplier devnodes. It's not going to work well to assume that they will always be bound, and to add 10 second timeouts for those cases isn't a good solution. Seems like the number of special cases will keep adding up.Since the introduction of deferred probe, the kernel has always assumed if there is a device described, then there is or will be a driver for it. The result is you can't use new DTs (if they add providers) with older kernels.
Quoted 4 lines
We've ended up with a timeout because no one has come up with a better way to handle it. What the kernel needs is userspace saying "I'm done loading modules", but it's debatable whether that's a good solution too.
Quoted 6 lines
In my opinion the deferred probe is a big hack and that is the root cause of the issues we have here and there. It has to be redesigned to be mathematically robust. It was an attempt by Andrzej Hajda to solve this [1].
deferred probe has _ALWAYS_ been known to be a hack, way back when we accepted it, but it was the best hack we had to solve a real problem that we had, so it was accepted.
It's been polished over the years, but yes, it does break down at times, due to the crazy complexity of hardware systems that we have no control over.
If you have concrete solutions for how to solve the issue, wonderful, please submit patches :)
thanks,
greg k-h