iommu/virtio: Do not dereference fwnode in struct device
Subsystems (3)
PATCH 1/1 iommu/virtio: Do not dereference fwnode in struct device
In order to make the underneath API easier to change in the future, prevent users from dereferencing fwnode from struct device. Instead, use the specific device_match_fwnode() API for that.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/iommu/virtio-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/virtio-iommu.c +1 -1
@@ -925,7 +925,7 @@ static struct virtio_driver virtio_iommu_drv;static int viommu_match_node (struct device *dev,const void *data) { -return dev->parent->fwnode == data; +return device_match_fwnode (dev->parent, data); }static struct viommu_dev *viommu_get_by_fwnode (struct fwnode_handle *fwnode)
Signature · 1 line
2.35.1
Quoted 5 lines · Andy Shevchenko
In order to make the underneath API easier to change in the future, prevent users from dereferencing fwnode from struct device. Instead, use the specific
device_match_fwnode()API for that.Signed-off-by Andy Shevchenko <[email protected]>
Reviewed-by Jean-Philippe Brucker <[email protected]>
Quoted 20 lines
--- drivers/iommu/virtio-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iommu/virtio-iommu.c +1
-1@@ -925,7 +925,7 @@ static struct virtio_driver virtio_iommu_drv;static int viommu_match_node (struct device *dev,const void *data) { -return dev->parent->fwnode == data; +return device_match_fwnode (dev->parent, data); }static struct viommu_dev *viommu_get_by_fwnode (struct fwnode_handle *fwnode)Signature · 1 line
2.35.1
Quoted 6 lines · Jean-Philippe Brucker
Quoted 3 lines · Andy Shevchenko
In order to make the underneath API easier to change in the future, prevent users from dereferencing fwnode from struct device. Instead, use the specific
device_match_fwnode()API for that.Reviewed-by Jean-Philippe Brucker <[email protected]>
Thanks!
Can it be applied now?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 2 lines · Andy Shevchenko
drivers/iommu/virtio-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.