Skip to contentSkip to conversation

syscalls/signal06: loop being clobbered by syscall on clang

PATCH In review Edward Liaw via ltp 2 participants 2 messages Aug 19, 2022 – Aug 24, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 syscalls/signal06: loop being clobbered by syscall on clang

Indicate to the compiler that the syscall will modify registers rcx and r11 to prevent loop from getting clobbered.

---
I added an output operand for the result so that the compiler would know that rax is clobbered as well.

---
 testcases/kernel/syscalls/signal/signal06.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
testcases/kernel/syscalls/signal/signal06.c +2 -2
index 64f886ee3..cf0706ea4 100644
@@ -72,8 +72,8 @@ void test(void)
 	while (D == VALUE && loop < LOOPS) {
 		/* sys_tkill(pid, SIGHUP); asm to avoid save/reload
 		 * fp regs around c call */
-		asm ("" : : "a"(__NR_tkill), "D"(pid), "S"(SIGHUP));
-		asm ("syscall" : : : "ax");
+		int unused;
+		asm volatile ("syscall" : "=a"(unused) : "a"(__NR_tkill), "D"(pid), "S"(SIGHUP) : "rcx", "r11");
 
 		loop++;
 	}
Signature · 5 lines
2.37.2.609.g9ff673ca1a-goog


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp