Skip to contentSkip to conversation

counter: Move symbols into COUNTER namespace

PATCH Applied William Breathitt Gray 3 participants 4 messages Aug 15, 2022 – Aug 25, 2022

Subsystems (10)
IIO Arm STM32 Counter STM32 timer/lptimer drivers +6 more subsystems
lore
Share & tools
lore

William Breathitt Gray

author
#0 lore raw

PATCH 1/1 counter: Move symbols into COUNTER namespace

Counter subsystem symbols are only relevant to counter drivers. A COUNTER namespace is created to control the availability of these symbols to modules that import this namespace explicitly.

Cc Patrick Havelange <[email protected]>
Cc Jarkko Nikula <[email protected]>
Cc Oleksij Rempel <[email protected]>
Cc Pengutronix Kernel Team <[email protected]>
Cc Kamel Bouhara <[email protected]>
Cc Fabrice Gasnier <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc David Lechner <[email protected]>
Signed-off-by William Breathitt Gray <[email protected]>
---
 drivers/counter/104-quad-8.c            |  1 +
 drivers/counter/counter-chrdev.c        |  2 +-
 drivers/counter/counter-core.c          | 14 +++++++-------
 drivers/counter/ftm-quaddec.c           |  1 +
 drivers/counter/intel-qep.c             |  1 +
 drivers/counter/interrupt-cnt.c         |  1 +
 drivers/counter/microchip-tcb-capture.c |  1 +
 drivers/counter/stm32-lptimer-cnt.c     |  1 +
 drivers/counter/stm32-timer-cnt.c       |  1 +
 drivers/counter/ti-eqep.c               |  1 +
 10 files changed, 16 insertions(+), 8 deletions(-)
drivers/counter/104-quad-8.c +1 -0
index 62c2b7ac4339..1323edfbe40c 100644
@@ -1241,3 +1241,4 @@ module_isa_driver(quad8_driver, num_quad8);
 MODULE_AUTHOR("William Breathitt Gray <[email protected]>");
 MODULE_DESCRIPTION("ACCES 104-QUAD-8 driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/counter-chrdev.c +1 -1
index 69d340be9c93..4e71a19d7e6a 100644
@@ -574,4 +574,4 @@ void counter_push_event(struct counter_device *const counter, const u8 event,
 	if (copied)
 		wake_up_poll(&counter->events_wait, EPOLLIN);
 }
-EXPORT_SYMBOL_GPL(counter_push_event);
+EXPORT_SYMBOL_NS_GPL(counter_push_event, COUNTER);
drivers/counter/counter-core.c +7 -7
index 938651f9e9e0..09c77afb33ca 100644
@@ -73,7 +73,7 @@ void *counter_priv(const struct counter_device *const counter)
 
 	return &ch->privdata;
 }
-EXPORT_SYMBOL_GPL(counter_priv);
+EXPORT_SYMBOL_NS_GPL(counter_priv, COUNTER);
 
 /**
  * counter_alloc - allocate a counter_device

@@ -133,13 +133,13 @@ struct counter_device *counter_alloc(size_t sizeof_priv)
 
 	return NULL;
 }
-EXPORT_SYMBOL_GPL(counter_alloc);
+EXPORT_SYMBOL_NS_GPL(counter_alloc, COUNTER);
 
 void counter_put(struct counter_device *counter)
 {
 	put_device(&counter->dev);
 }
-EXPORT_SYMBOL_GPL(counter_put);
+EXPORT_SYMBOL_NS_GPL(counter_put, COUNTER);
 
 /**
  * counter_add - complete registration of a counter

@@ -166,7 +166,7 @@ int counter_add(struct counter_device *counter)
 	/* implies device_add(dev) */
 	return cdev_device_add(&counter->chrdev, dev);
 }
-EXPORT_SYMBOL_GPL(counter_add);
+EXPORT_SYMBOL_NS_GPL(counter_add, COUNTER);
 
 /**
  * counter_unregister - unregister Counter from the system

@@ -188,7 +188,7 @@ void counter_unregister(struct counter_device *const counter)
 
 	mutex_unlock(&counter->ops_exist_lock);
 }
-EXPORT_SYMBOL_GPL(counter_unregister);
+EXPORT_SYMBOL_NS_GPL(counter_unregister, COUNTER);
 
 static void devm_counter_release(void *counter)
 {

@@ -223,7 +223,7 @@ struct counter_device *devm_counter_alloc(struct device *dev, size_t sizeof_priv
 
 	return counter;
 }
-EXPORT_SYMBOL_GPL(devm_counter_alloc);
+EXPORT_SYMBOL_NS_GPL(devm_counter_alloc, COUNTER);
 
 /**
  * devm_counter_add - complete registration of a counter

@@ -244,7 +244,7 @@ int devm_counter_add(struct device *dev,
 
 	return devm_add_action_or_reset(dev, devm_counter_release, counter);
 }
-EXPORT_SYMBOL_GPL(devm_counter_add);
+EXPORT_SYMBOL_NS_GPL(devm_counter_add, COUNTER);
 
 #define COUNTER_DEV_MAX 256
drivers/counter/ftm-quaddec.c +1 -0
index 2a58582a9df4..aea6622a9b13 100644
@@ -325,3 +325,4 @@ module_platform_driver(ftm_quaddec_driver);
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Kjeld Flarup <[email protected]>");
 MODULE_AUTHOR("Patrick Havelange <[email protected]>");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/intel-qep.c +1 -0
index 47a6a9dfc9e8..af5942e66f7d 100644
@@ -523,3 +523,4 @@ MODULE_AUTHOR("Jarkko Nikula <[email protected]>");
 MODULE_AUTHOR("Raymond Tan <[email protected]>");
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("Intel Quadrature Encoder Peripheral driver");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/interrupt-cnt.c +1 -0
index 3b13f56bbb11..5a11b65fc0e5 100644
@@ -242,3 +242,4 @@ MODULE_ALIAS("platform:interrupt-counter");
 MODULE_AUTHOR("Oleksij Rempel <[email protected]>");
 MODULE_DESCRIPTION("Interrupt counter driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/microchip-tcb-capture.c +1 -0
index 00844445143b..f9dee15d9777 100644
@@ -394,3 +394,4 @@ module_platform_driver(mchp_tc_driver);
 MODULE_AUTHOR("Kamel Bouhara <[email protected]>");
 MODULE_DESCRIPTION("Microchip TCB Capture driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/stm32-lptimer-cnt.c +1 -0
index 68031d93ce89..d6b80b6dfc28 100644
@@ -520,3 +520,4 @@ MODULE_AUTHOR("Fabrice Gasnier <[email protected]>");
 MODULE_ALIAS("platform:stm32-lptimer-counter");
 MODULE_DESCRIPTION("STMicroelectronics STM32 LPTIM counter driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/stm32-timer-cnt.c +1 -0
index 5779ae7c73cf..9bf20a5d6bda 100644
@@ -417,3 +417,4 @@ MODULE_AUTHOR("Benjamin Gaignard <[email protected]>");
 MODULE_ALIAS("platform:stm32-timer-counter");
 MODULE_DESCRIPTION("STMicroelectronics STM32 TIMER counter driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/ti-eqep.c +1 -0
index 0489d26eb47c..b0f24cf3e891 100644
@@ -456,3 +456,4 @@ module_platform_driver(ti_eqep_driver);
 MODULE_AUTHOR("David Lechner <[email protected]>");
 MODULE_DESCRIPTION("TI eQEP counter driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(COUNTER);

base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868

Signature · 7 lines
2.37.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · William Breathitt Gray

Counter subsystem symbols are only relevant to counter drivers. A COUNTER namespace is created to control the availability of these symbols to modules that import this namespace explicitly.
---

Acked-by David Lechner <[email protected]>

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to William Breathitt Gray
Quoted 4 lines · On Mon, 15 Aug 2022 18:03:21 -0400 William Breathitt Gray…

Counter subsystem symbols are only relevant to counter drivers. A COUNTER namespace is created to control the availability of these symbols to modules that import this namespace explicitly.

Quoted 10 lines
Cc Patrick Havelange <[email protected]>
Cc Jarkko Nikula <[email protected]>
Cc Oleksij Rempel <[email protected]>
Cc Pengutronix Kernel Team <[email protected]>
Cc Kamel Bouhara <[email protected]>
Cc Fabrice Gasnier <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc David Lechner <[email protected]>
Signed-off-by William Breathitt Gray <[email protected]>

I'm kind of amazed the interface is this small :)

Definitely a good thing to do. Sometime soon I'll finish doing equivalent for IIO.

Reviewed-by Jonathan Cameron <[email protected]>
Quoted 162 lines
---
 drivers/counter/104-quad-8.c            |  1 +
 drivers/counter/counter-chrdev.c        |  2 +-
 drivers/counter/counter-core.c          | 14 +++++++-------
 drivers/counter/ftm-quaddec.c           |  1 +
 drivers/counter/intel-qep.c             |  1 +
 drivers/counter/interrupt-cnt.c         |  1 +
 drivers/counter/microchip-tcb-capture.c |  1 +
 drivers/counter/stm32-lptimer-cnt.c     |  1 +
 drivers/counter/stm32-timer-cnt.c       |  1 +
 drivers/counter/ti-eqep.c               |  1 +
 10 files changed, 16 insertions(+), 8 deletions(-)
drivers/counter/104-quad-8.c +1 -0
index 62c2b7ac4339..1323edfbe40c 100644
@@ -1241,3 +1241,4 @@ module_isa_driver(quad8_driver, num_quad8);
 MODULE_AUTHOR("William Breathitt Gray <[email protected]>");
 MODULE_DESCRIPTION("ACCES 104-QUAD-8 driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/counter-chrdev.c +1 -1
index 69d340be9c93..4e71a19d7e6a 100644
@@ -574,4 +574,4 @@ void counter_push_event(struct counter_device *const counter, const u8 event,
 	if (copied)
 		wake_up_poll(&counter->events_wait, EPOLLIN);
 }
-EXPORT_SYMBOL_GPL(counter_push_event);
+EXPORT_SYMBOL_NS_GPL(counter_push_event, COUNTER);
drivers/counter/counter-core.c +7 -7
index 938651f9e9e0..09c77afb33ca 100644
@@ -73,7 +73,7 @@ void *counter_priv(const struct counter_device *const counter)
 
 	return &ch->privdata;
 }
-EXPORT_SYMBOL_GPL(counter_priv);
+EXPORT_SYMBOL_NS_GPL(counter_priv, COUNTER);
 
 /**
  * counter_alloc - allocate a counter_device

@@ -133,13 +133,13 @@ struct counter_device *counter_alloc(size_t sizeof_priv)
 
 	return NULL;
 }
-EXPORT_SYMBOL_GPL(counter_alloc);
+EXPORT_SYMBOL_NS_GPL(counter_alloc, COUNTER);
 
 void counter_put(struct counter_device *counter)
 {
 	put_device(&counter->dev);
 }
-EXPORT_SYMBOL_GPL(counter_put);
+EXPORT_SYMBOL_NS_GPL(counter_put, COUNTER);
 
 /**
  * counter_add - complete registration of a counter

@@ -166,7 +166,7 @@ int counter_add(struct counter_device *counter)
 	/* implies device_add(dev) */
 	return cdev_device_add(&counter->chrdev, dev);
 }
-EXPORT_SYMBOL_GPL(counter_add);
+EXPORT_SYMBOL_NS_GPL(counter_add, COUNTER);
 
 /**
  * counter_unregister - unregister Counter from the system

@@ -188,7 +188,7 @@ void counter_unregister(struct counter_device *const counter)
 
 	mutex_unlock(&counter->ops_exist_lock);
 }
-EXPORT_SYMBOL_GPL(counter_unregister);
+EXPORT_SYMBOL_NS_GPL(counter_unregister, COUNTER);
 
 static void devm_counter_release(void *counter)
 {

@@ -223,7 +223,7 @@ struct counter_device *devm_counter_alloc(struct device *dev, size_t sizeof_priv
 
 	return counter;
 }
-EXPORT_SYMBOL_GPL(devm_counter_alloc);
+EXPORT_SYMBOL_NS_GPL(devm_counter_alloc, COUNTER);
 
 /**
  * devm_counter_add - complete registration of a counter

@@ -244,7 +244,7 @@ int devm_counter_add(struct device *dev,
 
 	return devm_add_action_or_reset(dev, devm_counter_release, counter);
 }
-EXPORT_SYMBOL_GPL(devm_counter_add);
+EXPORT_SYMBOL_NS_GPL(devm_counter_add, COUNTER);
 
 #define COUNTER_DEV_MAX 256
drivers/counter/ftm-quaddec.c +1 -0
index 2a58582a9df4..aea6622a9b13 100644
@@ -325,3 +325,4 @@ module_platform_driver(ftm_quaddec_driver);
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Kjeld Flarup <[email protected]>");
 MODULE_AUTHOR("Patrick Havelange <[email protected]>");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/intel-qep.c +1 -0
index 47a6a9dfc9e8..af5942e66f7d 100644
@@ -523,3 +523,4 @@ MODULE_AUTHOR("Jarkko Nikula <[email protected]>");
 MODULE_AUTHOR("Raymond Tan <[email protected]>");
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("Intel Quadrature Encoder Peripheral driver");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/interrupt-cnt.c +1 -0
index 3b13f56bbb11..5a11b65fc0e5 100644
@@ -242,3 +242,4 @@ MODULE_ALIAS("platform:interrupt-counter");
 MODULE_AUTHOR("Oleksij Rempel <[email protected]>");
 MODULE_DESCRIPTION("Interrupt counter driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/microchip-tcb-capture.c +1 -0
index 00844445143b..f9dee15d9777 100644
@@ -394,3 +394,4 @@ module_platform_driver(mchp_tc_driver);
 MODULE_AUTHOR("Kamel Bouhara <[email protected]>");
 MODULE_DESCRIPTION("Microchip TCB Capture driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/stm32-lptimer-cnt.c +1 -0
index 68031d93ce89..d6b80b6dfc28 100644
@@ -520,3 +520,4 @@ MODULE_AUTHOR("Fabrice Gasnier <[email protected]>");
 MODULE_ALIAS("platform:stm32-lptimer-counter");
 MODULE_DESCRIPTION("STMicroelectronics STM32 LPTIM counter driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/stm32-timer-cnt.c +1 -0
index 5779ae7c73cf..9bf20a5d6bda 100644
@@ -417,3 +417,4 @@ MODULE_AUTHOR("Benjamin Gaignard <[email protected]>");
 MODULE_ALIAS("platform:stm32-timer-counter");
 MODULE_DESCRIPTION("STMicroelectronics STM32 TIMER counter driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(COUNTER);
drivers/counter/ti-eqep.c +1 -0
index 0489d26eb47c..b0f24cf3e891 100644
@@ -456,3 +456,4 @@ module_platform_driver(ti_eqep_driver);
 MODULE_AUTHOR("David Lechner <[email protected]>");
 MODULE_DESCRIPTION("TI eQEP counter driver");
 MODULE_LICENSE("GPL v2");
+MODULE_IMPORT_NS(COUNTER);

base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868

author Applied
#3 lore raw
In reply to William Breathitt Gray
Quoted 4 lines · William Breathitt Gray

Counter subsystem symbols are only relevant to counter drivers. A COUNTER namespace is created to control the availability of these symbols to modules that import this namespace explicitly.

Quoted 10 lines
Cc Patrick Havelange <[email protected]>
Cc Jarkko Nikula <[email protected]>
Cc Oleksij Rempel <[email protected]>
Cc Pengutronix Kernel Team <[email protected]>
Cc Kamel Bouhara <[email protected]>
Cc Fabrice Gasnier <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc David Lechner <[email protected]>
Signed-off-by William Breathitt Gray <[email protected]>

Applied to counter-next branch.

William Breathitt Gray

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel