Skip to contentSkip to conversation

usb: dwc3: disable USB core PHY management

PATCH In review Johan Hovold 2 participants 2 messages Aug 25, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: dwc3: disable USB core PHY management

The dwc3 driver manages its PHYs itself so the USB core PHY management needs to be disabled.

Use the struct xhci_plat_priv hack added by commits 46034a999c07 ("usb:
host: xhci-plat: add platform data support") and f768e718911e ("usb:
host: xhci-plat: add priv quirk for skip PHY initialization") to propagate the setting for now.

Fixes 4e88d4c08301 ("usb: add a flag to skip PHY initialization to struct usb_hcd")
Fixes 178a0bce05cb ("usb: core: hcd: integrate the PHY wrapper into the HCD core")
---
 drivers/usb/dwc3/host.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/usb/dwc3/host.c +10 -0
index f6f13e7f1ba1..a7154fe8206d 100644
@@ -11,8 +11,13 @@
 #include <linux/of.h>
 #include <linux/platform_device.h>
 
+#include "../host/xhci-plat.h"
 #include "core.h"
 
+static const struct xhci_plat_priv dwc3_xhci_plat_priv = {
+	.quirks = XHCI_SKIP_PHY_INIT,
+};
+
 static void dwc3_host_fill_xhci_irq_res(struct dwc3 *dwc,
 					int irq, char *name)
 {
@@ -92,6 +97,11 @@ int dwc3_host_init(struct dwc3 *dwc)
 		goto err;
 	}
 
+	ret = platform_device_add_data(xhci, &dwc3_xhci_plat_priv,
+					sizeof(dwc3_xhci_plat_priv));
+	if (ret)
+		goto err;
+
 	memset(props, 0, sizeof(struct property_entry) * ARRAY_SIZE(props));
 
 	if (dwc->usb3_lpm_capable)
Signature · 1 line
2.35.1
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 11 lines · Johan Hovold

The dwc3 driver manages its PHYs itself so the USB core PHY management needs to be disabled.

Use the struct xhci_plat_priv hack added by commits 46034a999c07 ("usb:
host: xhci-plat: add platform data support") and f768e718911e ("usb:
host: xhci-plat: add priv quirk for skip PHY initialization") to propagate the setting for now.

Fixes 4e88d4c08301 ("usb: add a flag to skip PHY initialization to struct usb_hcd")
Fixes 178a0bce05cb ("usb: core: hcd: integrate the PHY wrapper into the HCD core")

(tested on sc7x80 with '[gcc_]usb30_prim_gdsc' set to ALWAYS_ON)