ARM: dts: turris-omnia: Add switch port 6 node
PATCH 1/1 ARM: dts: turris-omnia: Add switch port 6 node
Switch port 6 is connected to eth0, so add appropriate device tree node for it.
--- arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
arch/arm/boot/dts/armada-385-turris-omnia.dts +11 -1
@@ -463,7 +463,17 @@ }; }; - /* port 6 is connected to eth0 */ + ports@6 { + reg = <6>; + label = "cpu"; + ethernet = <ð0>; + phy-mode = "rgmii-id"; + + fixed-link { + speed = <1000>; + full-duplex; + }; + }; }; }; };
Signature · 1 line
2.20.1
Quoted 18 lines · Pali Rohár
Switch port 6 is connected to eth0, so add appropriate device tree node for it.
Fixes 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")Signed-off-by Pali Rohár <[email protected]>--- arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)arch/arm/boot/dts/armada-385-turris-omnia.dts +1
-1@@ -463,7 +463,17 @@ }; }; - /* port 6 is connected to eth0 */ + ports@6 {
arch/arm/boot/dts/armada-385-turris-omnia.dts line 476
Quoted 10 lines
arch/arm/boot/dts/armada-385-turris-omnia.dts +10
-0+ reg = <6>; + label = "cpu"; + ethernet = <ð0>; + phy-mode = "rgmii-id"; + + fixed-link { + speed = <1000>; + full-duplex; + }; + };
Hi Pali
I've not been following Vladimirs work on multiple CPU ports. Is it clearly defined, both for old and new kernels, what happens where there are multiple CPU ports defined?
Andrew
Quoted 32 lines · On Saturday 27 August 2022 20:41:59 Andrew Lunn wrote:
Quoted 18 lines · Pali Rohár
Switch port 6 is connected to eth0, so add appropriate device tree node for it.
Fixes 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")Signed-off-by Pali Rohár <[email protected]>--- arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)arch/arm/boot/dts/armada-385-turris-omnia.dts +1
-1@@ -463,7 +463,17 @@ }; }; - /* port 6 is connected to eth0 */ + ports@6 {arch/arm/boot/dts/armada-385-turris-omnia.dts line 476
Quoted 10 lines
arch/arm/boot/dts/armada-385-turris-omnia.dts +10
-0+ reg = <6>; + label = "cpu"; + ethernet = <ð0>; + phy-mode = "rgmii-id"; + + fixed-link { + speed = <1000>; + full-duplex; + }; + };Hi Pali
Quoted 5 lines
I've not been following Vladimirs work on multiple CPU ports. Is it clearly defined, both for old and new kernels, what happens where there are multiple CPU ports defined?
Andrew
Hello!
On older kernel kernel versions just the first one cpu port works. Like if second node is not defined at all. So I sent this patch to have complete HW definition in DTS, even when kernel does not support all features yet.
Andrew Lunn
Reviewed-byQuoted 11 lines
Quoted 7 lines
Hi Pali
I've not been following Vladimirs work on multiple CPU ports. Is it clearly defined, both for old and new kernels, what happens where there are multiple CPU ports defined?
Andrew
Hello!
On older kernel kernel versions just the first one cpu port works.
O.K, i was worried it might use the last "cpu" port found, and so change things.
Andrew
PING?
Quoted 34 lines · On Thursday 25 August 2022 14:21:02 Pali Rohár wrote:
Switch port 6 is connected to eth0, so add appropriate device tree node for it.
Fixes 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")Signed-off-by Pali Rohár <[email protected]>--- arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)arch/arm/boot/dts/armada-385-turris-omnia.dts +11
-1@@ -463,7 +463,17 @@ }; }; - /* port 6 is connected to eth0 */ + ports@6 { + reg = <6>; + label = "cpu"; + ethernet = <ð0>; + phy-mode = "rgmii-id"; + + fixed-link { + speed = <1000>; + full-duplex; + }; + }; }; }; };Signature · 1 line
2.20.1
Quoted 1 line · Pali Rohár
PING?
You would do better reposting, adding my Reviewed-by:.
My _guess_ would be, any patch which Gregory receives which already has a reviewed-by: on it, will get picked up immediately.
Andrew
PING?
Quoted 34 lines · On Thursday 25 August 2022 14:21:02 Pali Rohár wrote:
Switch port 6 is connected to eth0, so add appropriate device tree node for it.
Fixes 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")Signed-off-by Pali Rohár <[email protected]>--- arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)arch/arm/boot/dts/armada-385-turris-omnia.dts +11
-1@@ -463,7 +463,17 @@ }; }; - /* port 6 is connected to eth0 */ + ports@6 { + reg = <6>; + label = "cpu"; + ethernet = <ð0>; + phy-mode = "rgmii-id"; + + fixed-link { + speed = <1000>; + full-duplex; + }; + }; }; }; };Signature · 1 line
2.20.1
Quoted 4 lines · Pali Rohár
Switch port 6 is connected to eth0, so add appropriate device tree node for it.
Fixes 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")Signed-off-by Pali Rohár <[email protected]>
Applied on mvebu/dt
Thanks,
Gregory
Quoted 30 lines
--- arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)arch/arm/boot/dts/armada-385-turris-omnia.dts +11
-1@@ -463,7 +463,17 @@ }; }; - /* port 6 is connected to eth0 */ + ports@6 { + reg = <6>; + label = "cpu"; + ethernet = <ð0>; + phy-mode = "rgmii-id"; + + fixed-link { + speed = <1000>; + full-duplex; + }; + }; }; }; };Signature · 1 line
2.20.1
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com