Skip to contentSkip to conversation

certs: make system keyring depend on built-in x509 parser

PATCH In review Masahiro Yamada 2 participants 2 messages Sep 12, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 certs: make system keyring depend on built-in x509 parser

Commit e90886291c7c ("certs: make system keyring depend on x509 parser") is not the right fix because x509_load_certificate_list() can be modular.

The combination of CONFIG_SYSTEM_TRUSTED_KEYRING=y and CONFIG_X509_CERTIFICATE_PARSER=m still results in the following error:

LD .tmp_vmlinux.kallsyms1
ld: certs/system_keyring.o: in function `load_system_certificate_list':
system_keyring.c:(.init.text+0x8c): undefined reference to `x509_load_certificate_list'
make: *** [Makefile:1169: vmlinux] Error 1

Fixes e90886291c7c ("certs: make system keyring depend on x509 parser")

---

 certs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
certs/Kconfig +1 -1
index bf9b511573d7..1f109b070877 100644
@@ -43,7 +43,7 @@ config SYSTEM_TRUSTED_KEYRING
 	bool "Provide system-wide ring of trusted keys"
 	depends on KEYS
 	depends on ASYMMETRIC_KEY_TYPE
-	depends on X509_CERTIFICATE_PARSER
+	depends on X509_CERTIFICATE_PARSER = y
 	help
 	  Provide a system keyring to which trusted keys can be added.  Keys in
 	  the keyring are considered to be trusted.  Keys may be added at will
Signature · 1 line
2.34.1
#1 lore raw
Quoted 2 lines · Masahiro Yamada

Commit e90886291c7c ("certs: make system keyring depend on x509 parser") is not the right fix because x509_load_certificate_list() can be modular.

... oif.

certs/Kconfig config SYSTEM_TRUSTED_KEYRING · line 43

Quoted 5 lines
certs/Kconfig +1 -1
@@ -43,7 +43,7 @@ config SYSTEM_TRUSTED_KEYRING
-	depends on X509_CERTIFICATE_PARSER
+	depends on X509_CERTIFICATE_PARSER = y

This works.

Meow!

Signature · 4 lines
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ A white dwarf seeks a red giant for a binary relationship.
⢿⡄⠘⠷⠚⠋⠀
⠈⠳⣄⠀⠀⠀⠀