Skip to contentSkip to conversation

dmaengine: ti: k3-udma-private: Fix refcount leak bug in of_xudma_dev_get()

PATCH Applied Liang He 2 participants 2 messages Jul 20, 2022 – Sep 5, 2022

Subsystems (2)
lore
Share & tools
lore

Liang He

author
#0 lore raw

PATCH v2 1/1 dmaengine: ti: k3-udma-private: Fix refcount leak bug in of_xudma_dev_get()

We should call of_node_put() for the reference returned by of_parse_phandle() in fail path or when it is not used anymore. Here we only need to move the of_node_put() before the check.

Fixes d70241913413 ("dmaengine: ti: k3-udma: Add glue layer for non DMAengine users")

---
changelog:

v2: (1) add blank line based on Peter's advice
(2) successfully compile the code based on Peter's explaination

v1: https://lore.kernel.org/all/[email protected]/

 drivers/dma/ti/k3-udma-private.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/dma/ti/k3-udma-private.c +3 -3
index d4f1e4e9603a..85e00701473c 100644
@@ -31,14 +31,14 @@ struct udma_dev *of_xudma_dev_get(struct device_node *np, const char *property)
 	}
 
 	pdev = of_find_device_by_node(udma_node);
+	if (np != udma_node)
+		of_node_put(udma_node);
+
 	if (!pdev) {
 		pr_debug("UDMA device not found\n");
 		return ERR_PTR(-EPROBE_DEFER);
 	}
 
-	if (np != udma_node)
-		of_node_put(udma_node);
-
 	ud = platform_get_drvdata(pdev);
 	if (!ud) {
 		pr_debug("UDMA has not been probed\n");
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 3 lines · Liang He

We should call of_node_put() for the reference returned by of_parse_phandle() in fail path or when it is not used anymore. Here we only need to move the of_node_put() before the check.

Applied, thanks

Signature · 1 line
~Vinod