Skip to contentSkip to conversation

media: atomisp_gmin_platform: Unexport and split camera_sensor_csi()

PATCH In review Andy Shevchenko 3 participants 4 messages Jul 30, 2022 – Sep 11, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: atomisp_gmin_platform: Unexport and split camera_sensor_csi()

The camera_sensor_csi() is not used outside the module, hence make it static. While at it, split it to _alloc() and _free() to clearly show the idea behind the last parameter @flag that is passed to gmin_csi_cfg().

---
 .../include/linux/atomisp_gmin_platform.h     |  2 -
 .../media/atomisp/pci/atomisp_gmin_platform.c | 68 ++++++++++---------
 2 files changed, 37 insertions(+), 33 deletions(-)
drivers/staging/media/atomisp/include/linux/atomisp_gmin_platform.h +0 -2
index 58e0ea5355a3..5463d11d4295 100644
@@ -26,8 +26,6 @@ struct v4l2_subdev *atomisp_gmin_find_subdev(struct i2c_adapter *adapter,
 int atomisp_gmin_remove_subdev(struct v4l2_subdev *sd);
 int gmin_get_var_int(struct device *dev, bool is_gmin,
 		     const char *var, int def);
-int camera_sensor_csi(struct v4l2_subdev *sd, u32 port,
-		      u32 lanes, u32 format, u32 bayer_order, int flag);
 struct camera_sensor_platform_data *
 gmin_camera_platform_data(
     struct v4l2_subdev *subdev,
drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c +37 -31

86 lines not on this page · raw message

Signature · 1 line
2.35.1
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Andy Shevchenko

The camera_sensor_csi() is not used outside the module, hence make it static. While at it, split it to _alloc() and _free() to clearly show the idea behind the last parameter @flag that is passed to gmin_csi_cfg().

Thanks!

Signature · 1 line
Sakari Ailus
#2 lore raw

+Cc: Hans

Quoted 1 line · Sakari Ailus

On Sat, Jul 30, 2022 at 07:20:27PM +0300, Andy Shevchenko wrote:

...

Quoted 1 line

Thanks!

Hans, maybe you want to include this one into your bunch?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw

Hi,

Quoted 5 lines · Andy Shevchenko

+Cc: Hans

Quoted 1 line · Sakari Ailus

On Sat, Jul 30, 2022 at 07:20:27PM +0300, Andy Shevchenko wrote:

Quoted 7 lines

...

Quoted 1 line

Thanks!

Hans, maybe you want to include this one into your bunch?

Ack, I've added this to my next batch of atomisp cleanup patches which I'm sending out right after this email.

Regards,

Hans