pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2)
Subsystems (3)
PATCH 1/1 pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2)
Move the default values to the 'default' case in the switches.
--- drivers/pinctrl/pinctrl-cy8c95x0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/pinctrl-cy8c95x0.c +2 -2
@@ -357,9 +357,9 @@ static bool cy8c95x0_volatile_register(struct device *dev, unsigned int reg)case CY8C95X0_DRV_PP_SLOW :case CY8C95X0_DRV_HIZ :return true; +default : +return false; } - -return false; }static bool cy8c95x0_precious_register (struct device *dev,unsigned int reg)
Signature · 1 line
2.35.1
Quoted 3 lines · Andy Shevchenko
Move the default values to the 'default' case in the switches.
Signed-off-by Andy Shevchenko <[email protected]>
Patch applied!
drivers/pinctrl/pinctrl-cy8c95x0.c static bool cy8c95x0_volatile_register(struct device *dev, unsigned int reg) · line 363
Quoted 9 lines
case CY8C95X0_DRV_PP_SLOW: case CY8C95X0_DRV_HIZ: return true;drivers/pinctrl/pinctrl-cy8c95x0.c +2
-2+default : +return false; } - -return false; }
Clearly this is better style, I wonder if we could teach checkpatch to look for this? Or cocinelle?
Yours,
Linus Walleij
Quoted 6 lines · Linus Walleij
Quoted 1 line · Andy Shevchenko
Move the default values to the 'default' case in the switches.
Patch applied!
Thanks!
...
Quoted 11 lines
drivers/pinctrl/pinctrl-cy8c95x0.c static bool cy8c95x0_volatile_register(struct device *dev, unsigned int reg) · line 362
Quoted 8 lines
case CY8C95X0_DRV_PP_SLOW: case CY8C95X0_DRV_HIZ: return true;drivers/pinctrl/pinctrl-cy8c95x0.c +2
-2+default : +return false; } - -return false;Clearly this is better style, I wonder if we could teach checkpatch to look for this? Or cocinelle?
The latter I believe. But I'm too busy and too lazy to go that road.
Signature · 2 lines
With Best Regards, Andy Shevchenko