Skip to contentSkip to conversation

"b4 trailers -u" chops off patch subjects

DISCUSSION Dmitry Torokhov 2 participants 3 messages Sep 22, 2022 – Sep 23, 2022 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): YyzWI/[email protected]

#1 lore raw

[CC-ing mailing lists...]

Quoted 45 lines · Dmitry Torokhov

Hi Konstantin,

It looks like "b4 trailers -u" removes patch subjects from commits, leaving only body:

dtor@dtor-ws:~/kernel/linux-next (get_gpiod_from_child-remove)$ git log --oneline -5
a31ab9768271 (HEAD -> get_gpiod_from_child-remove) gpiolib: remove devm_fwnode_get_[index_]gpiod_from_child() 359e79d23882 leds: lgm-sso: switch to using devm_fwnode_gpiod_get()
991ff1b001c0 leds: gpio: switch to using devm_fwnode_gpiod_get()
7820e4c4f360 Get rid of devm_fwnode_get_[index_]gpiod_from_child()
483fed3b5dc8 (tag: next-20220921, origin/master, origin/HEAD) Add linux-next specific files for 20220921 dtor@dtor-ws:~/kernel/linux-next (get_gpiod_from_child-remove)$ b4 trailers -u
Calculating patch-ids from 2 commits
Checking change-id "20220902-get_gpiod_from_child-remove-a62638849e91"
Grabbing search results from lore.kernel.org
---
leds: gpio: switch to using devm_fwnode_gpiod_get()
+ Reviewed-by: Andy Shevchenko <[email protected]> (✓ DKIM/gmail.com)
+ Reviewed-by: Linus Walleij <[email protected]> (✓ DKIM/linaro.org)
leds: lgm-sso: switch to using devm_fwnode_gpiod_get()
+ Reviewed-by: Andy Shevchenko <[email protected]> (✓ DKIM/gmail.com)
+ Reviewed-by: Linus Walleij <[email protected]> (✓ DKIM/linaro.org)
gpiolib: remove devm_fwnode_get_[index_]gpiod_from_child()
+ Acked-by: Bartosz Golaszewski <[email protected]> (✓ DKIM/bgdev-pl.20210112.gappssmtp.com)
+ Reviewed-by: Andy Shevchenko <[email protected]> (✓ DKIM/gmail.com)
+ Reviewed-by: Linus Walleij <[email protected]> (✓ DKIM/linaro.org)
---
Invoking git-filter-repo to update trailers.
New history written in 0.12 seconds...
Completely finished after 0.52 seconds.
Trailers updated.
dtor@dtor-ws:~/kernel/linux-next (get_gpiod_from_child-remove)$ git log --oneline -5
fcd562595314 (HEAD -> get_gpiod_from_child-remove) Now that there are no more users of these APIs in the kernel we can remove them. 34557baea2d5 devm_fwnode_get_gpiod_from_child() is going away as the name is too unwieldy, let's switch to using the new devm_fwnode_gpiod_get(). 443abc336e8d devm_fwnode_get_gpiod_from_child() is going away as the name is too unwieldy, let's switch to using the new devm_fwnode_gpiod_get(). 7820e4c4f360 Get rid of devm_fwnode_get_[index_]gpiod_from_child()
483fed3b5dc8 (tag: next-20220921, origin/master, origin/HEAD) Add linux-next specific files for 20220921 dtor@dtor-ws:~/kernel/linux-next (get_gpiod_from_child-remove)$

Please see how patches changed after running b4. This is with ToT checkout:

6c215d8 ez: don't send a cover letter for a 1-patch series

Thanks!

Signature · 1 line
Dmitry
#2 lore raw
Quoted 2 lines · Dmitry Torokhov
Quoted 2 lines

It looks like "b4 trailers -u" removes patch subjects from commits, leaving only body:

Yikes. This is fixed in master/stable-0.10.y. I'd just introduced it earlier today due to a refactor. I need to add this to the tests.

Thank you for the report.

-K

#3 lore raw
Quoted 8 lines · Konstantin Ryabitsev
Quoted 2 lines · Dmitry Torokhov
Quoted 2 lines

It looks like "b4 trailers -u" removes patch subjects from commits, leaving only body:

Yikes. This is fixed in master/stable-0.10.y. I'd just introduced it earlier today due to a refactor. I need to add this to the tests.

Thank you for the report.

Thank you for the quick fix. I can confirm it is working for me now.

Signature · 1 line
Dmitry