Skip to contentSkip to conversation

Patch "hwmon: (pmbus) Use dev_err_probe() to filter -EPROBE_DEFER error messages" has been added to the 5.10-stable tree

DISCUSSION Marion & Christophe JAILLET 3 participants 3 messages Sep 15, 2022 – Sep 16, 2022 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Le 15/09/2022 à 14:45, Sasha Levin a écrit :

Quoted 7 lines

This is a note to let you know that I've just added the patch titled

hwmon: (pmbus) Use dev_err_probe() to filter -EPROBE_DEFER error messages

to the 5.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 7 lines

The filename of the patch is:
hwmon-pmbus-use-dev_err_probe-to-filter-eprobe_defer.patch
and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Hi,

I'm not sure that this one makes a real sense for backport.

It can't hurt, but it does not fix a real issue, it just voids a potential spurious message.

In my original mail, there is no "stable@" or "fix" or "bug" keywords or "Fixes:" tag. There is also apparently no patch in this backport serie that relies on this patch.

Why has it been selected?

(same for 5.15 and 5.19)

CJ

Quoted 39 lines

commit d20abd39a7843f50e07b6487c205d775f3361ac1

Author: Christophe JAILLET <[email protected]>
Date:   Wed Aug 17 15:04:00 2022 +0200

hwmon: (pmbus) Use dev_err_probe() to filter -EPROBE_DEFER error messages

[ Upstream commit 09e52d17b72d3a4bf6951a90ccd8c97fae04e5cf ]

devm_regulator_register() can return -EPROBE_DEFER, so better use dev_err_probe() instead of dev_err(), it is less verbose in such a case.

It is also more informative, which can't hurt.

drivers/hwmon/pmbus/pmbus_core.c +4 -5
index 117e3ce9c76ad..6d8ace96b0a73 100644
@@ -2322,11 +2322,10 @@ static int pmbus_regulator_register(struct pmbus_data *data)
 
  		rdev = devm_regulator_register(dev, &info->reg_desc[i],
  					       &config);
-		if (IS_ERR(rdev)) {
-			dev_err(dev, "Failed to register %s regulator\n",
-				info->reg_desc[i].name);
-			return PTR_ERR(rdev);
-		}
+		if (IS_ERR(rdev))
+			return dev_err_probe(dev, PTR_ERR(rdev),
+					     "Failed to register %s regulator\n",
+					     info->reg_desc[i].name);
  	}
 
  	return 0;
#2 lore raw
Quoted 23 lines · Marion & Christophe JAILLET

Le 15/09/2022 à 14:45, Sasha Levin a écrit :

Quoted 7 lines

This is a note to let you know that I've just added the patch titled

hwmon: (pmbus) Use dev_err_probe() to filter -EPROBE_DEFER error messages

to the 5.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 7 lines

The filename of the patch is:
hwmon-pmbus-use-dev_err_probe-to-filter-eprobe_defer.patch
and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Hi,

I'm not sure that this one makes a real sense for backport.

It can't hurt, but it does not fix a real issue, it just voids a potential spurious message.

Quoted 7 lines

In my original mail, there is no "stable@" or "fix" or "bug" keywords or "Fixes:" tag.
There is also apparently no patch in this backport serie that relies on this patch.

Why has it been selected?

That is essentially how AUTOSEL works. It picks patches based on keywords. I am sure Sasha can provide details.

Guenter

maintainer
#3 lore raw
Quoted 29 lines · Guenter Roeck
Quoted 28 lines · Marion & Christophe JAILLET

Le 15/09/2022 à 14:45, Sasha Levin a écrit :

Quoted 7 lines

This is a note to let you know that I've just added the patch titled

hwmon: (pmbus) Use dev_err_probe() to filter -EPROBE_DEFER error messages

to the 5.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 7 lines

The filename of the patch is:
hwmon-pmbus-use-dev_err_probe-to-filter-eprobe_defer.patch
and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Hi,

I'm not sure that this one makes a real sense for backport.

It can't hurt, but it does not fix a real issue, it just voids a potential spurious message.

In my original mail, there is no "stable@" or "fix" or "bug" keywords or "Fixes:" tag.
There is also apparently no patch in this backport serie that relies on this patch.

Quoted 4 lines
Quoted 2 lines

Why has it been selected?

That is essentially how AUTOSEL works. It picks patches based on keywords. I am sure Sasha can provide details.

Likely because of how many issues existed in this area (deferred probing), that it got selected automatically. I'll go drop it.

Signature · 2 lines
Thanks,
Sasha