Skip to contentSkip to conversation

rt2x00: define RF5592 in init_eeprom routine

PATCH RESEND Superseded Daniel Golle 2 participants 4 messages Sep 16, 2022 – Sep 17, 2022 Ralink RT2X00 wireless LAN driver

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/15 rt2x00: define RF5592 in init_eeprom routine

From: Tomislav Požega <[email protected]>

This patch fixes following crash on Linksys EA2750 during 5GHz wifi init:

[    7.955153] rt2800pci 0000:01:00.0: card - bus=0x1, slot = 0x0 irq=4
[    7.962259] rt2800pci 0000:01:00.0: loaded eeprom from mtd device "Factory"
[    7.969435] ieee80211 phy0: rt2x00_set_rt: Info - RT chipset 5592, rev 0222 detected
[    7.977348] ieee80211 phy0: rt2800_init_eeprom: Error - Invalid RF chipset 0x0000 detected
[    7.985793] ieee80211 phy0: rt2x00lib_probe_dev: Error - Failed to allocate device
[    7.993569] CPU 0 Unable to handle kernel paging request at virtual address 00000024, epc == 800c8f54, ra == 80249ff8
[    8.004408] Oops[#1]:
---
 drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/wireless/ralink/rt2x00/rt2800lib.c +2 -0
index 18102fbe36d6cc..cc9c5554fdc9ca 100644
@@ -9435,6 +9435,8 @@ static int rt2800_init_eeprom(struct rt2x00_dev *rt2x00dev)
 		rf = RF3853;
 	else if (rt2x00_rt(rt2x00dev, RT5350))
 		rf = RF5350;
+	else if (rt2x00_rt(rt2x00dev, RT5592))
+		rf = RF5592;
 	else
 		rf = rt2x00_get_field16(eeprom, EEPROM_NIC_CONF0_RF_TYPE);
 
Signature · 1 line
2.37.3
#1 lore raw
Quoted 13 lines · Daniel Golle

From: Tomislav Požega <[email protected]>

This patch fixes following crash on Linksys EA2750 during 5GHz wifi init:

[    7.955153] rt2800pci 0000:01:00.0: card - bus=0x1, slot = 0x0 irq=4
[    7.962259] rt2800pci 0000:01:00.0: loaded eeprom from mtd device "Factory"
[    7.969435] ieee80211 phy0: rt2x00_set_rt: Info - RT chipset 5592, rev 0222 detected
[    7.977348] ieee80211 phy0: rt2800_init_eeprom: Error - Invalid RF chipset 0x0000 detected
[    7.985793] ieee80211 phy0: rt2x00lib_probe_dev: Error - Failed to allocate device
[    7.993569] CPU 0 Unable to handle kernel paging request at virtual address 00000024, epc == 800c8f54, ra == 80249ff8
[    8.004408] Oops[#1]:
Quoted 1 line

Please add your's signed-off-by and fix the changelog. Patch fixes incorrect rf value encoded in eeprom, not a crash. IIRC crash itself was caused by incorrect rt2x00->eeprom_file pointer, happend when rt2800_init_eeprom() returned error. And should be alredy fixed in openwrt tree.

#2 lore raw
Quoted 14 lines · Stanislaw Gruszka
Quoted 13 lines · Daniel Golle

From: Tomislav Požega <[email protected]>

This patch fixes following crash on Linksys EA2750 during 5GHz wifi init:

[    7.955153] rt2800pci 0000:01:00.0: card - bus=0x1, slot = 0x0 irq=4
[    7.962259] rt2800pci 0000:01:00.0: loaded eeprom from mtd device "Factory"
[    7.969435] ieee80211 phy0: rt2x00_set_rt: Info - RT chipset 5592, rev 0222 detected
[    7.977348] ieee80211 phy0: rt2800_init_eeprom: Error - Invalid RF chipset 0x0000 detected
[    7.985793] ieee80211 phy0: rt2x00lib_probe_dev: Error - Failed to allocate device
[    7.993569] CPU 0 Unable to handle kernel paging request at virtual address 00000024, epc == 800c8f54, ra == 80249ff8
[    8.004408] Oops[#1]:
Quoted 7 lines
Quoted 1 line

Please add your's signed-off-by and fix the changelog. Patch fixes incorrect rf value encoded in eeprom, not a crash. IIRC crash itself was caused by incorrect rt2x00->eeprom_file pointer, happend when rt2800_init_eeprom() returned error. And should be alredy fixed in openwrt tree.

The crash was fixed by:
https://patchwork.ozlabs.org/project/openwrt/patch/[email protected]/

#3 lore raw
Quoted 17 lines · Stanislaw Gruszka
Quoted 16 lines · Stanislaw Gruszka
Quoted 14 lines · Daniel Golle

From: Tomislav Požega <[email protected]>

This patch fixes following crash on Linksys EA2750 during 5GHz wifi init:

[    7.955153] rt2800pci 0000:01:00.0: card - bus=0x1, slot = 0x0 irq=4
[    7.962259] rt2800pci 0000:01:00.0: loaded eeprom from mtd device "Factory"
[    7.969435] ieee80211 phy0: rt2x00_set_rt: Info - RT chipset 5592, rev 0222 detected
[    7.977348] ieee80211 phy0: rt2800_init_eeprom: Error - Invalid RF chipset 0x0000 detected
[    7.985793] ieee80211 phy0: rt2x00lib_probe_dev: Error - Failed to allocate device
[    7.993569] CPU 0 Unable to handle kernel paging request at virtual address 00000024, epc == 800c8f54, ra == 80249ff8
[    8.004408] Oops[#1]:
Quoted 8 lines
Quoted 5 lines

Please add your's signed-off-by and fix the changelog. Patch fixes incorrect rf value encoded in eeprom, not a crash. IIRC crash itself was caused by incorrect rt2x00->eeprom_file pointer, happend when rt2800_init_eeprom() returned error. And should be alredy fixed in openwrt tree.

The crash was fixed by:
https://patchwork.ozlabs.org/project/openwrt/patch/[email protected]/

Yes, the itself has been fixed. For working wifi it's just the RF value in EEPROM which needs overriding with RT5592 PCIe radio (a single chip with built-in RF frontend), which is also what the vendor driver does afair. I will update the commit message in v2.