media: v4l: subdev: Document s_power() callback is deprecated
PATCH v2 1/1 media: v4l: subdev: Document s_power() callback is deprecated
Runtime PM has been around for a decade or more, there's hardly a need to use the V4L2 specific s_power() callback in drivers anymore. Document this in s_power() callback documentation as well.
--- include/media/v4l2-subdev.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
include/media/v4l2-subdev.h +4 -1
@@ -176,7 +176,10 @@ struct v4l2_subdev_io_pin_config {* @s_register: callback for VIDIOC_DBG_S_REGISTER() ioctl handler code. * * @s_power: puts subdevice in power saving mode (on == 0) or normal operation -* mode (on == 1). +* mode (on == 1). DEPRECATED. See +* Documentation/driver-api/media/camera-sensor.rst . pre_streamon and +* post_streamoff callbacks can be used for e.g. setting the bus to LP-11 +* mode before s_stream is called. * * @interrupt_service_routine: Called by the bridge chip's interrupt service * handler, when an interrupt status has be raised due to this subdev,
Signature · 1 line
2.30.2
Quoted 15 lines · Sakari Ailus
Runtime PM has been around for a decade or more, there's hardly a need to use the V4L2 specific
s_power()callback in drivers anymore. Document this ins_power()callback documentation as well.Signed-off-by Sakari Ailus <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>--- include/media/v4l2-subdev.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)include/media/v4l2-subdev.h +0
-0
include/media/v4l2-subdev.h struct v4l2_subdev_io_pin_config { · line 180
Quoted 6 lines
include/media/v4l2-subdev.h +2
-1@@ -176,7 +176,10 @@ struct v4l2_subdev_io_pin_config {* @s_register: callback for VIDIOC_DBG_S_REGISTER() ioctl handler code. * * @s_power: puts subdevice in power saving mode (on == 0) or normal operation -* mode (on == 1). +* mode (on == 1). DEPRECATED. See +* Documentation/driver-api/media/camera-sensor.rst . pre_streamon and
Extra space before '.'
include/media/v4l2-subdev.h struct v4l2_subdev_io_pin_config { · line 182
Quoted 2 lines
include/media/v4l2-subdev.h +2
-0+* post_streamoff callbacks can be used for e.g. setting the bus to LP-11 +* mode before s_stream is called.
Technically post_streamoff doesn't really match that description, but that's OK.
Quoted 3 lines
include/media/v4l2-subdev.h +0
-0* * @interrupt_service_routine: Called by the bridge chip's interrupt service * handler, when an interrupt status has be raised due to this subdev,
Signature · 3 lines
Regards, Laurent Pinchart
Hi Laurent,
Quoted 11 lines · Laurent Pinchart
Quoted 10 lines · Sakari Ailus
Runtime PM has been around for a decade or more, there's hardly a need to use the V4L2 specific
s_power()callback in drivers anymore. Document this ins_power()callback documentation as well.Signed-off-by Sakari Ailus <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>--- include/media/v4l2-subdev.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Quoted 13 lines
include/media/v4l2-subdev.h struct v4l2_subdev_io_pin_config { · line 180
Quoted 11 lines
include/media/v4l2-subdev.h +2
-1@@ -176,7 +176,10 @@ struct v4l2_subdev_io_pin_config {* @s_register: callback for VIDIOC_DBG_S_REGISTER() ioctl handler code. * * @s_power: puts subdevice in power saving mode (on == 0) or normal operation -* mode (on == 1). +* mode (on == 1). DEPRECATED. See +* Documentation/driver-api/media/camera-sensor.rst . pre_streamon and Extra space before '.'
That's intended. It's easier to select that way.
Quoted 6 lines
include/media/v4l2-subdev.h struct v4l2_subdev_io_pin_config { · line 182
Quoted 3 lines
include/media/v4l2-subdev.h +2
-0+* post_streamoff callbacks can be used for e.g. setting the bus to LP-11 +* mode before s_stream is called. Technically
post_streamoffdoesn't really match that description, but that's OK.
Hopefully we can remove this soon... there seem to be 26 users left under drivers/media and most of them are camera sensor drivers.
Quoted 5 lines
Quoted 4 lines
include/media/v4l2-subdev.h +0
-0* * @interrupt_service_routine: Called by the bridge chip's interrupt service * handler, when an interrupt status has be raised due to this subdev,
Signature · 3 lines
Regards, Sakari Ailus