media: flexcop-usb: fix endpoint type check

PATCH RESEND In review Johan Hovold 3 participants 8 messages Aug 22, 2022 – Sep 26, 2022

Subsystems (3)

Stable branch Media (V4L/DVB) USB

lore

Share & tools

lore

Johan Hovold

author

2022-08-22 15:17 UTC #0 lore raw

PATCH RESEND 1/1 media: flexcop-usb: fix endpoint type check

Commit d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type") tried to add an endpoint type sanity check for the single isochronous endpoint but instead broke the driver by checking the wrong descriptor or random data beyond the last endpoint descriptor.

Make sure to check the right endpoint descriptor.

Fixes d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type")

Cc Oliver Neukum <[email protected]>

Cc [email protected] # 5.9

Reported-by Dongliang Mu <[email protected]>

Signed-off-by Johan Hovold <[email protected]>

---

It's been two months and two completely ignored reminders so resending.

Can someone please pick this fix up and let me know when that has been done?

Johan

 drivers/media/usb/b2c2/flexcop-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/media/usb/b2c2/flexcop-usb.c +1 -1

index 7835bb0f32fc..e012b21c4fd7 100644
@@ -511,7 +511,7 @@ static int flexcop_usb_init(struct flexcop_usb *fc_usb)
 
 	if (fc_usb->uintf->cur_altsetting->desc.bNumEndpoints < 1)
 		return -ENODEV;
-	if (!usb_endpoint_is_isoc_in(&fc_usb->uintf->cur_altsetting->endpoint[1].desc))
+	if (!usb_endpoint_is_isoc_in(&fc_usb->uintf->cur_altsetting->endpoint[0].desc))
 		return -ENODEV;
 
 	switch (fc_usb->udev->speed) {

Signature · 1 line

2.35.1

Johan Hovold

author

2022-09-20 09:01 UTC #1 lore raw

Mauro and Hans,

Quoted 12 lines · Johan Hovold

Commit d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type") tried to add an endpoint type sanity check for the single isochronous endpoint but instead broke the driver by checking the wrong descriptor or random data beyond the last endpoint descriptor.
Make sure to check the right endpoint descriptor.
Fixes d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type")
Cc Oliver Neukum <[email protected]>
Cc [email protected] # 5.9
Reported-by Dongliang Mu <[email protected]>
Signed-off-by Johan Hovold <[email protected]>

Quoted 6 lines

---
It's been two months and two completely ignored reminders so resending.
Can someone please pick this fix up and let me know when that has been done?

It's been another month so sending yet another reminder. This driver as been broken since 5.9 and I posted this fix almost four months ago and have sent multiple reminders since.

Can someone please pick this one and the follow-up cleanups up?

Johan

Quoted 16 lines

 drivers/media/usb/b2c2/flexcop-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/media/usb/b2c2/flexcop-usb.c +1 -1

index 7835bb0f32fc..e012b21c4fd7 100644
@@ -511,7 +511,7 @@ static int flexcop_usb_init(struct flexcop_usb *fc_usb)
 
 	if (fc_usb->uintf->cur_altsetting->desc.bNumEndpoints < 1)
 		return -ENODEV;
-	if (!usb_endpoint_is_isoc_in(&fc_usb->uintf->cur_altsetting->endpoint[1].desc))
+	if (!usb_endpoint_is_isoc_in(&fc_usb->uintf->cur_altsetting->endpoint[0].desc))
 		return -ENODEV;
 
 	switch (fc_usb->udev->speed) {

Greg Kroah-Hartman

maintainer

2022-09-22 08:41 UTC #2 lore raw

Quoted 19 lines · Johan Hovold

Mauro and Hans,
Quoted 16 lines · Johan Hovold
Commit d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type") tried to add an endpoint type sanity check for the single isochronous endpoint but instead broke the driver by checking the wrong descriptor or random data beyond the last endpoint descriptor.
Make sure to check the right endpoint descriptor.
Fixes d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type")
Cc Oliver Neukum <[email protected]>
Cc [email protected] # 5.9
Reported-by Dongliang Mu <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
It's been two months and two completely ignored reminders so resending.

Quoted 8 lines

Quoted 2 lines
Can someone please pick this fix up and let me know when that has been done?
It's been another month so sending yet another reminder. This driver as been broken since 5.9 and I posted this fix almost four months ago and have sent multiple reminders since.
Can someone please pick this one and the follow-up cleanups up?

I've taken this one in my tree now. Which one were the "follow-up" cleanups?

thanks,

greg k-h

Johan Hovold

author

2022-09-22 09:37 UTC #3 lore raw

Quoted 23 lines · Greg Kroah-Hartman

Quoted 22 lines · Johan Hovold
Mauro and Hans,
Quoted 18 lines · Johan Hovold
Commit d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type") tried to add an endpoint type sanity check for the single isochronous endpoint but instead broke the driver by checking the wrong descriptor or random data beyond the last endpoint descriptor.
Make sure to check the right endpoint descriptor.
Fixes d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type")
Cc Oliver Neukum <[email protected]>
Cc [email protected] # 5.9
Reported-by Dongliang Mu <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
It's been two months and two completely ignored reminders so resending.
Can someone please pick this fix up and let me know when that has been done?

Quoted 8 lines

Quoted 5 lines
It's been another month so sending yet another reminder. This driver as been broken since 5.9 and I posted this fix almost four months ago and have sent multiple reminders since.
Can someone please pick this one and the follow-up cleanups up?
I've taken this one in my tree now. Which one were the "follow-up" cleanups?

Thanks. These are the follow-up cleanups:

	https://lore.kernel.org/lkml/[email protected]/

Perhaps we should start taking USB related changes like this through the USB tree by default. Posting patches to the media subsystem feels like shooting patches at a black hole.

Johan

Greg Kroah-Hartman

maintainer

2022-09-22 10:12 UTC #4 lore raw

Quoted 28 lines · Johan Hovold

Quoted 27 lines · Greg Kroah-Hartman
Quoted 26 lines · Johan Hovold
Mauro and Hans,
Quoted 12 lines · Johan Hovold
Commit d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type") tried to add an endpoint type sanity check for the single isochronous endpoint but instead broke the driver by checking the wrong descriptor or random data beyond the last endpoint descriptor.
Make sure to check the right endpoint descriptor.
Fixes d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type")
Cc Oliver Neukum <[email protected]>
Cc [email protected] # 5.9
Reported-by Dongliang Mu <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
Quoted 6 lines
---
It's been two months and two completely ignored reminders so resending.
Can someone please pick this fix up and let me know when that has been done?
It's been another month so sending yet another reminder. This driver as been broken since 5.9 and I posted this fix almost four months ago and have sent multiple reminders since.

Quoted 8 lines

Quoted 4 lines
Quoted 1 line
Can someone please pick this one and the follow-up cleanups up?
I've taken this one in my tree now. Which one were the "follow-up" cleanups?
Thanks. These are the follow-up cleanups:
	https://lore.kernel.org/lkml/[email protected]/

Thanks, I'll take them after the first one was merged into Linus's tree.

Quoted 3 lines

Perhaps we should start taking USB related changes like this through the USB tree by default. Posting patches to the media subsystem feels like shooting patches at a black hole.

I agree, there's been a bunch of patches sent there (some with security fixes) that are not getting responded to :(

thanks,

greg k-h

Sean Young

2022-09-22 10:39 UTC #5 lore raw

Quoted 5 lines · Greg Kroah-Hartman

Quoted 3 lines · Johan Hovold
Thanks. These are the follow-up cleanups:
	https://lore.kernel.org/lkml/[email protected]/

Quoted 8 lines

Thanks, I'll take them after the first one was merged into Linus's tree.
Quoted 3 lines
Perhaps we should start taking USB related changes like this through the USB tree by default. Posting patches to the media subsystem feels like shooting patches at a black hole.
I agree, there's been a bunch of patches sent there (some with security fixes) that are not getting responded to :(

The patches were missed are all DVB related, which is Mauro's responsibility.

As far as I can see, other parts of the media subsystem are well looked after.

Sean

Greg Kroah-Hartman

maintainer

2022-09-22 10:43 UTC #6 lore raw

Quoted 12 lines · Sean Young

Quoted 11 lines · Greg Kroah-Hartman
Quoted 3 lines · Johan Hovold
Thanks. These are the follow-up cleanups:
	https://lore.kernel.org/lkml/[email protected]/
Thanks, I'll take them after the first one was merged into Linus's tree.
Quoted 3 lines
Perhaps we should start taking USB related changes like this through the USB tree by default. Posting patches to the media subsystem feels like shooting patches at a black hole.

Quoted 6 lines

Quoted 2 lines
I agree, there's been a bunch of patches sent there (some with security fixes) that are not getting responded to :(
The patches were missed are all DVB related, which is Mauro's responsibility.
As far as I can see, other parts of the media subsystem are well looked after.

That's good, it's hard to know who is responsible for which parts at times.

Hopefully Mauro comes back soon...

greg k-h

Greg Kroah-Hartman

maintainer

2022-09-26 09:00 UTC #7 lore raw

In reply to Greg Kroah-Hartman

Quoted 31 lines · Greg Kroah-Hartman

Quoted 30 lines · Johan Hovold
Quoted 29 lines · Greg Kroah-Hartman
Quoted 27 lines · Johan Hovold
Mauro and Hans,
Quoted 12 lines · Johan Hovold
Commit d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type") tried to add an endpoint type sanity check for the single isochronous endpoint but instead broke the driver by checking the wrong descriptor or random data beyond the last endpoint descriptor.
Make sure to check the right endpoint descriptor.
Fixes d725d20e81c2 ("media: flexcop-usb: sanity checking of endpoint type")
Cc Oliver Neukum <[email protected]>
Cc [email protected] # 5.9
Reported-by Dongliang Mu <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
Quoted 6 lines
---
It's been two months and two completely ignored reminders so resending.
Can someone please pick this fix up and let me know when that has been done?
It's been another month so sending yet another reminder. This driver as been broken since 5.9 and I posted this fix almost four months ago and have sent multiple reminders since.
Can someone please pick this one and the follow-up cleanups up?

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
I've taken this one in my tree now. Which one were the "follow-up" cleanups?
Thanks. These are the follow-up cleanups:
	https://lore.kernel.org/lkml/[email protected]/
Thanks, I'll take them after the first one was merged into Linus's tree.

All now queued up, thanks.

greg k-h