mfd: syscon: Remove repetition of the regmap_get_val_endian()

PATCH Applied Andy Shevchenko 6 participants 9 messages Aug 8, 2022 – Oct 24, 2022

Subsystems (3)

Multifunction devices (MFD) Regressions System configuration (syscon)

lore

Share & tools

lore

Andy Shevchenko

author

2022-08-08 14:08 UTC #0 lore raw

PATCH 1/1 mfd: syscon: Remove repetition of the regmap_get_val_endian()

Since the commit 0dbdb76c0ca8 ("regmap: mmio: Parse endianness definitions from DT") regmap MMIO parses DT itsef, no need to repeat this in the caller(s).

Signed-off-by Andy Shevchenko <[email protected]>

---
 drivers/mfd/syscon.c | 8 --------
 1 file changed, 8 deletions(-)

drivers/mfd/syscon.c +0 -8

index 651cc6f3fd3f..15b74dcb0744 100644
@@ -66,14 +66,6 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_clk)
 		goto err_map;
 	}
 
-	/* Parse the device's DT node for an endianness specification */
-	if (of_property_read_bool(np, "big-endian"))
-		syscon_config.val_format_endian = REGMAP_ENDIAN_BIG;
-	else if (of_property_read_bool(np, "little-endian"))
-		syscon_config.val_format_endian = REGMAP_ENDIAN_LITTLE;
-	else if (of_property_read_bool(np, "native-endian"))
-		syscon_config.val_format_endian = REGMAP_ENDIAN_NATIVE;
-
 	/*
 	 * search for reg-io-width property in DT. If it is not provided,
 	 * default to 4 bytes. regmap_init_mmio will return an error if values

Signature · 1 line

2.35.1

Andy Shevchenko

author

2022-09-28 17:18 UTC #1 lore raw

Quoted 3 lines · Andy Shevchenko

Since the commit 0dbdb76c0ca8 ("regmap: mmio: Parse endianness definitions from DT") regmap MMIO parses DT itsef, no need to repeat this in the caller(s).

Any comment?

Signature · 2 lines

With Best Regards,
Andy Shevchenko

Lee Jones

maintainer Applied

2022-09-29 18:08 UTC #2 lore raw

In reply to Andy Shevchenko

Quoted 8 lines · Andy Shevchenko

Since the commit 0dbdb76c0ca8 ("regmap: mmio: Parse endianness definitions from DT") regmap MMIO parses DT itsef, no need to repeat this in the caller(s).
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/mfd/syscon.c | 8 --------
 1 file changed, 8 deletions(-)

Applied, thanks.

Signature · 1 line

Lee Jones [李琼斯]

Jason A. Donenfeld

2022-10-23 19:46 UTC #3 lore raw

Quoted 6 lines · Lee Jones

Quoted 4 lines · Andy Shevchenko
Since the commit 0dbdb76c0ca8 ("regmap: mmio: Parse endianness definitions from DT") regmap MMIO parses DT itsef, no need to repeat this in the caller(s).

Quoted 6 lines

Quoted 4 lines
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/mfd/syscon.c | 8 --------
 1 file changed, 8 deletions(-)
Applied, thanks.

Linus applied this already:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ca4582c286aa4465f9d1a72bef34b04ee907d42e

Lee Jones

maintainer

2022-10-24 07:12 UTC #4 lore raw

Quoted 12 lines · Jason A. Donenfeld

Quoted 11 lines · Lee Jones
Quoted 8 lines · Andy Shevchenko
Since the commit 0dbdb76c0ca8 ("regmap: mmio: Parse endianness definitions from DT") regmap MMIO parses DT itsef, no need to repeat this in the caller(s).
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/mfd/syscon.c | 8 --------
 1 file changed, 8 deletions(-)

Quoted 4 lines

Quoted 1 line
Applied, thanks.
Linus applied this already:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ca4582c286aa4465f9d1a72bef34b04ee907d42e

Even better, thanks.

Signature · 1 line

Lee Jones [李琼斯]

Guenter Roeck

2022-10-09 16:39 UTC #5 lore raw

In reply to Andy Shevchenko

Quoted 5 lines · Andy Shevchenko

Since the commit 0dbdb76c0ca8 ("regmap: mmio: Parse endianness definitions from DT") regmap MMIO parses DT itsef, no need to repeat this in the caller(s).
Signed-off-by Andy Shevchenko <[email protected]>

This patch results in reboot failures for all big endian mips emulations.

Sample log:

Network interface test passed
Boot successful.
Rebooting
reboot: Restarting system
Unable to restart system
Reboot failed -- System halted

The problem is not seen with little endian mips emulations. Reverting this patch fixes the problem. Bisect log attached.

#regzbot introduced: 72a95859728a
#regzbot title: Reboot failure on big endian mips systems

Guenter

---
# bad: [a6afa4199d3d038fbfdff5511f7523b0e30cb774] Merge tag 'mailbox-v6.1' of git://git.linaro.org/landing-teams/working/fujitsu/integration
# good: [4c86114194e644b6da9107d75910635c9e87179e] Merge tag 'iomap-6.1-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
git bisect start 'HEAD' '4c86114194e6'
# bad: [6181073dd6a7e5deafc60e7981bd765b6c93da8c] Merge tag 'tty-6.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
git bisect bad 6181073dd6a7e5deafc60e7981bd765b6c93da8c
# bad: [94e8ca6ebd1bc20a193eb552dee4de884a954938] Merge tag 'rproc-v6.1' of git://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux
git bisect bad 94e8ca6ebd1bc20a193eb552dee4de884a954938
# good: [9d84bb40bcb30a7fa16f33baa967aeb9953dda78] Merge tag 'drm-next-2022-10-07-1' of git://anongit.freedesktop.org/drm/drm
git bisect good 9d84bb40bcb30a7fa16f33baa967aeb9953dda78
# good: [5d435a3f7b6cb1db566d0f56f5f8dc33be0dde69] Merge tag 'media/v6.1-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
git bisect good 5d435a3f7b6cb1db566d0f56f5f8dc33be0dde69
# bad: [ae9559594cb851aff774d5bea243b84c6acf761d] Merge tag 'mfd-next-6.1' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
git bisect bad ae9559594cb851aff774d5bea243b84c6acf761d
# good: [834382ea32865a4bdeae83ec2dcb9321dc9489f2] mfd: da9061: Fix Failed to set Two-Wire Bus Mode.
git bisect good 834382ea32865a4bdeae83ec2dcb9321dc9489f2
# good: [2f5b0059b31a3e554cb8c5a40682411a2f53f4d3] Merge branch 'for-6.1/nintendo' into for-linus
git bisect good 2f5b0059b31a3e554cb8c5a40682411a2f53f4d3
# good: [430257d8329b58170a92364597e474fa607e28b2] Merge branch 'for-6.1/uclogic' into for-linus
git bisect good 430257d8329b58170a92364597e474fa607e28b2
# good: [cb7c02e91c31f55d08760f04a09bf9334d809426] Merge branch 'for-6.1/google' into for-linus
git bisect good cb7c02e91c31f55d08760f04a09bf9334d809426
# good: [02010cf0093629b9eeadade1f2684d85eaa3390f] mfd: ocelot-spi: Add missing MODULE_DEVICE_TABLE
git bisect good 02010cf0093629b9eeadade1f2684d85eaa3390f
# bad: [72a95859728a7866522e6633818bebc1c2519b17] mfd: syscon: Remove repetition of the regmap_get_val_endian()
git bisect bad 72a95859728a7866522e6633818bebc1c2519b17

# first bad commit: [72a95859728a7866522e6633818bebc1c2519b17] mfd: syscon: Remove repetition of the regmap_get_val_endian()

Andy Shevchenko

author

2022-10-10 06:49 UTC #6 lore raw

Quoted 18 lines · Guenter Roeck

Quoted 5 lines · Andy Shevchenko
Since the commit 0dbdb76c0ca8 ("regmap: mmio: Parse endianness definitions from DT") regmap MMIO parses DT itsef, no need to repeat this in the caller(s).
Signed-off-by Andy Shevchenko <[email protected]>
This patch results in reboot failures for all big endian mips emulations.
Sample log:
Network interface test passed
Boot successful.
Rebooting
reboot: Restarting system
Unable to restart system
Reboot failed -- System halted

Quoted 5 lines

The problem is not seen with little endian mips emulations. Reverting this patch fixes the problem. Bisect log attached.
#regzbot introduced: 72a95859728a
#regzbot title: Reboot failure on big endian mips systems

Right, Jason sent a revert already, but Linus asked for the proper submission.

Signature · 2 lines

With Best Regards,
Andy Shevchenko

Thorsten Leemhuis

maintainer

2022-10-23 15:08 UTC #7 lore raw

In reply to Guenter Roeck

Quoted 18 lines · Guenter Roeck

Quoted 5 lines · Andy Shevchenko
Since the commit 0dbdb76c0ca8 ("regmap: mmio: Parse endianness definitions from DT") regmap MMIO parses DT itsef, no need to repeat this in the caller(s).
Signed-off-by Andy Shevchenko <[email protected]>
This patch results in reboot failures for all big endian mips emulations.
Sample log:
Network interface test passed
Boot successful.
Rebooting
reboot: Restarting system
Unable to restart system
Reboot failed -- System halted

Quoted 5 lines

The problem is not seen with little endian mips emulations. Reverting this patch fixes the problem. Bisect log attached.
#regzbot introduced: 72a95859728a
#regzbot title: Reboot failure on big endian mips systems

#regzbot monitor: https://lore.kernel.org/all/[email protected]/

Thorsten Leemhuis

2022-10-24 08:16 UTC #8 lore raw

Quoted 19 lines · Thorsten Leemhuis

Quoted 18 lines · Guenter Roeck
Quoted 5 lines · Andy Shevchenko
Since the commit 0dbdb76c0ca8 ("regmap: mmio: Parse endianness definitions from DT") regmap MMIO parses DT itsef, no need to repeat this in the caller(s).
Signed-off-by Andy Shevchenko <[email protected]>
This patch results in reboot failures for all big endian mips emulations.
Sample log:
Network interface test passed
Boot successful.
Rebooting
reboot: Restarting system
Unable to restart system
Reboot failed -- System halted

Quoted 7 lines

Quoted 5 lines
The problem is not seen with little endian mips emulations. Reverting this patch fixes the problem. Bisect log attached.
#regzbot introduced: 72a95859728a
#regzbot title: Reboot failure on big endian mips systems
#regzbot monitor: https://lore.kernel.org/all/[email protected]/

#regzbot fixed-by: ca4582c286aa4465