ARM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port
PATCH v2 1/1 ARM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port
According to c8sectpfe driver code we first drive reset line low and then high to reset the port, therefore the reset line is supposed to be annotated as "active low". This will be important when we convert the driver to gpiod API.
---
v2: fixed typo in the subject, added Patrice's reviewed-by
arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stihxxx-b2120.dtsi +1 -1
@@ -178,7 +178,7 @@ tsin0: port { tsin-num = <0>; serial-not-parallel; i2c-bus = <&ssc2>; - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>; dvb-card = <STV0367_TDA18212_NIMA_1>; }; };
Signature · 5 lines
2.38.0.rc1.362.ged0d419d3c-goog -- Dmitry
Quoted 8 lines · Dmitry Torokhov
According to c8sectpfe driver code we first drive reset line low and then high to reset the port, therefore the reset line is supposed to be annotated as "active low". This will be important when we convert the driver to gpiod API.
Reviewed-by Patrice Chotard <[email protected]>Signed-off-by Dmitry Torokhov <[email protected]>---
Gentle ping on this one...
Quoted 25 lines
v2: fixed typo in the subject, added Patrice's reviewed-by
arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/stihxxx-b2120.dtsi +1
-1@@ -178,7 +178,7 @@ tsin0: port { tsin-num = <0>; serial-not-parallel; i2c-bus = <&ssc2>; - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>; dvb-card = <STV0367_TDA18212_NIMA_1>; }; };Signature · 5 lines
2.38.0.rc1.362.ged0d419d3c-goog -- Dmitry
Signature · 1 line
Dmitry
Quoted 11 lines · Dmitry Torokhov
Quoted 8 lines · Dmitry Torokhov
According to c8sectpfe driver code we first drive reset line low and then high to reset the port, therefore the reset line is supposed to be annotated as "active low". This will be important when we convert the driver to gpiod API.
Reviewed-by Patrice Chotard <[email protected]>Signed-off-by Dmitry Torokhov <[email protected]>---
Gentle ping on this one...
Hi Dmitry
Sorry for the delay, i will push a STi pull request including your patch.
Patrice
Quoted 27 lines
Quoted 26 lines
v2: fixed typo in the subject, added Patrice's reviewed-by
arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/stihxxx-b2120.dtsi +1
-1@@ -178,7 +178,7 @@ tsin0: port { tsin-num = <0>; serial-not-parallel; i2c-bus = <&ssc2>; - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>; dvb-card = <STV0367_TDA18212_NIMA_1>; }; };Signature · 5 lines
2.38.0.rc1.362.ged0d419d3c-goog -- Dmitry